From: Rob Herring <robh@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Mark Rutland <mark.rutland@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
linux-leds@vger.kernel.org, linux-pm@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v5 02/11] dt-bindings: power: supply: add DT bindings for max77650
Date: Wed, 13 Feb 2019 14:48:34 -0600 [thread overview]
Message-ID: <20190213204834.GA31342@bogus> (raw)
In-Reply-To: <20190213134335.10838-3-brgl@bgdev.pl>
On Wed, Feb 13, 2019 at 02:43:26PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Add the DT binding document for the battery charger module of max77650.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> .../power/supply/max77650-charger.txt | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.txt
>
> diff --git a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> new file mode 100644
> index 000000000000..16e24173c80e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> @@ -0,0 +1,27 @@
> +Battery charger driver for MAX77650 PMIC from Maxim Integrated.
> +
> +This module is part of the MAX77650 MFD device. For more details
> +see Documentation/devicetree/bindings/mfd/max77650.txt.
> +
> +The charger is represented as a sub-node of the PMIC node on the device tree.
> +
> +Required properties:
> +--------------------
> +- compatible: Must be "maxim,max77650-charger"
> +
> +Optional properties:
> +--------------------
> +- min-input-voltage: Minimum CHGIN regulation voltage (in microvolts). Must be
> + one of: 4000000, 4100000, 4200000, 4300000, 4400000,
> + 4500000, 4600000, 4700000.
> +- current-limit: CHGIN input current limit (in microamps). Must be one of:
> + 95000, 190000, 285000, 380000, 475000.
Unit suffix? Really, these should be common properties. We have
some I think. Charger bindings are a mess though...
> +
> +Example:
> +--------
> +
> + charger {
> + compatible = "maxim,max77650-charger";
> + maxim,vchgin-min = <4200000>;
> + maxim,ichgin-lim = <285000>;
Doesn't match above.
> + };
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-02-13 20:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 13:43 [PATCH v5 00/11] mfd: add support for max77650 PMIC Bartosz Golaszewski
2019-02-13 13:43 ` [PATCH v5 01/11] dt-bindings: mfd: add DT bindings for max77650 Bartosz Golaszewski
2019-02-13 20:43 ` Rob Herring
2019-02-13 13:43 ` [PATCH v5 02/11] dt-bindings: power: supply: " Bartosz Golaszewski
2019-02-13 20:48 ` Rob Herring [this message]
2019-02-14 9:29 ` Bartosz Golaszewski
2019-02-14 10:37 ` Pavel Machek
2019-02-14 14:18 ` Rob Herring
2019-02-13 13:43 ` [PATCH v5 03/11] dt-bindings: leds: " Bartosz Golaszewski
2019-02-13 20:49 ` Rob Herring
2019-02-13 13:43 ` [PATCH v5 04/11] dt-bindings: input: " Bartosz Golaszewski
2019-02-13 20:50 ` Rob Herring
2019-02-13 13:43 ` [PATCH v5 05/11] mfd: core: document mfd_add_devices() Bartosz Golaszewski
2019-02-13 13:43 ` [PATCH v5 06/11] mfd: max77650: new core mfd driver Bartosz Golaszewski
2019-02-13 13:43 ` [PATCH v5 07/11] power: supply: max77650: add support for battery charger Bartosz Golaszewski
2019-02-14 10:39 ` Pavel Machek
2019-02-14 10:42 ` Bartosz Golaszewski
2019-02-14 10:51 ` Pavel Machek
2019-02-13 13:43 ` [PATCH v5 08/11] gpio: max77650: add GPIO support Bartosz Golaszewski
2019-02-13 13:43 ` [PATCH v5 09/11] leds: max77650: add LEDs support Bartosz Golaszewski
2019-02-13 13:43 ` [PATCH v5 10/11] input: max77650: add onkey support Bartosz Golaszewski
2019-02-13 13:43 ` [PATCH v5 11/11] MAINTAINERS: add an entry for max77650 mfd driver Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213204834.GA31342@bogus \
--to=robh@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.