From: Brian Masney <masneyb@onstation.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Marc Gonzalez <marc.w.gonzalez@free.fr>,
Linus Walleij <linus.walleij@linaro.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Stephen Boyd <sboyd@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Tree for Feb 13 (drivers/spmi/spmi-pmic-arb.c)
Date: Wed, 13 Feb 2019 18:36:09 -0500 [thread overview]
Message-ID: <20190213233609.GA6859@basecamp> (raw)
In-Reply-To: <d6fc74a7-7873-eb9c-3f47-f92c3d393de0@infradead.org>
On Wed, Feb 13, 2019 at 01:12:08PM -0800, Randy Dunlap wrote:
> On 2/13/19 10:31 AM, Brian Masney wrote:
> > On Wed, Feb 13, 2019 at 06:18:17PM +0100, Marc Gonzalez wrote:
> >> On 13/02/2019 17:47, Randy Dunlap wrote:
> >>
> >>> seen on i386:
> >>>
> >>> when CONFIG_IRQ_DOMAIN_HIERARCHY is not enabled:
> >>>
> >>> ../drivers/spmi/spmi-pmic-arb.c:1154:2: error: unknown field ‘activate’ specified in initializer
> >>> .activate = qpnpint_irq_domain_activate,
> >>> ^
> >>> ../drivers/spmi/spmi-pmic-arb.c:1154:2: warning: initialization from incompatible pointer type [enabled by default]
> >>> ../drivers/spmi/spmi-pmic-arb.c:1154:2: warning: (near initialization for ‘pmic_arb_irq_domain_ops.match’) [enabled by default]
> >>> ../drivers/spmi/spmi-pmic-arb.c:1155:2: error: unknown field ‘alloc’ specified in initializer
> >>> .alloc = qpnpint_irq_domain_alloc,
> >>> ^
> >>> ../drivers/spmi/spmi-pmic-arb.c:1155:2: warning: initialization from incompatible pointer type [enabled by default]
> >>> ../drivers/spmi/spmi-pmic-arb.c:1155:2: warning: (near initialization for ‘pmic_arb_irq_domain_ops.select’) [enabled by default]
> >>> ../drivers/spmi/spmi-pmic-arb.c:1156:2: error: unknown field ‘free’ specified in initializer
> >>> .free = irq_domain_free_irqs_common,
> >>> ^
> >>> ../drivers/spmi/spmi-pmic-arb.c:1156:10: error: ‘irq_domain_free_irqs_common’ undeclared here (not in a function)
> >>> .free = irq_domain_free_irqs_common,
> >>> ^
> >>> ../drivers/spmi/spmi-pmic-arb.c:1157:2: error: unknown field ‘translate’ specified in initializer
> >>> .translate = qpnpint_irq_domain_translate,
> >>> ^
> >>> ../drivers/spmi/spmi-pmic-arb.c:1157:2: warning: initialization from incompatible pointer type [enabled by default]
> >>> ../drivers/spmi/spmi-pmic-arb.c:1157:2: warning: (near initialization for ‘pmic_arb_irq_domain_ops.unmap’) [enabled by default]
> >
> > drivers/pinctrl/qcom/Kconfig already has this in linux-next:
> >
> > config PINCTRL_QCOM_SPMI_PMIC
> > tristate "Qualcomm SPMI PMIC pin controller driver"
> > ...
> > select IRQ_DOMAIN_HIERARCHY
> >
> > Am I missing something else?
>
> That kconfig symbol is not set/enabled.
> However, SPMI_MSM_PMIC_ARB=m and that is where the build error happens.
>
> I am attaching the full randconfig file.
Ohh, I see. I should have looked closer. I initially assumed it was the
spmi-gpio driver. I'll send out a fix in a little bit.
Thanks,
Brian
prev parent reply other threads:[~2019-02-13 23:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 7:39 linux-next: Tree for Feb 13 Stephen Rothwell
2019-02-13 16:47 ` linux-next: Tree for Feb 13 (drivers/spmi/spmi-pmic-arb.c) Randy Dunlap
2019-02-13 17:18 ` Marc Gonzalez
2019-02-13 18:31 ` Brian Masney
2019-02-13 21:12 ` Randy Dunlap
2019-02-13 23:36 ` Brian Masney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213233609.GA6859@basecamp \
--to=masneyb@onstation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=rdunlap@infradead.org \
--cc=sboyd@kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.