From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To: Angus Ainslie <angus@akkea.ca>
Cc: mazziesaccount@gmail.com, Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
heikki.haikola@fi.rohmeurope.com,
mikko.mutanen@fi.rohmeurope.com, Robin Gong <yibin.gong@nxp.com>,
Elven Wang <elven.wang@nxp.com>,
Anson Huang <anson.huang@nxp.com>,
linux-kernel-owner@vger.kernel.org
Subject: Re: [PATCH v2 1/3] devicetree: bindings: bd718x7: document HW state related ROHM specific properties
Date: Thu, 14 Feb 2019 09:15:47 +0200 [thread overview]
Message-ID: <20190214071547.GD12247@localhost.localdomain> (raw)
In-Reply-To: <044d28c6ea1f9dd58f4c1942411aaf58@www.akkea.ca>
Hello Angus,
Glad to hear from you again =)
On Wed, Feb 13, 2019 at 03:38:40PM -0800, Angus Ainslie wrote:
> >
> > Optional properties:
> > - clock-output-names : Should contain name for output clock.
> > +- rohm,reset-snvs-powered : Transfer BD718x7 to SNVS state at reset.
> > +
> > +The BD718x7 supports two different HW states as reset target states.
> > States
> > +are called as SNVS and READY. At READY state all the PMIC power outputs
> > go
> > +down and OTP is reload. At the SNVS state all other logic and external
> > +devices apart from the SNVS power domain are shut off. Please refer to
> > NXP
> > +i.MX8 documentation for further information regarding SNVS state. When
> > a
> > +reset is done via SNVS state the PMIC OTP data is not reload. This
> > cause
> > +
>
> It looks like there is some text missing here.
Actually, the "This cause" is a leftover from previous version. So
nothings missing, just something extra :D But well spotted. I'll clean
this up for next version!
> > diff --git
> > a/Documentation/devicetree/bindings/regulator/rohm,bd71837-regulator.txt
> > b/Documentation/devicetree/bindings/regulator/rohm,bd71837-regulator.txt
> > index 4b98ca26e61a..4a05cbf915ee 100644
> > ---
> > a/Documentation/devicetree/bindings/regulator/rohm,bd71837-regulator.txt
> > +++
> > b/Documentation/devicetree/bindings/regulator/rohm,bd71837-regulator.txt
> > @@ -27,8 +27,38 @@ BUCK1, BUCK2, BUCK3, BUCK4, BUCK5, BUCK6
> > LDO1, LDO2, LDO3, LDO4, LDO5, LDO6
> >
[...]
> > +----------------------------------------------------------------------------
> > +rest | not supported | not supported | not supported
> > +
> > Example:
>
> Could you add an example of the optional properties ?
Sure. I'll do that for next version as well :)
Br,
Matti Vaittinen
--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~~ "I don't think so," said Rene Descartes. Just then, he vanished ~~~
next prev parent reply other threads:[~2019-02-14 7:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 9:49 [PATCH v2 0/3] bd718x7: Support SNVS low power state Matti Vaittinen
2019-02-13 9:50 ` [PATCH v2 1/3] devicetree: bindings: bd718x7: document HW state related ROHM specific properties Matti Vaittinen
2019-02-13 23:38 ` Angus Ainslie
2019-02-14 7:15 ` Matti Vaittinen [this message]
2019-02-13 9:50 ` [PATCH v2 2/3] regulator: add regulator_desc_list_voltage_linear_range Matti Vaittinen
2019-02-13 9:50 ` [PATCH v2 3/3] regulator: bd718x7: Support SNVS low power state Matti Vaittinen
2019-02-14 7:53 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214071547.GD12247@localhost.localdomain \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=angus@akkea.ca \
--cc=anson.huang@nxp.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=elven.wang@nxp.com \
--cc=heikki.haikola@fi.rohmeurope.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel-owner@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mazziesaccount@gmail.com \
--cc=mikko.mutanen@fi.rohmeurope.com \
--cc=robh+dt@kernel.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.