From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding via dri-devel Subject: Re: [PATCH] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad D330 Date: Thu, 14 Feb 2019 11:53:59 +0100 Message-ID: <20190214105359.GB7962@ulmo> References: <20190213124356.GH647@ulmo> Reply-To: Thierry Reding Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1857778069==" Return-path: Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8146C6E155 for ; Thu, 14 Feb 2019 10:54:03 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id x10so5560656wmg.2 for ; Thu, 14 Feb 2019 02:54:03 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David =?utf-8?Q?Santamar=C3=ADa?= Rogado Cc: David Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1857778069== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oC1+HKm2/end4ao3" Content-Disposition: inline --oC1+HKm2/end4ao3 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 13, 2019 at 06:18:26PM +0100, David Santamar=C3=ADa Rogado wrot= e: > I was about to forget the signed off like the void removal patch, so I > mistake adding it just with @ as at. I can resend it with mail > corrected. >=20 > I can't see the white spaces issue, The whitespaces issue I send it > like the mails before as text without format. Anyways I can resend > this entire patch if needed. Resending is probably not going to help if we don't figure out first what's messing with the whitespace. > Thanks for your attention. >=20 > El mi=C3=A9., 13 feb. 2019 a las 13:43, Thierry Reding > () escribi=C3=B3: > > > > On Wed, Feb 13, 2019 at 11:14:51AM +0100, David Santamar=C3=ADa Rogado = wrote: > > > Lenovo Ideapad D330 Pentium CPU version has 1920x1200 LCD. Console > > > ouput gets rotated at boot as Miix 310. > > > > > > Signed-off-by: David Santamar=C3=ADa Rogado > > > > Is something obfuscating your email address here? > > > > > --- > > > drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +++++++++++++ > > > 1 file changed, 13 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c > > > b/drivers/gpu/drm/drm_panel_orientation_quirks.c > > > index 61d3361381b73..835574e2d5bf7 100644 > > > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c > > > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c > > > @@ -80,6 +80,12 @@ static const struct drm_dmi_panel_orientation_data > > > lcd800x1280_rightside_up =3D { > > > .orientation =3D DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, > > > }; > > > > > > +static const struct drm_dmi_panel_orientation_data > > > lcd1200x1920_rightside_up =3D { > > > + .width =3D 1200, > > > + .height =3D 1920, > > > + .orientation =3D DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, > > > +}; > > > + > > > > Looks like that something may be messing up the whitespace in your patch > > as well. If you look at what arrived in my inbox, there is a single space after the + for the lines in the patch. There should be a tab if you've correctly followed the existing indentation in the file. Given that a single space is also present for existing lines (those without a +), I think you must've either generated the patch in a non-standard way, or your email client or server are getting in the way. Are you using gmail to send this patch? Also, are you using git send-email? Thierry --oC1+HKm2/end4ao3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlxlSMUACgkQ3SOs138+ s6ECtw/5AVMyqjcfCVVUDRyIervDqL1SmXIXVgf5Jr/q8W2mgHW7o5SO3gcPe+u9 Q/TI/Xvs2CpeQmj5usVBDGwCFH8hN2gNl06ccTvCeag6EgB2QMqa3jdfJqX/PxBm TM8Ens2UjgAAaPf7gc5P/nkn+1irToYidiaGvrxXG/3Y7frfSISeXP+02lBMKPnf UIRaVz4WYHBR3IRCTa7cBDr3pxE/FAcZ5X8iY7V7KAeihMtwA9G4BboL0u5n3unE fFq1m1Q7BUfTdBavi8LRyzAHH97tqptiCV7SBN6Ud+8erryivkpGy4W5EgPNJzqU o+C3fy43TXPC5PtTzR8DMGGUhvTACl4gZHGG/lHBo1wQJ1bbUeyAF+2cgw4Qgc6Y tOfxSCI0Ykuo8Q56dYNdjIWnYE/kM7yDxsSOV0VsSiLDizxo9UEQKDdmUAGLQYt3 HBdJHaUe6rLDY+xgQ7yIdVAkf1q5QQB8iKOJKWfBChKQzzv+IhjR2l/XKubqVYqb P3aeLowiFi887hGyHR6XmgDXhcEURoHu60m6sepJByudoii54IEPv/LsKVOTlXW0 2fQy01Eh3rmE3zqgvdpBkidPjJxTJGNDpUSuf0RjBu5rx8ZA5iVvpy9ZdBTRQ/tt 37J/+PmqHo7B7rQ3JUcKRaUUaOQYk+Wi9y/qbOVUf2cSa3ZMHeg= =dJZp -----END PGP SIGNATURE----- --oC1+HKm2/end4ao3-- --===============1857778069== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1857778069==--