From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Tobin C . Harding" <me@tobin.cc>, Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 9/9] vsprintf: Avoid confusion between invalid address and value
Date: Thu, 14 Feb 2019 14:45:09 +0200 [thread overview]
Message-ID: <20190214124509.GS9224@smile.fi.intel.com> (raw)
In-Reply-To: <20190214084256.c26jd2b7oow3eatt@pathway.suse.cz>
On Thu, Feb 14, 2019 at 09:42:56AM +0100, Petr Mladek wrote:
> On Wed 2019-02-13 15:54:55, Andy Shevchenko wrote:
> > On Tue, Feb 12, 2019 at 04:45:30PM +0100, Petr Mladek wrote:
> > > On Fri 2019-02-08 19:27:17, Andy Shevchenko wrote:
> > > > On Fri, Feb 08, 2019 at 04:23:10PM +0100, Petr Mladek wrote:
> > > > > We are able to detect invalid values handled by %p[iI] printk specifier.
> > > > > The current error message is "invalid address". It might cause confusion
> > > > > against "(efault)" reported by the generic valid_pointer_address() check.
> > > > >
> > > > > Let's unify the style and use the more appropriate error code description
> > > > > "(einval)".
> > > >
> > > > The proper one should be "invalid address family". The proposed change
> > > > increases confusion.
> > >
> > > I am confused. Is there any error code for "invalid address family"?
> >
> > I'm not sure.
> > There is EAFNOSUPPORT. I don't know if it suits better.
>
> I would not complicate it. EAFNOSUPPORT looks too special,
> see below. Also it is controversial here because vsprintf()
> does not implement any protocol.
>
>
> > > EINVAL is standard error code used when a wrong value is passed
> > > as a parameter. In this case, the code is not able to handle
> > > the given address family.
> >
> > This is possible, but it will produce more generic message.
>
> I am not sure that I understand it. We do not pass the error code
> anywhere. The patch only changes the string that is shown instead
> of the requested value. It is a hint that something is wrong
> either with the caller or with the vsprintf() implementation.
>
> I think that it does not make sense to do a big deal from it.
> "(einval)" looks informative enough to me.
OK, let's go with it.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-02-14 12:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 15:23 [PATCH v6 0/9] vsprintf: Prevent silent crashes and consolidate error handling Petr Mladek
2019-02-08 15:23 ` [PATCH v6 1/9] vsprintf: Shuffle restricted_pointer() Petr Mladek
2019-02-08 15:23 ` [PATCH v6 2/9] vsprintf: Consistent %pK handling for kptr_restrict == 0 Petr Mladek
2019-02-08 15:23 ` [PATCH v6 3/9] vsprintf: Do not check address of well-known strings Petr Mladek
2019-02-08 17:27 ` Andy Shevchenko
2019-02-08 15:23 ` [PATCH v6 4/9] vsprintf: Factor out %p[iI] handler as ip_addr_string() Petr Mladek
2019-02-08 15:23 ` [PATCH v6 5/9] vsprintf: Factor out %pV handler as va_format() Petr Mladek
2019-02-08 17:11 ` Joe Perches
2019-02-12 13:00 ` Petr Mladek
2019-02-12 14:32 ` Steven Rostedt
2019-02-12 17:58 ` Joe Perches
2019-02-12 19:47 ` Steven Rostedt
2019-02-12 20:22 ` Rasmus Villemoes
2019-02-08 15:23 ` [PATCH v6 6/9] vsprintf: Factor out %pO handler as kobject_string() Petr Mladek
2019-02-08 15:23 ` [PATCH v6 7/9] vsprintf: Consolidate handling of unknown pointer specifiers Petr Mladek
2019-02-08 17:25 ` Andy Shevchenko
2019-02-12 13:35 ` Petr Mladek
2019-02-08 15:23 ` [PATCH v6 8/9] vsprintf: Prevent crash when dereferencing invalid pointers Petr Mladek
2019-02-19 3:30 ` Sergey Senozhatsky
2019-02-19 11:02 ` Andy Shevchenko
2019-02-19 12:51 ` Sergey Senozhatsky
2019-02-19 13:49 ` Andy Shevchenko
2019-02-19 14:15 ` Sergey Senozhatsky
2019-02-20 10:24 ` Petr Mladek
2019-02-08 15:23 ` [PATCH v6 9/9] vsprintf: Avoid confusion between invalid address and value Petr Mladek
2019-02-08 17:27 ` Andy Shevchenko
2019-02-12 15:45 ` Petr Mladek
2019-02-13 13:54 ` Andy Shevchenko
2019-02-14 8:42 ` Petr Mladek
2019-02-14 12:45 ` Andy Shevchenko [this message]
2019-02-19 3:03 ` Sergey Senozhatsky
2019-02-19 11:06 ` Andy Shevchenko
2019-02-20 9:24 ` Petr Mladek
2019-02-21 1:47 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214124509.GS9224@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=me@tobin.cc \
--cc=mhocko@suse.cz \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.