All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti via igt-dev <igt-dev@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: IGT dev <igt-dev@lists.freedesktop.org>, Andi Shyti <andi@etezian.org>
Subject: Re: [igt-dev] [RFC PATCH v9 4/5] lib: ioctl_wrappers: reach engines by index as well
Date: Thu, 14 Feb 2019 15:06:14 +0200	[thread overview]
Message-ID: <20190214130614.GC990@intel.intel> (raw)
In-Reply-To: <155013792674.14276.7984912980614234969@skylake-alporthouse-com>

Hi Chris,

> > -bool gem_has_ring(int fd, unsigned ring)
> > +bool gem_context_has_engine(int fd, unsigned ring, unsigned ctx)
> 
> Remember to lift it out of ioctl_wrappers, and as this operates on the
> context (given the name), the context should be a primary argument.

All right, I'll put 'gem_context_has_engine()' in
lib/i915/gem_context.c.

Andi
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2019-02-14 13:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14  0:44 [igt-dev] [RFC PATCH v9 0/5] new engine discovery interface Andi Shyti via igt-dev
2019-02-14  0:44 ` [igt-dev] [RFC PATCH v9 1/5] include/drm-uapi: import i915_drm.h header file Andi Shyti via igt-dev
2019-02-14  0:44 ` [igt-dev] [RFC PATCH v9 2/5] lib/i915: add gem_query library Andi Shyti via igt-dev
2019-02-14  9:42   ` Chris Wilson
2019-02-14 13:02     ` Andi Shyti via igt-dev
2019-02-14 13:08       ` Chris Wilson
2019-02-15  9:59   ` Petri Latvala via igt-dev
2019-02-15 15:09     ` Chris Wilson
2019-02-14  0:44 ` [igt-dev] [RFC PATCH v9 3/5] lib/igt_gt: use for_each_engine2 to loop through engines Andi Shyti via igt-dev
2019-02-14  9:49   ` Chris Wilson
2019-02-14  0:44 ` [igt-dev] [RFC PATCH v9 4/5] lib: ioctl_wrappers: reach engines by index as well Andi Shyti via igt-dev
2019-02-14  9:52   ` Chris Wilson
2019-02-14 13:06     ` Andi Shyti via igt-dev [this message]
2019-02-14  0:44 ` [igt-dev] [RFC PATCH v9 5/5] tests: gem_exec_basic: add "exec-ctx" buffer execution demo test Andi Shyti via igt-dev
2019-02-14  9:56   ` Chris Wilson
2019-02-14 10:14 ` [igt-dev] ✗ Fi.CI.BAT: failure for new engine discovery interface Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190214130614.GC990@intel.intel \
    --to=igt-dev@lists.freedesktop.org \
    --cc=andi.shyti@intel.com \
    --cc=andi@etezian.org \
    --cc=chris@chris-wilson.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.