From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
jgross@suse.com, boris.ostrovsky@oracle.com
Cc: andr2000@gmail.com,
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [Xen-devel][PATCH 2/2] xen/gntdev: Check and release imported dma-bufs on close
Date: Thu, 14 Feb 2019 16:23:21 +0200 [thread overview]
Message-ID: <20190214142321.1138-2-andr2000@gmail.com> (raw)
In-Reply-To: <20190214142321.1138-1-andr2000@gmail.com>
From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Check if there are any imported dma-bufs left not released by
user-space when grant device's release callback is called and
free those if this is the case. This can happen if user-space
leaks the buffers because of a bug or application has been
terminated for any reason.
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
drivers/xen/gntdev-dmabuf.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/xen/gntdev-dmabuf.c b/drivers/xen/gntdev-dmabuf.c
index d97fcfc5e558..2c4f324f8626 100644
--- a/drivers/xen/gntdev-dmabuf.c
+++ b/drivers/xen/gntdev-dmabuf.c
@@ -745,6 +745,14 @@ static int dmabuf_imp_release(struct gntdev_dmabuf_priv *priv, u32 fd)
return 0;
}
+static void dmabuf_imp_release_all(struct gntdev_dmabuf_priv *priv)
+{
+ struct gntdev_dmabuf *q, *gntdev_dmabuf;
+
+ list_for_each_entry_safe(gntdev_dmabuf, q, &priv->imp_list, next)
+ dmabuf_imp_release(priv, gntdev_dmabuf->fd);
+}
+
/* DMA buffer IOCTL support. */
long gntdev_ioctl_dmabuf_exp_from_refs(struct gntdev_priv *priv, int use_ptemod,
@@ -862,5 +870,6 @@ struct gntdev_dmabuf_priv *gntdev_dmabuf_init(struct file *filp)
void gntdev_dmabuf_fini(struct gntdev_dmabuf_priv *priv)
{
+ dmabuf_imp_release_all(priv);
kfree(priv);
}
--
2.20.1
next prev parent reply other threads:[~2019-02-14 14:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 14:23 [Xen-devel][PATCH 1/2] xen/gntdev: Do not destroy context while dma-bufs are in use Oleksandr Andrushchenko
2019-02-14 14:23 ` Oleksandr Andrushchenko [this message]
2019-02-15 15:06 ` [PATCH 2/2] xen/gntdev: Check and release imported dma-bufs on close Boris Ostrovsky
2019-02-15 15:06 ` [Xen-devel][PATCH " Boris Ostrovsky
2019-02-17 10:40 ` [PATCH " Juergen Gross
2019-02-17 10:40 ` [Xen-devel][PATCH " Juergen Gross
2019-02-14 14:23 ` [PATCH " Oleksandr Andrushchenko
2019-02-15 15:03 ` [Xen-devel][PATCH 1/2] xen/gntdev: Do not destroy context while dma-bufs are in use Boris Ostrovsky
2019-02-15 15:07 ` [PATCH " Oleksandr Andrushchenko
2019-02-15 15:07 ` [Xen-devel][PATCH " Oleksandr Andrushchenko
2019-02-15 15:28 ` Boris Ostrovsky
2019-02-15 15:35 ` [PATCH " Oleksandr Andrushchenko
2019-02-15 15:35 ` [Xen-devel][PATCH " Oleksandr Andrushchenko
2019-02-15 16:29 ` [PATCH " Juergen Gross
2019-02-15 16:29 ` [Xen-devel][PATCH " Juergen Gross
2019-02-15 15:28 ` [PATCH " Boris Ostrovsky
2019-02-15 15:03 ` Boris Ostrovsky
2019-02-17 10:39 ` [Xen-devel][PATCH " Juergen Gross
2019-02-17 10:39 ` [PATCH " Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214142321.1138-2-andr2000@gmail.com \
--to=andr2000@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.