From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8F5EC43381 for ; Thu, 14 Feb 2019 15:15:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94D51222C9 for ; Thu, 14 Feb 2019 15:15:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uMWsE+hw"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="oBL95TvL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94D51222C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hx7rSBYb5pXQfJuA91dHBEItHZU605wxx/eOS1r0rSQ=; b=uMWsE+hwiCW0X5 p2yLeZr22fh9O6oSFESzxofzn44qRw8DRAREF3igY38vqq+lBjaMgc8aVMTfkWTRcl+WwmddXj2B5 3g9FJngRsAZWBt5kH3jU7qciBnh/Mh7bdRF6mEO5mAf9S/RgTS5Xau1okVjOP3tCEGkwvUjjzj5dY fEpL8jytyUqNqz99aPDw+WRB+u4EkHgPpXboup1JvJ02hkKm4rOCCpDKxkAvFl7JK6SCHHZ7VA90k 0Oju1LlKuQdZe2eqhYbanr8elh1LoKEj83wOev2Ucei5e5IqFdbDbpJYX0uoUsuvHbEO5TZ4xl2Nx kM5+uXgPh/I4igzrl5MA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1guIjx-0006pq-KP; Thu, 14 Feb 2019 15:15:53 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1guIju-0006pZ-KQ for linux-arm-kernel@lists.infradead.org; Thu, 14 Feb 2019 15:15:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/tB5nLNpanCnlsRpO4c+hlftNaV2fOzM0V9IOQQXhKI=; b=oBL95TvL1HNJhv2ok+EDpHYC6v KzHV+/vXm2PtZ+wJnZhhb3/TZS0inerdEs3IQuhwE6zPtVLKIA+G0Dll2kEcqWQrDXp2eRPXE2Xg+ I9vKxIyau49kBtM0maOw8QLexJm+47G0bWt+1Z03EZ67xnRkYaJnehkBH2UCMHCRmVV4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1guIjk-0002zL-3N; Thu, 14 Feb 2019 16:15:40 +0100 Date: Thu, 14 Feb 2019 16:15:40 +0100 From: Andrew Lunn To: Christophe ROULLIER Subject: Re: [PATCH 2/8] net: ethernet: stmmac: update to support all PHY config for stm32mp157c. Message-ID: <20190214151540.GG708@lunn.ch> References: <1550126763-22669-1-git-send-email-christophe.roullier@st.com> <1550126763-22669-3-git-send-email-christophe.roullier@st.com> <20190214134040.GA5699@lunn.ch> <02cd7773-899f-b28a-ff61-849b17cbe82d@st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <02cd7773-899f-b28a-ff61-849b17cbe82d@st.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190214_071550_824662_364370C4 X-CRM114-Status: UNSURE ( 8.01 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "robh@kernel.org" , Alexandre TORGUE , "devicetree@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "joabreu@synopsys.com" , "mcoquelin.stm32@gmail.com" , Peppe CAVALLARO , "davem@davemloft.net" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Sorry, I've misunderstood your question ;-) > > And you spoke about : > > case PHY_INTERFACE_MODE_RGMII: > case PHY_INTERFACE_MODE_RGMII_ID: > case PHY_INTERFACE_MODE_RGMII_RXID: > case PHY_INTERFACE_MODE_RGMII_TXID: > > So in my setup I've only RGMII interface, so I've never tested 3 others > interfaces (_ID, _RXID, _TXID). > > So do I need to add cases in my driver ? Yes. They all indicate the MAC should be using RGMII. This appears to be an old issue, but now would be a good time to fix it. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 2/8] net: ethernet: stmmac: update to support all PHY config for stm32mp157c. Date: Thu, 14 Feb 2019 16:15:40 +0100 Message-ID: <20190214151540.GG708@lunn.ch> References: <1550126763-22669-1-git-send-email-christophe.roullier@st.com> <1550126763-22669-3-git-send-email-christophe.roullier@st.com> <20190214134040.GA5699@lunn.ch> <02cd7773-899f-b28a-ff61-849b17cbe82d@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <02cd7773-899f-b28a-ff61-849b17cbe82d@st.com> Sender: linux-kernel-owner@vger.kernel.org To: Christophe ROULLIER Cc: "robh@kernel.org" , "davem@davemloft.net" , "joabreu@synopsys.com" , "mark.rutland@arm.com" , "mcoquelin.stm32@gmail.com" , Alexandre TORGUE , Peppe CAVALLARO , "linux-stm32@st-md-mailman.stormreply.com" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" List-Id: devicetree@vger.kernel.org > Sorry, I've misunderstood your question ;-) > > And you spoke about : > > case PHY_INTERFACE_MODE_RGMII: > case PHY_INTERFACE_MODE_RGMII_ID: > case PHY_INTERFACE_MODE_RGMII_RXID: > case PHY_INTERFACE_MODE_RGMII_TXID: > > So in my setup I've only RGMII interface, so I've never tested 3 others > interfaces (_ID, _RXID, _TXID). > > So do I need to add cases in my driver ? Yes. They all indicate the MAC should be using RGMII. This appears to be an old issue, but now would be a good time to fix it. Andrew