From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEB96C10F05 for ; Thu, 14 Feb 2019 19:26:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB93221B68 for ; Thu, 14 Feb 2019 19:26:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="g27gKpqC"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="coa3lgKd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB93221B68 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gSnV0iIlLCxlFNZz1ze0ec3eA7DZ/FCfDUi48IDM4xs=; b=g27gKpqC/t0ey1 RiJRB5tIPf17rQAKipHfNN4wddFAmDa2Ep7wIkRv0AOwIU5TUmhaiRRf7ymzJOuzdXd9uRLC4Pxl2 TT7B1APU9UPlp2NnpDlCAyE7adY26AvTAw2oNaMYcU2k37xSEe9e/ujlofNZBIxikH6tZOTvjwzdx Zs+/jdxC1RTlkIwyzE2UQGnmgaDWQBUjwcWipnzlEMdBf/ZPWw3JdoR0EchSeixSMZE8g/b4tKSAD VujXbIgGbzG4yWEZL2PmAxwYaReTeZ4UcfAW6vMG9mh6xnzvtshxAPO1rud4YxLGvPwkZfNCQrDKA 9d8PjGa68gEcVG6WII2g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1guMeM-0001Qz-4x; Thu, 14 Feb 2019 19:26:22 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1guMe9-00019J-Od for linux-arm-kernel@lists.infradead.org; Thu, 14 Feb 2019 19:26:11 +0000 Received: by mail-pl1-x643.google.com with SMTP id bj4so3653232plb.7 for ; Thu, 14 Feb 2019 11:26:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6RPyU9KlTHdOgkAmLOMKP2ZsiLo1+0ZzZXt5rKrY9KQ=; b=coa3lgKd3W2zLu2VziGXiWdi2qk5QxDTrpA2V0L/4d0k8Na1MyZ7VcBMJzkpIOQmTY bwC+BKOOMMfY/oYkT8xYMgTmOvOa7K2+U0iljl8Ngny+htseLtdLPWUMjdqAVh78LcbF /8qvTLIReYhLio93eNCAvCIo8MzRuYbQ4wSts= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6RPyU9KlTHdOgkAmLOMKP2ZsiLo1+0ZzZXt5rKrY9KQ=; b=renO6TdfQ4M7Ht/h3OsIPmBxA5A+R7ub/Q2J30cn+oNgNgY8QXXg2SJnA9mWbQbaT4 sXVm2j3mIglINRFR5pCSktg8bJIS3XHrKGURCZeVIr+FyFodJuJu/NnM5V3HJpTqIuGn Pr2RNd8uVm8iiweCvQwGXLXn8nJ1h2ahdP5Qz5VHse239NeDBaDJwBBDc4jd7XSXp2/1 GDkeTWC6N2eXg5CsVqY2Jkku/UxFqQ6ifVErLfTOiB94qTHgzyianKCuxnCh4L3sgkzc I7Tf0ILihVew0bvAOHme6YzR8rFk+QfbhmHhZyleZFK6z+HSeSFC49054s60rgYF6Zlj 3dwA== X-Gm-Message-State: AHQUAuadbMlteaSBvFGz4ihDcFVIdNhBR1Wbklde4+1bbzYEB1ZVB2An Oam2m5qIebzTi/cxIsHSQvcD+A== X-Google-Smtp-Source: AHgI3IaiBOPW+CBlLrKkP81yfT4FIZkOlPh6b4UXVprpinR0lR+vBgoOU825d/GhH4kDRSvMHMelvA== X-Received: by 2002:a17:902:b087:: with SMTP id p7mr3905888plr.56.1550172368856; Thu, 14 Feb 2019 11:26:08 -0800 (PST) Received: from localhost.localdomain ([115.97.184.151]) by smtp.gmail.com with ESMTPSA id k71sm8390100pga.44.2019.02.14.11.26.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Feb 2019 11:26:08 -0800 (PST) From: Jagan Teki To: Maxime Ripard , David Airlie , Daniel Vetter , Chen-Yu Tsai Subject: [PATCH v8 1/8] drm/sun4i: sun6i_mipi_dsi: Fix VBP size calculation Date: Fri, 15 Feb 2019 00:55:37 +0530 Message-Id: <20190214192544.7314-2-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20190214192544.7314-1-jagan@amarulasolutions.com> References: <20190214192544.7314-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190214_112609_797992_42F89894 X-CRM114-Status: GOOD ( 13.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jagan Teki , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org The horizontal and vertical back porch calculation in BSP code is simply following the Linux drm comment diagram, in include/drm/drm_modes.h which is [hv]back porch = [hv]total - [hv]sync_end BSP code form BPI-M64-bsp is calculating vertical back porch as (from linux-sunxi/drivers/video/sunxi/disp2/disp/de/disp_lcd.c) timmings->ver_sync_time= panel_info->lcd_vspw; timmings->ver_back_porch= panel_info->lcd_vbp-panel_info->lcd_vspw; vbp = panel->lcd_vbp; vspw = panel->lcd_vspw; dsi_dev[sel]->dsi_basic_size0.bits.vbp = vbp-vspw; dsi_dev[sel]->dsi_basic_size0.bits.vbp = panel->lcd_vbp - panel->lcd_vspw; => timmings->ver_back_porch + panel_info->lcd_vspw - panel_info->lcd_vspw => timmings->ver_back_porch => mode->vtotal - mode->end Which evatually same as mode->vtotal - mode->vsync_end so fix the VBP value in SUN6I_DSI_BASIC_SIZE0_VBP On the information note, existing SUN6I_DSI_BASIC_SIZE0_VSA is proper value. Signed-off-by: Jagan Teki --- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c index 318994cd1b85..d70a8c43a4b8 100644 --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c @@ -526,8 +526,8 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi, regmap_write(dsi->regs, SUN6I_DSI_BASIC_SIZE0_REG, SUN6I_DSI_BASIC_SIZE0_VSA(mode->vsync_end - mode->vsync_start) | - SUN6I_DSI_BASIC_SIZE0_VBP(mode->vsync_start - - mode->vdisplay)); + SUN6I_DSI_BASIC_SIZE0_VBP(mode->vtotal - + mode->vsync_end)); regmap_write(dsi->regs, SUN6I_DSI_BASIC_SIZE1_REG, SUN6I_DSI_BASIC_SIZE1_VACT(mode->vdisplay) | -- 2.18.0.321.gffc6fa0e3 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Subject: [PATCH v8 1/8] drm/sun4i: sun6i_mipi_dsi: Fix VBP size calculation Date: Fri, 15 Feb 2019 00:55:37 +0530 Message-ID: <20190214192544.7314-2-jagan@amarulasolutions.com> References: <20190214192544.7314-1-jagan@amarulasolutions.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4B6356EAA7 for ; Thu, 14 Feb 2019 19:26:09 +0000 (UTC) Received: by mail-pl1-x642.google.com with SMTP id k15so3652383pls.8 for ; Thu, 14 Feb 2019 11:26:09 -0800 (PST) In-Reply-To: <20190214192544.7314-1-jagan@amarulasolutions.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maxime Ripard , David Airlie , Daniel Vetter , Chen-Yu Tsai Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jagan Teki , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org VGhlIGhvcml6b250YWwgYW5kIHZlcnRpY2FsIGJhY2sgcG9yY2ggY2FsY3VsYXRpb24gaW4gQlNQ CmNvZGUgaXMgc2ltcGx5IGZvbGxvd2luZyB0aGUgTGludXggZHJtIGNvbW1lbnQgZGlhZ3JhbSwg aW4KaW5jbHVkZS9kcm0vZHJtX21vZGVzLmggd2hpY2ggaXMKCltodl1iYWNrIHBvcmNoID0gW2h2 XXRvdGFsIC0gW2h2XXN5bmNfZW5kCgpCU1AgY29kZSBmb3JtIEJQSS1NNjQtYnNwIGlzIGNhbGN1 bGF0aW5nIHZlcnRpY2FsIGJhY2sgcG9yY2ggYXMKKGZyb20gbGludXgtc3VueGkvZHJpdmVycy92 aWRlby9zdW54aS9kaXNwMi9kaXNwL2RlL2Rpc3BfbGNkLmMpCgp0aW1taW5ncy0+dmVyX3N5bmNf dGltZT0gcGFuZWxfaW5mby0+bGNkX3ZzcHc7CnRpbW1pbmdzLT52ZXJfYmFja19wb3JjaD0gcGFu ZWxfaW5mby0+bGNkX3ZicC1wYW5lbF9pbmZvLT5sY2RfdnNwdzsKCnZicCA9IHBhbmVsLT5sY2Rf dmJwOwp2c3B3ID0gcGFuZWwtPmxjZF92c3B3Owpkc2lfZGV2W3NlbF0tPmRzaV9iYXNpY19zaXpl MC5iaXRzLnZicCA9IHZicC12c3B3Owpkc2lfZGV2W3NlbF0tPmRzaV9iYXNpY19zaXplMC5iaXRz LnZicCA9IHBhbmVsLT5sY2RfdmJwIC0gcGFuZWwtPmxjZF92c3B3Owo9PiAgdGltbWluZ3MtPnZl cl9iYWNrX3BvcmNoICsgcGFuZWxfaW5mby0+bGNkX3ZzcHcgLSBwYW5lbF9pbmZvLT5sY2RfdnNw dwo9PiAgdGltbWluZ3MtPnZlcl9iYWNrX3BvcmNoCj0+ICBtb2RlLT52dG90YWwgLSBtb2RlLT5l bmQKCldoaWNoIGV2YXR1YWxseSBzYW1lIGFzIG1vZGUtPnZ0b3RhbCAtIG1vZGUtPnZzeW5jX2Vu ZCBzbyBmaXggdGhlIFZCUAp2YWx1ZSBpbiBTVU42SV9EU0lfQkFTSUNfU0laRTBfVkJQCgpPbiB0 aGUgaW5mb3JtYXRpb24gbm90ZSwgZXhpc3RpbmcgU1VONklfRFNJX0JBU0lDX1NJWkUwX1ZTQSBp cyBwcm9wZXIKdmFsdWUuCgpTaWduZWQtb2ZmLWJ5OiBKYWdhbiBUZWtpIDxqYWdhbkBhbWFydWxh c29sdXRpb25zLmNvbT4KLS0tCiBkcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuNmlfbWlwaV9kc2ku YyB8IDQgKystLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuNmlfbWlwaV9kc2kuYyBi L2RyaXZlcnMvZ3B1L2RybS9zdW40aS9zdW42aV9taXBpX2RzaS5jCmluZGV4IDMxODk5NGNkMWI4 NS4uZDcwYThjNDNhNGI4IDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuNmlf bWlwaV9kc2kuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuNmlfbWlwaV9kc2kuYwpA QCAtNTI2LDggKzUyNiw4IEBAIHN0YXRpYyB2b2lkIHN1bjZpX2RzaV9zZXR1cF90aW1pbmdzKHN0 cnVjdCBzdW42aV9kc2kgKmRzaSwKIAlyZWdtYXBfd3JpdGUoZHNpLT5yZWdzLCBTVU42SV9EU0lf QkFTSUNfU0laRTBfUkVHLAogCQkgICAgIFNVTjZJX0RTSV9CQVNJQ19TSVpFMF9WU0EobW9kZS0+ dnN5bmNfZW5kIC0KIAkJCQkJICAgICAgIG1vZGUtPnZzeW5jX3N0YXJ0KSB8Ci0JCSAgICAgU1VO NklfRFNJX0JBU0lDX1NJWkUwX1ZCUChtb2RlLT52c3luY19zdGFydCAtCi0JCQkJCSAgICAgICBt b2RlLT52ZGlzcGxheSkpOworCQkgICAgIFNVTjZJX0RTSV9CQVNJQ19TSVpFMF9WQlAobW9kZS0+ dnRvdGFsIC0KKwkJCQkJICAgICAgIG1vZGUtPnZzeW5jX2VuZCkpOwogCiAJcmVnbWFwX3dyaXRl KGRzaS0+cmVncywgU1VONklfRFNJX0JBU0lDX1NJWkUxX1JFRywKIAkJICAgICBTVU42SV9EU0lf QkFTSUNfU0laRTFfVkFDVChtb2RlLT52ZGlzcGxheSkgfAotLSAKMi4xOC4wLjMyMS5nZmZjNmZh MGUzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7225AC10F04 for ; Thu, 14 Feb 2019 19:26:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4203D222D9 for ; Thu, 14 Feb 2019 19:26:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="coa3lgKd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438344AbfBNT0L (ORCPT ); Thu, 14 Feb 2019 14:26:11 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:36885 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387576AbfBNT0J (ORCPT ); Thu, 14 Feb 2019 14:26:09 -0500 Received: by mail-pl1-f194.google.com with SMTP id b5so3666411plr.4 for ; Thu, 14 Feb 2019 11:26:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6RPyU9KlTHdOgkAmLOMKP2ZsiLo1+0ZzZXt5rKrY9KQ=; b=coa3lgKd3W2zLu2VziGXiWdi2qk5QxDTrpA2V0L/4d0k8Na1MyZ7VcBMJzkpIOQmTY bwC+BKOOMMfY/oYkT8xYMgTmOvOa7K2+U0iljl8Ngny+htseLtdLPWUMjdqAVh78LcbF /8qvTLIReYhLio93eNCAvCIo8MzRuYbQ4wSts= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6RPyU9KlTHdOgkAmLOMKP2ZsiLo1+0ZzZXt5rKrY9KQ=; b=ABiFAmvForff+XBf7TxPkgCBacsEsMyPfQ6W0ByWhAoNNWcPDN7/dCV8+0UHgtRPEq 4qVC14o5XPE2idB7STMsIA3KGmIYcGQkDRDMhLftbEQ38Jt6NdsbZfsNaOan9BUPUYXt 7PB0ZzBmT7AeZ0VaV8FQnE0gfQN9i9IqS+ZKUKPB66ie/+CZNk8xDVYRRbJbvAJemC6z mHrAKCJM+zC9sH6YwGSfBo5Bz6eJ+mahU1CgczbxYLY/iZABoObZ+ACKRAPaz1NL3LZ5 SWulY0SIEOIF8VOmA11SuiQkwO/lbq4/kVQPJxqn3oMTIPjnY25tQtGyVqjIUnvNZU4e 2gJA== X-Gm-Message-State: AHQUAuZVKk85Lkqx22yJCYRYtp5MYoWMKWMr5Fn3xljjjFZ4jpdWNqdG dfmpWuTeZ9WB3fjerEzC1SBoYQ== X-Google-Smtp-Source: AHgI3IaiBOPW+CBlLrKkP81yfT4FIZkOlPh6b4UXVprpinR0lR+vBgoOU825d/GhH4kDRSvMHMelvA== X-Received: by 2002:a17:902:b087:: with SMTP id p7mr3905888plr.56.1550172368856; Thu, 14 Feb 2019 11:26:08 -0800 (PST) Received: from localhost.localdomain ([115.97.184.151]) by smtp.gmail.com with ESMTPSA id k71sm8390100pga.44.2019.02.14.11.26.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Feb 2019 11:26:08 -0800 (PST) From: Jagan Teki To: Maxime Ripard , David Airlie , Daniel Vetter , Chen-Yu Tsai Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com, Michael Trimarchi , Jagan Teki Subject: [PATCH v8 1/8] drm/sun4i: sun6i_mipi_dsi: Fix VBP size calculation Date: Fri, 15 Feb 2019 00:55:37 +0530 Message-Id: <20190214192544.7314-2-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20190214192544.7314-1-jagan@amarulasolutions.com> References: <20190214192544.7314-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The horizontal and vertical back porch calculation in BSP code is simply following the Linux drm comment diagram, in include/drm/drm_modes.h which is [hv]back porch = [hv]total - [hv]sync_end BSP code form BPI-M64-bsp is calculating vertical back porch as (from linux-sunxi/drivers/video/sunxi/disp2/disp/de/disp_lcd.c) timmings->ver_sync_time= panel_info->lcd_vspw; timmings->ver_back_porch= panel_info->lcd_vbp-panel_info->lcd_vspw; vbp = panel->lcd_vbp; vspw = panel->lcd_vspw; dsi_dev[sel]->dsi_basic_size0.bits.vbp = vbp-vspw; dsi_dev[sel]->dsi_basic_size0.bits.vbp = panel->lcd_vbp - panel->lcd_vspw; => timmings->ver_back_porch + panel_info->lcd_vspw - panel_info->lcd_vspw => timmings->ver_back_porch => mode->vtotal - mode->end Which evatually same as mode->vtotal - mode->vsync_end so fix the VBP value in SUN6I_DSI_BASIC_SIZE0_VBP On the information note, existing SUN6I_DSI_BASIC_SIZE0_VSA is proper value. Signed-off-by: Jagan Teki --- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c index 318994cd1b85..d70a8c43a4b8 100644 --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c @@ -526,8 +526,8 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi, regmap_write(dsi->regs, SUN6I_DSI_BASIC_SIZE0_REG, SUN6I_DSI_BASIC_SIZE0_VSA(mode->vsync_end - mode->vsync_start) | - SUN6I_DSI_BASIC_SIZE0_VBP(mode->vsync_start - - mode->vdisplay)); + SUN6I_DSI_BASIC_SIZE0_VBP(mode->vtotal - + mode->vsync_end)); regmap_write(dsi->regs, SUN6I_DSI_BASIC_SIZE1_REG, SUN6I_DSI_BASIC_SIZE1_VACT(mode->vdisplay) | -- 2.18.0.321.gffc6fa0e3