From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D0E0C10F04 for ; Thu, 14 Feb 2019 19:26:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F0DC222D7 for ; Thu, 14 Feb 2019 19:26:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="W36aaO2f"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="l45VmOgA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F0DC222D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b5WQsi6xm/N4gqZhRMznU7AdLqLEo0yu3j4o5n3bUuM=; b=W36aaO2fyZNOgA HyTNLXoDaZHyjrttUvvUkqHFtW1kWiSQppodMn25UpRaag6EZvUI32PTnH4kHyNMKeUJPtCyCHKjr RLDMOoiI1o0AieozMqnhrZ47dvWYG6A9tCN+om5bMz+1nIA1wPj77ovMUJU9Cbxv8KuA9HAeU+GXb vpsnfvBcx5xMLjlrW2IfddtVJ27YDtQLg6U9Xd+qMpDMaWo1roaD0QjXajZcwUsuWT55bPb48vl1v v1PymwrcJUXHn/sa4Ge8M4KhISLsrz79iv5fv+G5pVXN/Gsk1Rn+6/KFkcqdIYQHnn6ttcAba/aPJ 06r8OU3o6F4/KwECG0aA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1guMes-00029P-BD; Thu, 14 Feb 2019 19:26:54 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1guMeJ-0001NZ-Uc for linux-arm-kernel@lists.infradead.org; Thu, 14 Feb 2019 19:26:21 +0000 Received: by mail-pf1-x443.google.com with SMTP id b7so3578547pfi.8 for ; Thu, 14 Feb 2019 11:26:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8bEG0NxK/TkiBajUPiod9cKRuA/aBM9IwOWB4PGFOrI=; b=l45VmOgAS7gmdmqj0kwq0CNxr3FjdmxmX5VCKjF0O1zGcSdzvmPJ4KZtP3D8MQKS5Q Bju+FpfWNcC9MkgAMtOQzfu+0SwUtNwa/522Egshy9HFToZIwme2xASYf4GWBNvLetdW rgRtQ29xehVznd7besQEhuVZQF0zo06VBDY2k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8bEG0NxK/TkiBajUPiod9cKRuA/aBM9IwOWB4PGFOrI=; b=ROPJSuaucFJ13jPeZzmi1g2PF5lzIUuuNlRXizWzruLezoLDBEyI+mRr6HMwClJcZW Qo1KDFDxqNgD99AJA++zWgUrUM+1Fp+CrL9FHiJ84NGO7+cQQKswoVrRwokI+KJB79wb 8+0Yll4kifClULUqkbCKC2IHER5qNAbagX9vEwv9ebHpU8B896WoNmAb8xbE69CQwbDe Fml+twFJZqvFUxGrUAMnvZtMEn2/WO9rYBFHwsn+Z3U64BSoviZxTdoPXlRfiJ+6Isc1 QBRB6uJQaCula/1axz4uSJol05pdvn/zKuNUgtYXvnXjbc5dLFL1g4cUgK9lLcgzMgUq mulw== X-Gm-Message-State: AHQUAub3GhrJDG2iXzAHQwjtJkRU1ermPH6TzwWFWNiAT91S3nZ6VyHT vLAUagcFF/EDDLy7/GL12HJdYA== X-Google-Smtp-Source: AHgI3Ia0CDs3p5oMKUDDJam7CZ/l0xCiETZ3cSv8nrroWNdU6m6h7kQy+w24xsl0DYun6uSOM0FAIA== X-Received: by 2002:a62:442:: with SMTP id 63mr5632258pfe.156.1550172379131; Thu, 14 Feb 2019 11:26:19 -0800 (PST) Received: from localhost.localdomain ([115.97.184.151]) by smtp.gmail.com with ESMTPSA id k71sm8390100pga.44.2019.02.14.11.26.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Feb 2019 11:26:18 -0800 (PST) From: Jagan Teki To: Maxime Ripard , David Airlie , Daniel Vetter , Chen-Yu Tsai Subject: [PATCH v8 4/8] drm/sun4i: sun6i_mipi_dsi: Fix DSI hblk timing calculation Date: Fri, 15 Feb 2019 00:55:40 +0530 Message-Id: <20190214192544.7314-5-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20190214192544.7314-1-jagan@amarulasolutions.com> References: <20190214192544.7314-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190214_112620_010246_A6ECAB6F X-CRM114-Status: GOOD ( 15.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jagan Teki , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org horizontal blank is computed by adding all porch timing values, or htotal total timing value without sync time. Based on "DRM kernel-internal display mode structure" from include/drm/drm_modes.h hblk = htotal - (hsync value); hblk = htotal - (hsync_end - hsync_start); Current driver is subtracting htotal with hsa, but the hsa is bounded with packet overhead. So subtract htotal with hsync value(hsync_end - hsync_start) proper hblk computation. BPI-M64-bsp is computing hbp as (from linux-sunxi/ drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c) dsi_hblk = (ht-hspw)*dsi_pixel_bits[format]/8-(4+4+2); => (timmings->hor_total_time - timmings->hor_sync_time) => (mode->htotal - (mode->hsync_end - mode->hsync_start)) So, update the hblk value accordingly in sun6i_dsi_setup_timings. Tested on 2-lane, 4-lane MIPI-DSI LCD panels. Signed-off-by: Jagan Teki --- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c index 21f39f11a8de..6b26dba883e8 100644 --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c @@ -486,7 +486,7 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi, /* * hblk seems to be the line + porches length. */ - hblk = mode->htotal * Bpp - hsa; + hblk = (mode->htotal - (mode->hsync_end - mode->hsync_start)) * Bpp; /* * And I'm not entirely sure what vblk is about. The driver in -- 2.18.0.321.gffc6fa0e3 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Subject: [PATCH v8 4/8] drm/sun4i: sun6i_mipi_dsi: Fix DSI hblk timing calculation Date: Fri, 15 Feb 2019 00:55:40 +0530 Message-ID: <20190214192544.7314-5-jagan@amarulasolutions.com> References: <20190214192544.7314-1-jagan@amarulasolutions.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id D922A6EAAB for ; Thu, 14 Feb 2019 19:26:19 +0000 (UTC) Received: by mail-pf1-x444.google.com with SMTP id n74so3576136pfi.9 for ; Thu, 14 Feb 2019 11:26:19 -0800 (PST) In-Reply-To: <20190214192544.7314-1-jagan@amarulasolutions.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maxime Ripard , David Airlie , Daniel Vetter , Chen-Yu Tsai Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jagan Teki , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org aG9yaXpvbnRhbCBibGFuayBpcyBjb21wdXRlZCBieSBhZGRpbmcgYWxsIHBvcmNoIHRpbWluZyB2 YWx1ZXMsCm9yIGh0b3RhbCB0b3RhbCB0aW1pbmcgdmFsdWUgd2l0aG91dCBzeW5jIHRpbWUuCgpC YXNlZCBvbiAiRFJNIGtlcm5lbC1pbnRlcm5hbCBkaXNwbGF5IG1vZGUgc3RydWN0dXJlIiBmcm9t CmluY2x1ZGUvZHJtL2RybV9tb2Rlcy5oCgpoYmxrID0gaHRvdGFsIC0gKGhzeW5jIHZhbHVlKTsK aGJsayA9IGh0b3RhbCAtIChoc3luY19lbmQgLSBoc3luY19zdGFydCk7CgpDdXJyZW50IGRyaXZl ciBpcyBzdWJ0cmFjdGluZyBodG90YWwgd2l0aCBoc2EsIGJ1dCB0aGUgaHNhIGlzCmJvdW5kZWQg d2l0aCBwYWNrZXQgb3ZlcmhlYWQuIFNvIHN1YnRyYWN0IGh0b3RhbCB3aXRoIGhzeW5jCnZhbHVl KGhzeW5jX2VuZCAtIGhzeW5jX3N0YXJ0KSBwcm9wZXIgaGJsayBjb21wdXRhdGlvbi4KCkJQSS1N NjQtYnNwIGlzIGNvbXB1dGluZyBoYnAgYXMgKGZyb20gbGludXgtc3VueGkvCmRyaXZlcnMvdmlk ZW8vc3VueGkvZGlzcDIvZGlzcC9kZS9sb3dsZXZlbF9zdW41MGl3MS9kZV9kc2kuYykKCmRzaV9o YmxrID0gKGh0LWhzcHcpKmRzaV9waXhlbF9iaXRzW2Zvcm1hdF0vOC0oNCs0KzIpOwo9PiAodGlt bWluZ3MtPmhvcl90b3RhbF90aW1lIC0gdGltbWluZ3MtPmhvcl9zeW5jX3RpbWUpCj0+IChtb2Rl LT5odG90YWwgLSAobW9kZS0+aHN5bmNfZW5kIC0gbW9kZS0+aHN5bmNfc3RhcnQpKQoKU28sIHVw ZGF0ZSB0aGUgaGJsayB2YWx1ZSBhY2NvcmRpbmdseSBpbiBzdW42aV9kc2lfc2V0dXBfdGltaW5n cy4KClRlc3RlZCBvbiAyLWxhbmUsIDQtbGFuZSBNSVBJLURTSSBMQ0QgcGFuZWxzLgoKU2lnbmVk LW9mZi1ieTogSmFnYW4gVGVraSA8amFnYW5AYW1hcnVsYXNvbHV0aW9ucy5jb20+Ci0tLQogZHJp dmVycy9ncHUvZHJtL3N1bjRpL3N1bjZpX21pcGlfZHNpLmMgfCAyICstCiAxIGZpbGUgY2hhbmdl ZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vc3VuNGkvc3VuNmlfbWlwaV9kc2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9zdW40aS9zdW42 aV9taXBpX2RzaS5jCmluZGV4IDIxZjM5ZjExYThkZS4uNmIyNmRiYTg4M2U4IDEwMDY0NAotLS0g YS9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuNmlfbWlwaV9kc2kuYworKysgYi9kcml2ZXJzL2dw dS9kcm0vc3VuNGkvc3VuNmlfbWlwaV9kc2kuYwpAQCAtNDg2LDcgKzQ4Niw3IEBAIHN0YXRpYyB2 b2lkIHN1bjZpX2RzaV9zZXR1cF90aW1pbmdzKHN0cnVjdCBzdW42aV9kc2kgKmRzaSwKIAkvKgog CSAqIGhibGsgc2VlbXMgdG8gYmUgdGhlIGxpbmUgKyBwb3JjaGVzIGxlbmd0aC4KIAkgKi8KLQlo YmxrID0gbW9kZS0+aHRvdGFsICogQnBwIC0gaHNhOworCWhibGsgPSAobW9kZS0+aHRvdGFsIC0g KG1vZGUtPmhzeW5jX2VuZCAtIG1vZGUtPmhzeW5jX3N0YXJ0KSkgKiBCcHA7CiAKIAkvKgogCSAq IEFuZCBJJ20gbm90IGVudGlyZWx5IHN1cmUgd2hhdCB2YmxrIGlzIGFib3V0LiBUaGUgZHJpdmVy IGluCi0tIAoyLjE4LjAuMzIxLmdmZmM2ZmEwZTMKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F80CC10F04 for ; Thu, 14 Feb 2019 19:26:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C77421B68 for ; Thu, 14 Feb 2019 19:26:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="l45VmOgA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439718AbfBNT0Y (ORCPT ); Thu, 14 Feb 2019 14:26:24 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:37499 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438440AbfBNT0U (ORCPT ); Thu, 14 Feb 2019 14:26:20 -0500 Received: by mail-pf1-f194.google.com with SMTP id s22so3588316pfh.4 for ; Thu, 14 Feb 2019 11:26:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8bEG0NxK/TkiBajUPiod9cKRuA/aBM9IwOWB4PGFOrI=; b=l45VmOgAS7gmdmqj0kwq0CNxr3FjdmxmX5VCKjF0O1zGcSdzvmPJ4KZtP3D8MQKS5Q Bju+FpfWNcC9MkgAMtOQzfu+0SwUtNwa/522Egshy9HFToZIwme2xASYf4GWBNvLetdW rgRtQ29xehVznd7besQEhuVZQF0zo06VBDY2k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8bEG0NxK/TkiBajUPiod9cKRuA/aBM9IwOWB4PGFOrI=; b=LBo4f6T8zQ+HeX4cBUi9NIBqznc936v1WA7DCnqdK/+8WyLw4W4pWXGm3B84gHY1xX /Cjcz1tyEJRxj/mDD4oK0+nQpBnSEhSmR7zyKdY+DfUbp8OJCl80duKRTqzjWbkjvSR3 dCLQgNQbeIqxja2ny7b+yoQpTjNwv8kuVM9zwdxD4T60wpSgPcWxqHmNixoe3gzJyjdF qciBZgh52UyUuRhstf7OxmMexoxyVDAwU5rn2+/diDwrJcLOGrzGrxYw857HurD9P9OY ZlzDAb9OKhBDrCl1WJvy7qe4vYunibsxKJXJZhKl0J6hdj9w3BlgE/zQigGH/HSW7aky 1hRw== X-Gm-Message-State: AHQUAuZRgZrnvYlhgLMSXv1hlK4OsOSha7zD3SGC23Q7cVZwSfXKbhCs CI0mm7PRM72Bx4pvgqd719rGXg== X-Google-Smtp-Source: AHgI3Ia0CDs3p5oMKUDDJam7CZ/l0xCiETZ3cSv8nrroWNdU6m6h7kQy+w24xsl0DYun6uSOM0FAIA== X-Received: by 2002:a62:442:: with SMTP id 63mr5632258pfe.156.1550172379131; Thu, 14 Feb 2019 11:26:19 -0800 (PST) Received: from localhost.localdomain ([115.97.184.151]) by smtp.gmail.com with ESMTPSA id k71sm8390100pga.44.2019.02.14.11.26.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Feb 2019 11:26:18 -0800 (PST) From: Jagan Teki To: Maxime Ripard , David Airlie , Daniel Vetter , Chen-Yu Tsai Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com, Michael Trimarchi , Jagan Teki Subject: [PATCH v8 4/8] drm/sun4i: sun6i_mipi_dsi: Fix DSI hblk timing calculation Date: Fri, 15 Feb 2019 00:55:40 +0530 Message-Id: <20190214192544.7314-5-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20190214192544.7314-1-jagan@amarulasolutions.com> References: <20190214192544.7314-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org horizontal blank is computed by adding all porch timing values, or htotal total timing value without sync time. Based on "DRM kernel-internal display mode structure" from include/drm/drm_modes.h hblk = htotal - (hsync value); hblk = htotal - (hsync_end - hsync_start); Current driver is subtracting htotal with hsa, but the hsa is bounded with packet overhead. So subtract htotal with hsync value(hsync_end - hsync_start) proper hblk computation. BPI-M64-bsp is computing hbp as (from linux-sunxi/ drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c) dsi_hblk = (ht-hspw)*dsi_pixel_bits[format]/8-(4+4+2); => (timmings->hor_total_time - timmings->hor_sync_time) => (mode->htotal - (mode->hsync_end - mode->hsync_start)) So, update the hblk value accordingly in sun6i_dsi_setup_timings. Tested on 2-lane, 4-lane MIPI-DSI LCD panels. Signed-off-by: Jagan Teki --- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c index 21f39f11a8de..6b26dba883e8 100644 --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c @@ -486,7 +486,7 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi, /* * hblk seems to be the line + porches length. */ - hblk = mode->htotal * Bpp - hsa; + hblk = (mode->htotal - (mode->hsync_end - mode->hsync_start)) * Bpp; /* * And I'm not entirely sure what vblk is about. The driver in -- 2.18.0.321.gffc6fa0e3