From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 3/4] drm/i915: Remove the broken DP CRC
 support for g4x
Date: Thu, 14 Feb 2019 12:38:22 -0800
Message-ID: <20190214203822.GL31265@intel.com>
References: <20190214192219.3858-1-ville.syrjala@linux.intel.com>
 <20190214192219.3858-3-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 17F8B6E05A
 for <intel-gfx@lists.freedesktop.org>; Thu, 14 Feb 2019 20:38:22 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190214192219.3858-3-ville.syrjala@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBGZWIgMTQsIDIwMTkgYXQgMDk6MjI6MThQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3
cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu
Y29tPgo+IAo+IERQIENSQ3MgZG9uJ3QgcmVhbGx5IHdvcmsgb24gZzR4LiBJZiB5b3Ugd2FudCBh
bnkgQ1JDcyBvbiBEUCB5b3UgbXVzdAo+IHNlbGVjdCB0aGUgQ1JDIHNvdXJjZSBiZWZvcmUgdGhl
IHBvcnQgaXMgZW5hYmxlZCwgb3RoZXJ3aXNlIHRoZSBDUkMKPiBzb3VyY2Ugc2VsZWN0IGJpdHMg
c2ltcGx5IGlnbm9yZSBhbnkgd3JpdGVzIHRvIHRoZW0uIEFuZCBvbmNlIHRoZSBwb3J0Cj4gaXMg
ZW5hYmxlZCB3ZSBtdXN0bid0IGNoYW5nZSB0aGUgQ1JDIHNvdXJjZSBzZWxlY3QgdW50aWwgdGhl
IHBvcnQgaXMKPiBkaXNhYmxlZC4gVGhhdCBhbG1vc3Qgd29ya3MsIGJ1dCBub3QgcXVpdGUgOigg
RXZlbnR1YWxseSB0aGUgQ1JDIHNvdXJjZQo+IHNlbGVjdCBiaXRzIGdldCBwZXJtYW5lbnRseSBz
dHVjayBvbmUgd2F5IG9yIHRoZSBvdGhlciwgYW5kIGFmdGVyIHRoYXQKPiBhIHJlYm9vdCAob3Ig
cG9zc2libHkgYSBkaXNwbGF5IHJlc2V0KSBpcyBuZWVkZWQgdG8gZ2V0IHdvcmtpbmcgQ1JDcwo+
IG9uIHRoYXQgcGlwZSAobm90IG1hdHRlciB3aGljaCBDUkMgc291cmNlIHdlIHRyeSB0byB1c2Up
Lgo+IAo+IEFkZGl0aW9uYWxseSB0aGUgREZUIHNjcmFtYmxlciByZXNldCBiaXRzIHdlJ3JlIHRy
eWluZyB0byB1c2UgZG9uJ3QKPiBzZWVtIHRvIGV4aXN0IG9uIGc0eC4gVGhlcmUgYXJlIHNvbWUg
cG90ZW50aWFsbHkgcmVsZXZhbnQgbG9va2luZyBiaXRzCj4gaW4gdGhlIHBpcGUgcmVnaXN0ZXJz
LCBidXQgd2hlbiBJIHRyaWVkIGl0IEkgZ290IHN0YWJsZSBsb29raW5nIENSQ3MKPiB3aXRob3V0
IHNldHRpbmcgYW55IGJpdHMgZm9yIHRoaXMuCj4gCj4gSWYgdGhlcmUgaXMgYSB3YXkgdG8gbWFr
ZSBEUCBDUkNzIHdvcmsgcmVsaWFibHkgb24gZzR4LCBJIHdhc24ndAo+IGFibGUgdG8gZmluZCBp
dC4gU28gbGV0J3MganVzdCByZW1vdmUgdGhlIGJyb2tlbiBjb2RlIHdlIGhhdmUuCj4gCj4gU2ln
bmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNv
bT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGlwZV9jcmMuYyB8IDgwICsr
KystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTEgaW5zZXJ0aW9u
cygrKSwgNjkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX3BpcGVfY3JjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9waXBlX2Ny
Yy5jCj4gaW5kZXggZmUwZmY4OWI5ODBiLi42NmJiN2IwMzE1MzcgMTAwNjQ0Cj4gLS0tIGEvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGlwZV9jcmMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX3BpcGVfY3JjLmMKPiBAQCAtMTkxLDggKzE5MSw2IEBAIHN0YXRpYyBpbnQg
aTl4eF9waXBlX2NyY19jdGxfcmVnKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwK
PiAgCQkJCSBlbnVtIGludGVsX3BpcGVfY3JjX3NvdXJjZSAqc291cmNlLAo+ICAJCQkJIHUzMiAq
dmFsKQo+ICB7Cj4gLQlib29sIG5lZWRfc3RhYmxlX3N5bWJvbHMgPSBmYWxzZTsKPiAtCj4gIAlp
ZiAoKnNvdXJjZSA9PSBJTlRFTF9QSVBFX0NSQ19TT1VSQ0VfQVVUTykgewo+ICAJCWludCByZXQg
PSBpOXh4X3BpcGVfY3JjX2F1dG9fc291cmNlKGRldl9wcml2LCBwaXBlLCBzb3VyY2UpOwo+ICAJ
CWlmIChyZXQpCj4gQEAgLTIwOCw1NiArMjA2LDIzIEBAIHN0YXRpYyBpbnQgaTl4eF9waXBlX2Ny
Y19jdGxfcmVnKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkJcmV0dXJu
IC1FSU5WQUw7Cj4gIAkJKnZhbCA9IFBJUEVfQ1JDX0VOQUJMRSB8IFBJUEVfQ1JDX1NPVVJDRV9U
Vl9QUkU7Cj4gIAkJYnJlYWs7Cj4gLQljYXNlIElOVEVMX1BJUEVfQ1JDX1NPVVJDRV9EUF9COgo+
IC0JCWlmICghSVNfRzRYKGRldl9wcml2KSkKPiAtCQkJcmV0dXJuIC1FSU5WQUw7Cj4gLQkJKnZh
bCA9IFBJUEVfQ1JDX0VOQUJMRSB8IFBJUEVfQ1JDX1NPVVJDRV9EUF9CX0c0WDsKPiAtCQluZWVk
X3N0YWJsZV9zeW1ib2xzID0gdHJ1ZTsKPiAtCQlicmVhazsKPiAtCWNhc2UgSU5URUxfUElQRV9D
UkNfU09VUkNFX0RQX0M6Cj4gLQkJaWYgKCFJU19HNFgoZGV2X3ByaXYpKQo+IC0JCQlyZXR1cm4g
LUVJTlZBTDsKPiAtCQkqdmFsID0gUElQRV9DUkNfRU5BQkxFIHwgUElQRV9DUkNfU09VUkNFX0RQ
X0NfRzRYOwo+IC0JCW5lZWRfc3RhYmxlX3N5bWJvbHMgPSB0cnVlOwo+IC0JCWJyZWFrOwo+IC0J
Y2FzZSBJTlRFTF9QSVBFX0NSQ19TT1VSQ0VfRFBfRDoKPiAtCQlpZiAoIUlTX0c0WChkZXZfcHJp
dikpCj4gLQkJCXJldHVybiAtRUlOVkFMOwo+IC0JCSp2YWwgPSBQSVBFX0NSQ19FTkFCTEUgfCBQ
SVBFX0NSQ19TT1VSQ0VfRFBfRF9HNFg7Cj4gLQkJbmVlZF9zdGFibGVfc3ltYm9scyA9IHRydWU7
Cj4gLQkJYnJlYWs7Cj4gIAljYXNlIElOVEVMX1BJUEVfQ1JDX1NPVVJDRV9OT05FOgo+ICAJCSp2
YWwgPSAwOwo+ICAJCWJyZWFrOwo+ICAJZGVmYXVsdDoKPiArCQkvKgo+ICsJCSAqIFRoZSBEUCBD
UkMgc291cmNlIGRvZXNuJ3Qgd29yayBvbiBnNHguCj4gKwkJICogSXQgY2FuIGJlIG1hZGUgdG8g
d29yayB0byBzb21lIGRlZ3JlZSBieSBzZWxlY3RpbmcKPiArCQkgKiB0aGUgY29ycmVjdCBDUkMg
c291cmNlIGJlZm9yZSB0aGUgcG9ydCBpcyBlbmFibGVkLAo+ICsJCSAqIGFuZCBub3QgdG91Y2hp
bmcgdGhlIENSQyBzb3VyY2UgYml0cyBhZ2FpbiB1bnRpbAo+ICsJCSAqIHRoZSBwb3J0IGlzIGRp
c2FibGVkLiBCdXQgZXZlbiB0aGVuIHRoZSBiaXRzCj4gKwkJICogZXZlbnR1YWxseSBnZXQgc3R1
Y2sgYW5kIGEgcmVib290IGlzIG5lZWRlZCB0byBnZXQKPiArCQkgKiB3b3JraW5nIENSQ3Mgb24g
dGhlIHBpcGUgYWdhaW4uIExldCdzIHNpbXBseQo+ICsJCSAqIHJlZnVzZSB0byB1c2UgRFAgQ1JD
cyBvbiBnNHguCj4gKwkJICovCj4gIAkJcmV0dXJuIC1FSU5WQUw7CgppcyB0aGlzIHRoZSByaWdo
dCByZXR1cm4gbm93PyBtYXliZSBFTk9FTlQ/CihqdXN0IGJyYWluc3Rvcm1pbmcgd2l0aG91dCBs
b29raW5nIHRvIGlndCB0ZXN0cykKCkJ1dCBJIGtub3cgaG93IHRlcnJpYmxlIHVucmVsaWFibGUg
Y3JjcyBhcmUgYW5kIHRoaXMgcGF0Y2gKbG9va3MgdGhlIHJpZ2h0IHdheSwgc286CgpSZXZpZXdl
ZC1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgoKCgo+ICAJfQo+ICAK
PiAtCS8qCj4gLQkgKiBXaGVuIHRoZSBwaXBlIENSQyB0YXAgcG9pbnQgaXMgYWZ0ZXIgdGhlIHRy
YW5zY29kZXJzIHdlIG5lZWQKPiAtCSAqIHRvIHR3ZWFrIHN5bWJvbC1sZXZlbCBmZWF0dXJlcyB0
byBwcm9kdWNlIGEgZGV0ZXJtaW5pc3RpYyBzZXJpZXMgb2YKPiAtCSAqIHN5bWJvbHMgZm9yIGEg
Z2l2ZW4gZnJhbWUuIFdlIG5lZWQgdG8gcmVzZXQgdGhvc2UgZmVhdHVyZXMgb25seSBvbmNlCj4g
LQkgKiBhIGZyYW1lIChpbnN0ZWFkIG9mIGV2ZXJ5IG50aCBzeW1ib2wpOgo+IC0JICogICAtIERD
LWJhbGFuY2U6IHVzZWQgdG8gZW5zdXJlIGEgYmV0dGVyIGNsb2NrIHJlY292ZXJ5IGZyb20gdGhl
IGRhdGEKPiAtCSAqICAgICBsaW5rIChTRFZPKQo+IC0JICogICAtIERpc3BsYXlQb3J0IHNjcmFt
Ymxpbmc6IHVzZWQgZm9yIEVNSSByZWR1Y3Rpb24KPiAtCSAqLwo+IC0JaWYgKG5lZWRfc3RhYmxl
X3N5bWJvbHMpIHsKPiAtCQl1MzIgdG1wID0gSTkxNV9SRUFEKFBPUlRfREZUMl9HNFgpOwo+IC0K
PiAtCQlXQVJOX09OKCFJU19HNFgoZGV2X3ByaXYpKTsKPiAtCj4gLQkJSTkxNV9XUklURShQT1JU
X0RGVF9JOVhYLAo+IC0JCQkgICBJOTE1X1JFQUQoUE9SVF9ERlRfSTlYWCkgfCBEQ19CQUxBTkNF
X1JFU0VUKTsKPiAtCj4gLQkJaWYgKHBpcGUgPT0gUElQRV9BKQo+IC0JCQl0bXAgfD0gUElQRV9B
X1NDUkFNQkxFX1JFU0VUOwo+IC0JCWVsc2UKPiAtCQkJdG1wIHw9IFBJUEVfQl9TQ1JBTUJMRV9S
RVNFVDsKPiAtCj4gLQkJSTkxNV9XUklURShQT1JUX0RGVDJfRzRYLCB0bXApOwo+IC0JfQo+IC0K
PiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+IEBAIC0yODIsMjQgKzI0Nyw2IEBAIHN0YXRpYyB2b2lk
IHZsdl91bmRvX3BpcGVfc2NyYW1ibGVfcmVzZXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl
dl9wcml2LAo+ICAJaWYgKCEodG1wICYgUElQRV9TQ1JBTUJMRV9SRVNFVF9NQVNLKSkKPiAgCQl0
bXAgJj0gfkRDX0JBTEFOQ0VfUkVTRVRfVkxWOwo+ICAJSTkxNV9XUklURShQT1JUX0RGVDJfRzRY
LCB0bXApOwo+IC0KPiAtfQo+IC0KPiAtc3RhdGljIHZvaWQgZzR4X3VuZG9fcGlwZV9zY3JhbWJs
ZV9yZXNldChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gLQkJCQkJIGVudW0g
cGlwZSBwaXBlKQo+IC17Cj4gLQl1MzIgdG1wID0gSTkxNV9SRUFEKFBPUlRfREZUMl9HNFgpOwo+
IC0KPiAtCWlmIChwaXBlID09IFBJUEVfQSkKPiAtCQl0bXAgJj0gflBJUEVfQV9TQ1JBTUJMRV9S
RVNFVDsKPiAtCWVsc2UKPiAtCQl0bXAgJj0gflBJUEVfQl9TQ1JBTUJMRV9SRVNFVDsKPiAtCUk5
MTVfV1JJVEUoUE9SVF9ERlQyX0c0WCwgdG1wKTsKPiAtCj4gLQlpZiAoISh0bXAgJiBQSVBFX1ND
UkFNQkxFX1JFU0VUX01BU0spKSB7Cj4gLQkJSTkxNV9XUklURShQT1JUX0RGVF9JOVhYLAo+IC0J
CQkgICBJOTE1X1JFQUQoUE9SVF9ERlRfSTlYWCkgJiB+RENfQkFMQU5DRV9SRVNFVCk7Cj4gLQl9
Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbnQgaWxrX3BpcGVfY3JjX2N0bF9yZWcoZW51bSBpbnRlbF9w
aXBlX2NyY19zb3VyY2UgKnNvdXJjZSwKPiBAQCAtNDg1LDkgKzQzMiw2IEBAIHN0YXRpYyBpbnQg
aTl4eF9jcmNfc291cmNlX3ZhbGlkKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwK
PiAgCXN3aXRjaCAoc291cmNlKSB7Cj4gIAljYXNlIElOVEVMX1BJUEVfQ1JDX1NPVVJDRV9QSVBF
Ogo+ICAJY2FzZSBJTlRFTF9QSVBFX0NSQ19TT1VSQ0VfVFY6Cj4gLQljYXNlIElOVEVMX1BJUEVf
Q1JDX1NPVVJDRV9EUF9COgo+IC0JY2FzZSBJTlRFTF9QSVBFX0NSQ19TT1VSQ0VfRFBfQzoKPiAt
CWNhc2UgSU5URUxfUElQRV9DUkNfU09VUkNFX0RQX0Q6Cj4gIAljYXNlIElOVEVMX1BJUEVfQ1JD
X1NPVVJDRV9OT05FOgo+ICAJCXJldHVybiAwOwo+ICAJZGVmYXVsdDoKPiBAQCAtNjEyLDkgKzU1
Niw3IEBAIGludCBpbnRlbF9jcnRjX3NldF9jcmNfc291cmNlKHN0cnVjdCBkcm1fY3J0YyAqY3J0
YywgY29uc3QgY2hhciAqc291cmNlX25hbWUpCj4gIAlQT1NUSU5HX1JFQUQoUElQRV9DUkNfQ1RM
KGNydGMtPmluZGV4KSk7Cj4gIAo+ICAJaWYgKCFzb3VyY2UpIHsKPiAtCQlpZiAoSVNfRzRYKGRl
dl9wcml2KSkKPiAtCQkJZzR4X3VuZG9fcGlwZV9zY3JhbWJsZV9yZXNldChkZXZfcHJpdiwgY3J0
Yy0+aW5kZXgpOwo+IC0JCWVsc2UgaWYgKElTX1ZBTExFWVZJRVcoZGV2X3ByaXYpIHx8IElTX0NI
RVJSWVZJRVcoZGV2X3ByaXYpKQo+ICsJCWlmIChJU19WQUxMRVlWSUVXKGRldl9wcml2KSB8fCBJ
U19DSEVSUllWSUVXKGRldl9wcml2KSkKPiAgCQkJdmx2X3VuZG9fcGlwZV9zY3JhbWJsZV9yZXNl
dChkZXZfcHJpdiwgY3J0Yy0+aW5kZXgpOwo+ICAJCWVsc2UgaWYgKChJU19IQVNXRUxMKGRldl9w
cml2KSB8fAo+ICAJCQkgIElTX0JST0FEV0VMTChkZXZfcHJpdikpICYmIGNydGMtPmluZGV4ID09
IFBJUEVfQSkKPiAtLSAKPiAyLjE5LjIKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhA
bGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp
bG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl
ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu
Zm8vaW50ZWwtZ2Z4