From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>, <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: don't update s_rev_level if not required
Date: Thu, 14 Feb 2019 21:10:29 -0500 [thread overview]
Message-ID: <20190215021029.GF7387@mit.edu> (raw)
In-Reply-To: <1547339800-50257-1-git-send-email-adilger@dilger.ca>
On Sat, Jan 12, 2019 at 05:36:40PM -0700, Andreas Dilger wrote:
> Don't update the superblock s_rev_level during mount if it isn't
> actually necessary, only if superblock features are being set by
> the kernel. This was originally added for ext3 since it always
> set the INCOMPAT_RECOVER and HAS_JOURNAL features during mount,
> but this is not needed since no journal mode was added to ext4.
>
> That will allow Geert to mount his 20-year-old ext2 rev 0.0 m68k
> filesystem, as a testament of the backward compatibility of ext4.
>
> Fixes: 0390131ba84f ("ext4: Allow ext4 to run without a journal")
> Signed-off-by: Andreas Dilger <adilger@dilger.ca>
Thanks, applied. I had to move the declaration of
ext4_update_dynamic_rev() earlier as Geert suggested.
- Ted
prev parent reply other threads:[~2019-02-15 2:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-12 9:43 Preserving a rev 0.0 ext2 filesystem Geert Uytterhoeven
2019-01-13 0:20 ` Andreas Dilger
2019-01-14 10:23 ` Geert Uytterhoeven
2019-01-14 12:50 ` Jan Kara
2019-01-13 0:36 ` [PATCH] ext4: don't update s_rev_level if not required Andreas Dilger
2019-01-14 10:25 ` Geert Uytterhoeven
2019-02-15 2:10 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215021029.GF7387@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=geert@linux-m68k.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.