Re: [Qemu-devel] [PATCH for-3.2 v3 1/3] block/snapshot.c: eliminate use of ID input in snapshot operations

[Kevin Wolf <kwolf@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

Am 15.02.2019 um 17:21 hat Eric Blake geschrieben:
> On 11/7/18 7:09 AM, Daniel Henrique Barboza wrote:
> > At this moment, QEMU attempts to create/load/delete snapshots
> > by using either an ID (id_str) or a name. The problem is that the code
> > isn't consistent of whether the entered argument is an ID or a name,
> > causing unexpected behaviors.
> > 
> 
> >  STEXI
> > -@item savevm [@var{tag}|@var{id}]
> > +@item savevm @var{tag}
> >  @findex savevm
> >  Create a snapshot of the whole virtual machine. If @var{tag} is
> >  provided, it is used as human readable identifier. If there is already
> > -a snapshot with the same tag or ID, it is replaced. More info at
> > +a snapshot with the same tag, it is replaced. More info at
> >  @ref{vm_snapshots}.
> > +
> > +Since 3.2, savevm stopped allowing the snapshot id to be set, accepting
> 
> s/3.2/4.0/
> 
> > +only @var{tag} as parameter.
> 
> > +Since 3.2, delvm stopped deleting snapshots by snapshot id, accepting
> > +only @var{tag} as parameter.
> 
> and again

Sorry, I should have mentioned that I changed this while applying.

Kevin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]