From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2994C43381 for ; Fri, 15 Feb 2019 17:02:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A20EE222BE for ; Fri, 15 Feb 2019 17:02:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CBH6Tnz2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="VQixXjME" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A20EE222BE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L5jlU4157E57co1HYGXJVB6POtQQkWG8HYmVbYuXxys=; b=CBH6Tnz2QOPvF4 m2e52rdubE2p3d+RCaGWuCcXFPzzRW1JhsbvtQDDt55b/nlcgYsPuoU6wMbMQRXTxsA7DZlF8ux2w 110Px9TZeNJhyLpeevk2hueVxShja/OWMPhbnNDSSAYhjW+s/KB4gWXGC6O64KpKdGkAUFlVjwJNh qRza47tqvqsGCZ4Ht10i8aE4JYZIKHan+S0SngLIIUnHM/BLRDV7sQ8L3ZVxKKmUvhbbURqIy+NBc w4Igxvmj5IzoSoY9PpWlTBavrtH/5KqdxACNoLcPSBRt8Ko3URW2IYMyqs7KzPhk24sQoiGuvkaTa LGi+dXILDn7OqtUukVcw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gugsj-0003Ku-9c; Fri, 15 Feb 2019 17:02:33 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gugsV-00036B-PA for linux-arm-kernel@lists.infradead.org; Fri, 15 Feb 2019 17:02:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=W6e6qznt2JOS/949BOx6FvCW23lwdk9RLTqcCBKSms8=; b=VQixXjMEKCu41JsHECIrGLk922 JlxigX1+jwtXXbU8T/s/JNnxGXLVL+jIY3zP4WLxrDm8LYM6plPdNXzEZYsA96vAI20gTNSvW84eV sEI/+TfRoLg1kKap9pl+oKz8kezMEcty2rbkBf5YDy7abOIeEqFIjlyF8PLRBm8Za20g=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gugsU-00087M-CR; Fri, 15 Feb 2019 18:02:18 +0100 Date: Fri, 15 Feb 2019 18:02:18 +0100 From: Andrew Lunn To: Paul Kocialkowski Subject: Re: [PATCH RESEND net] net: phy: xgmiitorgmii: Support generic PHY status read Message-ID: <20190215170218.GS708@lunn.ch> References: <20190215163220.20041-1-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190215163220.20041-1-paul.kocialkowski@bootlin.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190215_090220_275995_38540678 X-CRM114-Status: UNSURE ( 9.81 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Simek , Thomas Petazzoni , "David S . Miller" , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 15, 2019 at 05:32:20PM +0100, Paul Kocialkowski wrote: > Some PHY drivers like the generic one do not provide a read_status > callback on their own but rely on genphy_read_status being called > directly. > > With the current code, this results in a NULL function pointer call. > Call genphy_read_status instead when there is no specific callback. > > Fixes: f411a6160bd4 ("net: phy: Add gmiitorgmii converter support") > Signed-off-by: Paul Kocialkowski Reviewed-by: Andrew Lunn Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCA4BC43381 for ; Fri, 15 Feb 2019 17:02:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F98621924 for ; Fri, 15 Feb 2019 17:02:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="VQixXjME" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389171AbfBORCV (ORCPT ); Fri, 15 Feb 2019 12:02:21 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:54160 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726052AbfBORCU (ORCPT ); Fri, 15 Feb 2019 12:02:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=W6e6qznt2JOS/949BOx6FvCW23lwdk9RLTqcCBKSms8=; b=VQixXjMEKCu41JsHECIrGLk922 JlxigX1+jwtXXbU8T/s/JNnxGXLVL+jIY3zP4WLxrDm8LYM6plPdNXzEZYsA96vAI20gTNSvW84eV sEI/+TfRoLg1kKap9pl+oKz8kezMEcty2rbkBf5YDy7abOIeEqFIjlyF8PLRBm8Za20g=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gugsU-00087M-CR; Fri, 15 Feb 2019 18:02:18 +0100 Date: Fri, 15 Feb 2019 18:02:18 +0100 From: Andrew Lunn To: Paul Kocialkowski Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Florian Fainelli , Heiner Kallweit , "David S . Miller" , Michal Simek , Thomas Petazzoni Subject: Re: [PATCH RESEND net] net: phy: xgmiitorgmii: Support generic PHY status read Message-ID: <20190215170218.GS708@lunn.ch> References: <20190215163220.20041-1-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190215163220.20041-1-paul.kocialkowski@bootlin.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 15, 2019 at 05:32:20PM +0100, Paul Kocialkowski wrote: > Some PHY drivers like the generic one do not provide a read_status > callback on their own but rely on genphy_read_status being called > directly. > > With the current code, this results in a NULL function pointer call. > Call genphy_read_status instead when there is no specific callback. > > Fixes: f411a6160bd4 ("net: phy: Add gmiitorgmii converter support") > Signed-off-by: Paul Kocialkowski Reviewed-by: Andrew Lunn Andrew