All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@lists.open-mesh.org>
Cc: netdev@vger.kernel.org, Jiri Pirko <jiri@mellanox.com>,
	David Bauer <mail@david-bauer.net>
Subject: Re: [B.A.T.M.A.N.] [PATCH v2] batman-adv: Add multicast-to-unicast support for multiple targets
Date: Fri, 15 Feb 2019 18:20:07 +0100	[thread overview]
Message-ID: <20190215172007.GB1472@otheros> (raw)
In-Reply-To: <11497659.iQavgr9jVl@bentobox>

On Thu, Feb 14, 2019 at 03:04:54PM +0100, Sven Eckelmann wrote:
> On Thursday, 14 February 2019 14:44:52 CET Linus Lüssing wrote:
> [...]
> > > No new sysfs config files.
> > 
> > Why? The bridge for instance does the same.
> 
> https://patchwork.open-mesh.org/patch/16763/ - here the quote
> 
> On Samstag, 29. Oktober 2016 12:33:01 CEST Jiri Pirko wrote:
> > I strongly believe it is a huge mistake to use sysfs for things like
> > this. This should be done via generic netlink api.
> 
> We don't need to configuration interfaces - we only need the preferred one. If 
> this is sysfs for you guys then we should not have started with generic 
> netlink at all. And why wasn't this brought up now *after* the stuff was 
> merged by David. It isn't the first time that I've stated clearly that there 
> should be no new sysfs configuration files when we switch to genl.
> 
> If it now preferred to have sysfs again for configuration then please discuss 
> it with the netdev folks and find out how the new generic netlink interface 
> can be removed again before the next release.
> 
> Kind regards,
> 	Sven

Sorry, then this is all my misunderstanding. I have no issue with
removing the sysfs part from this patch (I liked sysfs for
prototyping/testing/scripting, but as we have all configuration
options available in batctl that works for me, too).

Thanks for the clarifications.

Regards, Linus

  reply	other threads:[~2019-02-15 17:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14 12:43 [B.A.T.M.A.N.] [PATCH v2] batman-adv: Add multicast-to-unicast support for multiple targets Linus Lüssing
2019-02-14 12:46 ` Sven Eckelmann
2019-02-14 13:44   ` Linus Lüssing
2019-02-14 14:04     ` Sven Eckelmann
2019-02-15 17:20       ` Linus Lüssing [this message]
2019-02-14 14:16     ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190215172007.GB1472@otheros \
    --to=linus.luessing@c0d3.blue \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=jiri@mellanox.com \
    --cc=mail@david-bauer.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.