From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Song Liu <songliubraving@fb.com>
Cc: Netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <Kernel-team@fb.com>,
Peter Zijlstra <peterz@infradead.org>,
"jolsa@kernel.org" <jolsa@kernel.org>,
"namhyung@kernel.org" <namhyung@kernel.org>
Subject: Re: [PATCH v2 perf,bpf 01/11] perf, bpf: consider events with attr.bpf_event as side-band events
Date: Fri, 15 Feb 2019 16:04:06 -0200 [thread overview]
Message-ID: <20190215180406.GH5784@redhat.com> (raw)
In-Reply-To: <ECDC9D1F-3AA3-451A-BAC7-E089D4CAAEEC@fb.com>
Em Fri, Feb 15, 2019 at 05:02:02PM +0000, Song Liu escreveu:
>
>
> > On Feb 15, 2019, at 6:14 AM, Arnaldo Carvalho de Melo <acme@redhat.com> wrote:
> >
> > Em Thu, Feb 14, 2019 at 03:58:40PM -0800, Song Liu escreveu:
> >> Events with bpf_event should be considered as side-band event, as they
> >> carry information about BPF programs.
> >>
> >> Fixes: 6ee52e2a3fe4 ("perf, bpf: Introduce PERF_RECORD_BPF_EVENT")
> >> Signed-off-by: Song Liu <songliubraving@fb.com>
> >> ---
> >> kernel/events/core.c | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/kernel/events/core.c b/kernel/events/core.c
> >> index 0a8dab322111..9403bdda5f8c 100644
> >> --- a/kernel/events/core.c
> >> +++ b/kernel/events/core.c
> >> @@ -4238,7 +4238,8 @@ static bool is_sb_event(struct perf_event *event)
> >> if (attr->mmap || attr->mmap_data || attr->mmap2 ||
> >> attr->comm || attr->comm_exec ||
> >> attr->task || attr->ksymbol ||
> ^ here
how come, I looked after context_switch, that came before, have to
replace my glasses... :-)
>
> >> - attr->context_switch)
> >> + attr->context_switch ||
> >> + attr->bpf_event)
> >
> > What about attr->ksymbol?
> It is already included up there. attr->bpf_event was missed initially
> because we didn't use events with bpf_event but not ksymbol. With this
> set, the polling thread only has bpf_event, so we need this fix.
Ok, I'll get this one merged asap.
- Arnaldo
next prev parent reply other threads:[~2019-02-15 18:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 23:56 [PATCH v2 perf,bpf 00/11] perf annotation of BPF programs Song Liu
2019-02-14 23:58 ` [PATCH v2 perf,bpf 01/11] perf, bpf: consider events with attr.bpf_event as side-band events Song Liu
2019-02-15 14:14 ` Arnaldo Carvalho de Melo
2019-02-15 17:02 ` Song Liu
2019-02-15 18:04 ` Arnaldo Carvalho de Melo [this message]
2019-02-15 0:00 ` [PATCH v2 perf,bpf 02/11] bpf: libbpf: introduce bpf_program__get_prog_info_linear() Song Liu
2019-02-15 0:00 ` [PATCH v2 perf,bpf 03/11] bpf: bpftool: use bpf_program__get_prog_info_linear() in prog.c:do_dump() Song Liu
2019-02-15 0:00 ` [PATCH v2 perf,bpf 04/11] perf, bpf: synthesize bpf events with bpf_program__get_prog_info_linear() Song Liu
2019-02-15 0:00 ` [PATCH v2 perf,bpf 05/11] perf, bpf: save bpf_prog_info in a rbtree in perf_env Song Liu
2019-02-15 14:21 ` Arnaldo Carvalho de Melo
2019-02-15 17:04 ` Song Liu
2019-02-15 0:00 ` [PATCH v2 perf,bpf 06/11] perf, bpf: save bpf_prog_info information as headers to perf.data Song Liu
2019-02-15 0:00 ` [PATCH v2 perf,bpf 07/11] perf, bpf: save btf in a rbtree in perf_env Song Liu
2019-02-15 14:30 ` Arnaldo Carvalho de Melo
2019-02-15 0:00 ` [PATCH v2 perf,bpf 08/11] perf, bpf: save btf information as headers to perf.data Song Liu
2019-02-15 14:26 ` Arnaldo Carvalho de Melo
2019-02-15 17:25 ` Song Liu
2019-02-15 17:40 ` Arnaldo Carvalho de Melo
2019-02-15 17:47 ` Song Liu
2019-02-15 18:20 ` Arnaldo Carvalho de Melo
2019-02-15 18:59 ` Song Liu
2019-02-15 0:00 ` [PATCH v2 perf,bpf 09/11] perf-top: add option --bpf-event Song Liu
2019-02-15 14:27 ` Arnaldo Carvalho de Melo
2019-02-15 17:06 ` Song Liu
2019-02-15 18:05 ` Arnaldo Carvalho de Melo
2019-02-15 0:00 ` [PATCH v2 perf,bpf 10/11] perf, bpf: enable annotation of bpf program Song Liu
2019-02-15 0:00 ` [PATCH v2 perf,bpf 11/11] perf, bpf: save information about short living bpf programs Song Liu
2019-02-15 14:41 ` Arnaldo Carvalho de Melo
2019-02-15 17:13 ` Song Liu
2019-02-15 18:09 ` Arnaldo Carvalho de Melo
2019-02-15 18:13 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215180406.GH5784@redhat.com \
--to=acme@redhat.com \
--cc=Kernel-team@fb.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.