All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/ecryptfs-utils: Use echo-dummy gettext script if NLS is not enabled
Date: Fri, 15 Feb 2019 22:47:59 +0100	[thread overview]
Message-ID: <20190215224759.522c3207@windsurf.home> (raw)
In-Reply-To: <1550084055-9176-1-git-send-email-email@gmail.com>

Hello Vadim,

On Wed, 13 Feb 2019 20:54:15 +0200
Vadim Kochan <vadim4j@gmail.com> wrote:

> From: Vadim Kochan <vadim4j@gmail.com>
> 
> gettext is used only as external tool in ecryptfs utils which can easy
> be replaced by 'echo' if NLS is not required. So changed a bit semantic
> of Config file - select gettext package only if NLS is enabled,
> otherwise a dummy-echo script is generated as 'gettext' replacement.
> 
> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> ---
>  package/ecryptfs-utils/Config.in         |  2 +-
>  package/ecryptfs-utils/ecryptfs-utils.mk | 10 ++++++++++
>  2 files changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/package/ecryptfs-utils/Config.in b/package/ecryptfs-utils/Config.in
> index 6652d33..1438c17 100644
> --- a/package/ecryptfs-utils/Config.in
> +++ b/package/ecryptfs-utils/Config.in
> @@ -12,7 +12,7 @@ config BR2_PACKAGE_ECRYPTFS_UTILS
>  	select BR2_PACKAGE_LIBNSS
>  	# runtime dependency only, some scripts are using the
>  	# 'gettext' program to get translations
> -	select BR2_PACKAGE_GETTEXT
> +	select BR2_PACKAGE_GETTEXT if BR2_SYSTEM_ENABLE_NLS
>  	# runtime dependency only
>  	select BR2_PACKAGE_GETENT
>  	help
> diff --git a/package/ecryptfs-utils/ecryptfs-utils.mk b/package/ecryptfs-utils/ecryptfs-utils.mk
> index eb3194b..a2a0af6 100644
> --- a/package/ecryptfs-utils/ecryptfs-utils.mk
> +++ b/package/ecryptfs-utils/ecryptfs-utils.mk
> @@ -25,4 +25,14 @@ else
>  ECRYPTFS_UTILS_CONF_OPTS += --disable-openssl
>  endif
>  
> +ifneq ($(BR2_SYSTEM_ENABLE_NLS),y)
> +define ECRYPTFS_UTILS_GETTEXT_DUMMY_INSTALL
> +	echo '#! /bin/sh' > $(@D)/gettext
> +	echo 'echo $$@' >> $(@D)/gettext
> +
> +	$(INSTALL) -m 0755 -D $(@D)/gettext $(TARGET_DIR)/usr/bin/gettext

I understand the idea, but I don't think it's good for ecryptfs-utils
to install a tool called "gettext". Maybe some gettext-tiny package
should provide this dummy target gettext program ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-02-15 21:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-13 18:54 [Buildroot] [PATCH 1/1] package/ecryptfs-utils: Use echo-dummy gettext script if NLS is not enabled Vadim Kochan
2019-02-15 21:47 ` Thomas Petazzoni [this message]
2019-02-15 21:53   ` Vadym Kochan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190215224759.522c3207@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.