From: Krzysztof Kozlowski <krzk@kernel.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 0/9] arm: exynos: Fix reboot on Odroid HC1
Date: Sat, 16 Feb 2019 10:45:39 +0100 [thread overview]
Message-ID: <20190216094548.911-1-krzk@kernel.org> (raw)
Hi,
Changes since v2
================
1. Add Lukasz review tags.
2. Patch 7: Return on error, as suggested by Simon.
2. Patch 3: Use IS_ENABLED() to run revision detection only
once - either during late display board or misc_init_r.
Changes since v1
================
1. Move fixes to beginning of patchset.
2. Patch 3: Rework the idea - split revision detection to be executed later.
3. Patch 4: New patch.
4. Patch 6: Apply Simon's comments.
5. Patch 6: Do not delay when changing voltage if regulator is disabled.
6. Patch 6: Do not delay when disabling the regulator.
Description
===========
Odroid HC1 does not reboot properly (at least from SD card but
I do not expect difference on eMMC), if LDO4/VDD_ADC was turned
off by Linux kernel. This condition happens so far always, because
Linux kernel did not enable ADC on Odroid HC1, therefore the
VDD_ADC regulator was turned off as unused.
The issue is in detection of revision which later is used to load
proper DTB.
The revision is obtained by ADC read of a voltage depending on VDD_ADC.
Therefore:
1. VDD_ADC has to be turned on (but board detection happens before
power is initialized),
2. Turning VDD_ADC should wait with ramp delay,
3. Reading the value from ADC should wait for it to stabilize.
Tested on Odroid XU3-Lite and Odroid HC1.
Commends and testing are welcomed.
Best regards,
Krzysztof
Krzysztof Kozlowski (9):
adc: exynos-adc: Fix wrong bit operation used to stop the ADC
power: regulator: s2mps11: Fix step for LDO27 and LDO35
arm: exynos: Detect revision later, when all resources are ready
arm: exynos: odroid-xu3: Display info late to have proper type
arm: exynos: Wait till ADC stabilizes before checking Odroid HC1
revision
regulator: Add support for ramp delay
power: regulator: s2mps11: Add enable delay
arm: dts: exynos: Add supply for ADC block to Odroid XU3 family
arm: dts: exynos: Add ramp delay property to LDO regulators to Odroid
XU3 family
arch/arm/dts/exynos5422-odroidxu3.dts | 20 +++++++
board/samsung/common/board.c | 24 ++++++++-
board/samsung/common/exynos5-dt-types.c | 54 +++++++++++++++++--
board/samsung/odroid/odroid.c | 8 +++
configs/odroid-xu3_defconfig | 2 +
.../regulator/regulator.txt | 2 +
drivers/adc/exynos-adc.c | 2 +-
drivers/power/regulator/regulator-uclass.c | 47 +++++++++++++++-
drivers/power/regulator/s2mps11_regulator.c | 15 +++++-
include/power/regulator.h | 2 +
include/samsung/misc.h | 1 +
11 files changed, 167 insertions(+), 10 deletions(-)
--
2.17.1
next reply other threads:[~2019-02-16 9:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-16 9:45 Krzysztof Kozlowski [this message]
2019-02-16 9:45 ` [U-Boot] [PATCH v3 1/9] adc: exynos-adc: Fix wrong bit operation used to stop the ADC Krzysztof Kozlowski
2019-02-16 9:45 ` [U-Boot] [PATCH v3 2/9] power: regulator: s2mps11: Fix step for LDO27 and LDO35 Krzysztof Kozlowski
2019-02-16 9:45 ` [U-Boot] [PATCH v3 3/9] arm: exynos: Detect revision later, when all resources are ready Krzysztof Kozlowski
2019-02-17 22:34 ` Lukasz Majewski
2019-02-16 9:45 ` [U-Boot] [PATCH v3 4/9] arm: exynos: odroid-xu3: Display info late to have proper type Krzysztof Kozlowski
2019-02-16 9:45 ` [U-Boot] [PATCH v3 5/9] arm: exynos: Wait till ADC stabilizes before checking Odroid HC1 revision Krzysztof Kozlowski
2019-02-16 9:45 ` [U-Boot] [PATCH v3 6/9] regulator: Add support for ramp delay Krzysztof Kozlowski
2019-02-18 14:03 ` Torsten Duwe
2019-02-18 14:28 ` Krzysztof Kozlowski
2019-02-18 15:26 ` Torsten Duwe
2019-02-19 12:14 ` Krzysztof Kozlowski
2019-02-16 9:45 ` [U-Boot] [PATCH v3 7/9] power: regulator: s2mps11: Add enable delay Krzysztof Kozlowski
2019-02-16 9:45 ` [U-Boot] [PATCH v3 8/9] arm: dts: exynos: Add supply for ADC block to Odroid XU3 family Krzysztof Kozlowski
2019-02-16 9:45 ` [U-Boot] [PATCH v3 9/9] arm: dts: exynos: Add ramp delay property to LDO regulators " Krzysztof Kozlowski
2019-02-24 12:55 ` [U-Boot] [PATCH v3 0/9] arm: exynos: Fix reboot on Odroid HC1 Anand Moon
2019-03-05 10:16 ` Minkyu Kang
2019-03-05 19:54 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190216094548.911-1-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.