From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 707E7C43381 for ; Sun, 17 Feb 2019 17:00:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B6D62146E for ; Sun, 17 Feb 2019 17:00:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="PwNkFHac" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727139AbfBQRA2 (ORCPT ); Sun, 17 Feb 2019 12:00:28 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:55771 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725810AbfBQRA1 (ORCPT ); Sun, 17 Feb 2019 12:00:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xiIwf1ROrudQp4+9iTNheI+SaM2NezEs4rVVbw/Exxk=; b=PwNkFHacpazwodOHeORgkIHzd6 8ivwP4ujP6O33b9xnUy1VFiAutPJ60DFBH+plche6nQHUKDlbcxx4ozLPdJ5QgVW3esim2dD3r4sP Eaf2uqHyNuS0Cf2gDdVgpSoM/Raj1S4L5OFG+80aiMHXxEVN2d3yPIBttH/BmEkihIi8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gvPnk-00038v-2E; Sun, 17 Feb 2019 18:00:24 +0100 Date: Sun, 17 Feb 2019 18:00:24 +0100 From: Andrew Lunn To: Russell King - ARM Linux admin Cc: Florian Fainelli , Vivien Didelot , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH net] net: dsa: fix lockdep warning Message-ID: <20190217170024.GG5968@lunn.ch> References: <20190217164629.GE5968@lunn.ch> <20190217165140.3zyy24vi6mier2tt@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190217165140.3zyy24vi6mier2tt@shell.armlinux.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Feb 17, 2019 at 04:51:40PM +0000, Russell King - ARM Linux admin wrote: > On Sun, Feb 17, 2019 at 05:46:29PM +0100, Andrew Lunn wrote: > > On Sun, Feb 17, 2019 at 04:27:32PM +0000, Russell King wrote: > > > ====================================================== > > > WARNING: possible circular locking dependency detected > > > 4.20.0+ #302 Not tainted > > > ------------------------------------------------------ > > > > Hi Russell > > > > Thanks for turning this into a proper patch. I had just started to try > > to reproduce this and confirm your fix. I will add a tested-by once i > > do. > > Do you have a clearfog board? If so, just add: > > + interrupt-parent = <&gpio0>; > + interrupts = <23 IRQ_TYPE_LEVEL_LOW>; > > to the DSA switch definitions in > arch/arm/boot/dts/armada-388-clearfog.dts Hi Russell I'm using a different board, but i have a similar interrupt configuration. I just expect that turning on LOCKDEP should be enough. I don't think EPROBE_DEFFER is playing a part here. Andrew