From: Sasha Levin <sashal@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, openwrt-devel@lists.openwrt.org,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Liping Zhang" <zlpnobody@gmail.com>,
"John Youn" <johnyoun@synopsys.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"James Hughes" <james.hughes@raspberrypi.org>,
"Felix Fietkau" <nbd@nbd.name>,
"Boris Brezillon" <boris.brezillon@free-electrons.com>,
"Richard Weinberger" <richard@nod.at>
Subject: Re: [PATCH 5/8 v3] ubifs: Drop softlimit and delta fields from struct ubifs_wbuf
Date: Sun, 17 Feb 2019 13:16:46 -0500 [thread overview]
Message-ID: <20190217181646.GG10616@sasha-vm> (raw)
In-Reply-To: <20190214132403.10687-6-linus.walleij@linaro.org>
On Thu, Feb 14, 2019 at 02:24:00PM +0100, Linus Walleij wrote:
>From: Rafał Miłecki <rafal@milecki.pl>
>
>commit 854826c9d526fd81077742c3b000e3f7fcaef3ce upstream.
>
>Values of these fields are set during init and never modified. They are
>used (read) in a single function only. There isn't really any reason to
>keep them in a struct. It only makes struct just a bit bigger without
>any visible gain.
>
>Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>Signed-off-by: Richard Weinberger <richard@nod.at>
>Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This one is a cleanup, why is it needed in -stable?
--
Thanks,
Sasha
next prev parent reply other threads:[~2019-02-17 18:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 13:23 [PATCH 0/8 v3] Stable material from OpenWrt for v4.9.y Linus Walleij
2019-02-14 13:23 ` [PATCH 1/8 v3] bridge: multicast to unicast Linus Walleij
2019-02-17 18:16 ` Sasha Levin
2019-02-17 21:08 ` Linus Walleij
2019-02-14 13:23 ` [PATCH 2/8 v3] smsc95xx: Use skb_cow_head to deal with cloned skbs Linus Walleij
2019-02-14 13:23 ` [PATCH 3/8 v3] ch9200: use skb_cow_head() " Linus Walleij
2019-02-14 13:23 ` [PATCH 4/8 v3] kaweth: " Linus Walleij
2019-02-14 13:24 ` [PATCH 5/8 v3] ubifs: Drop softlimit and delta fields from struct ubifs_wbuf Linus Walleij
2019-02-17 18:16 ` Sasha Levin [this message]
2019-02-17 20:57 ` Linus Walleij
2019-02-14 13:24 ` [PATCH 6/8 v3] ubifs: Use dirty_writeback_interval value for wbuf timer Linus Walleij
2019-02-17 18:18 ` Sasha Levin
2019-02-17 18:49 ` Richard Weinberger
2019-02-17 20:56 ` Linus Walleij
2019-02-14 13:24 ` [PATCH 7/8 v3] usb: dwc2: Remove unnecessary kfree Linus Walleij
2019-02-14 13:24 ` [PATCH 8/8 v3] netfilter: nf_tables: fix mismatch in big-endian system Linus Walleij
2019-02-18 12:45 ` [PATCH 0/8 v3] Stable material from OpenWrt for v4.9.y Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190217181646.GG10616@sasha-vm \
--to=sashal@kernel.org \
--cc=boris.brezillon@free-electrons.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.hughes@raspberrypi.org \
--cc=johnyoun@synopsys.com \
--cc=linus.walleij@linaro.org \
--cc=nbd@nbd.name \
--cc=openwrt-devel@lists.openwrt.org \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=zlpnobody@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.