From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F614C43381 for ; Sun, 17 Feb 2019 18:16:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CABC3217F5 for ; Sun, 17 Feb 2019 18:16:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550427408; bh=4ogd7mIx3Zb7HaCbO56XLF1ni0C/m0JGkfqhj53NJNY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=LtYmdSgIuFWHlSnQKpyGpNVYhuoTKqoLvRsmyfWHefL040g3eh5bSuBSA/DSNfI9f e8okQjCClZfT1tmmFm+JNc9Hs5gjyquhV6Qj74W7SKw+UXGtpaj7JUDMDlLcbixy4y CAriAV300O8K/XSNsarFg22iFIMkxYHYHA68puYQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725798AbfBQSQs (ORCPT ); Sun, 17 Feb 2019 13:16:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:35834 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725771AbfBQSQs (ORCPT ); Sun, 17 Feb 2019 13:16:48 -0500 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 65085217D9; Sun, 17 Feb 2019 18:16:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550427407; bh=4ogd7mIx3Zb7HaCbO56XLF1ni0C/m0JGkfqhj53NJNY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aPH+p89G/if/4KtREUiPtf0SDgL+qtaJJKzGwZ4L1Xqf7dp5+7eAnB7dD8pzyQyk/ 0iIoANsn+FpFgBQHgHbG9/ZAyLD3HtFWnG9+AQ0BaN6W1UWk/2VpK2WeNlEAoUJUXR OWbeE/YNGj5JyASgvpoSu21yJk+aqi1T7jL9owKo= Date: Sun, 17 Feb 2019 13:16:46 -0500 From: Sasha Levin To: Linus Walleij Cc: Greg Kroah-Hartman , stable@vger.kernel.org, openwrt-devel@lists.openwrt.org, "David S . Miller" , Eric Dumazet , Liping Zhang , John Youn , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , James Hughes , Felix Fietkau , Boris Brezillon , Richard Weinberger Subject: Re: [PATCH 5/8 v3] ubifs: Drop softlimit and delta fields from struct ubifs_wbuf Message-ID: <20190217181646.GG10616@sasha-vm> References: <20190214132403.10687-1-linus.walleij@linaro.org> <20190214132403.10687-6-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190214132403.10687-6-linus.walleij@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Feb 14, 2019 at 02:24:00PM +0100, Linus Walleij wrote: >From: Rafał Miłecki > >commit 854826c9d526fd81077742c3b000e3f7fcaef3ce upstream. > >Values of these fields are set during init and never modified. They are >used (read) in a single function only. There isn't really any reason to >keep them in a struct. It only makes struct just a bit bigger without >any visible gain. > >Signed-off-by: Rafał Miłecki >Reviewed-by: Boris Brezillon >Signed-off-by: Richard Weinberger >Signed-off-by: Linus Walleij This one is a cleanup, why is it needed in -stable? -- Thanks, Sasha