All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: David Hildenbrand <david@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
	qemu-ppc@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>,
	Richard Henderson <rth@twiddle.net>,
	Thomas Huth <thuth@redhat.com>,
	Laurent Vivier <lvivier@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Collin Walling <walling@linux.ibm.com>,
	Pierre Morel <pmorel@linux.ibm.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Greg Kurz <groug@kaod.org>, Igor Mammedov <imammedo@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/6] cpus: Properly release the iothread lock when killing a dummy VCPU
Date: Mon, 18 Feb 2019 10:58:19 +1100	[thread overview]
Message-ID: <20190217235819.GL2765@umbus.fritz.box> (raw)
In-Reply-To: <20190215133005.15955-2-david@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 841 bytes --]

On Fri, Feb 15, 2019 at 02:30:00PM +0100, David Hildenbrand wrote:
> This enables CPU unplug under qtest.
> 
> Signed-off-by: David Hildenbrand <david@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  cpus.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/cpus.c b/cpus.c
> index 154daf57dc..e83f72b48b 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -1333,6 +1333,7 @@ static void *qemu_dummy_cpu_thread_fn(void *arg)
>          qemu_wait_io_event(cpu);
>      } while (!cpu->unplug);
>  
> +    qemu_mutex_unlock_iothread();
>      rcu_unregister_thread();
>      return NULL;
>  #endif

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2019-02-18  0:23 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-15 13:29 [Qemu-devel] [PATCH v2 0/6] tests: Add device unplug tests David Hildenbrand
2019-02-15 13:30 ` [Qemu-devel] [PATCH v2 1/6] cpus: Properly release the iothread lock when killing a dummy VCPU David Hildenbrand
2019-02-15 14:53   ` Greg Kurz
2019-02-15 15:14   ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2019-02-17 23:58   ` David Gibson [this message]
2019-02-15 13:30 ` [Qemu-devel] [PATCH v2 2/6] spapr: support memory unplug for qtest David Hildenbrand
2019-02-15 14:30   ` Greg Kurz
2019-02-17 23:59   ` David Gibson
2019-02-15 13:30 ` [Qemu-devel] [PATCH v2 3/6] tests/device-plug: Add a simple PCI unplug request test David Hildenbrand
2019-02-15 15:20   ` Greg Kurz
2019-02-15 15:21   ` Thomas Huth
2019-02-18  8:42     ` David Hildenbrand
2019-02-15 18:37   ` [Qemu-devel] [qemu-s390x] " Collin Walling
2019-02-18  0:58   ` [Qemu-devel] " David Gibson
2019-02-15 13:30 ` [Qemu-devel] [PATCH v2 4/6] tests/device-plug: Add CCW unplug test for s390x David Hildenbrand
2019-02-15 15:29   ` Thomas Huth
2019-02-15 13:30 ` [Qemu-devel] [PATCH v2 5/6] tests/device-plug: Add CPU core unplug request test for spapr David Hildenbrand
2019-02-15 15:35   ` Thomas Huth
2019-02-18  8:46     ` David Hildenbrand
2019-02-15 16:03   ` Greg Kurz
2019-02-15 13:30 ` [Qemu-devel] [PATCH v2 6/6] tests/device-plug: Add memory " David Hildenbrand
2019-02-15 15:56   ` Thomas Huth
2019-02-18  3:23     ` David Gibson
2019-02-15 15:58   ` Thomas Huth
2019-02-18  8:50     ` David Hildenbrand
2019-02-15 16:03   ` Greg Kurz
2019-02-15 21:27 ` [Qemu-devel] [PATCH v2 0/6] tests: Add device unplug tests Michael S. Tsirkin
2019-02-15 22:09   ` David Hildenbrand
2019-02-18  3:24     ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190217235819.GL2765@umbus.fritz.box \
    --to=david@gibson.dropbear.id.au \
    --cc=cohuck@redhat.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=david@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=groug@kaod.org \
    --cc=imammedo@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=pmorel@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    --cc=walling@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.