From mboxrd@z Thu Jan 1 00:00:00 1970 From: Niklas Cassel Subject: Re: [PATCH v2 1/2] net: phy: at803x: dont inline helpers Date: Mon, 18 Feb 2019 11:28:28 +0100 Message-ID: <20190218102828.GA25677@centauri.lan> References: <20190218101853.4290-1-vkoul@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190218101853.4290-1-vkoul@kernel.org> Sender: netdev-owner@vger.kernel.org To: Vinod Koul Cc: David S Miller , linux-arm-msm@vger.kernel.org, Bjorn Andersson , netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli , "Nori, Sekhar" , Peter Ujfalusi , Marc Gonzalez List-Id: linux-arm-msm@vger.kernel.org On Mon, Feb 18, 2019 at 03:48:52PM +0530, Vinod Koul wrote: > Some helpers were inlined, but makes more sense to allow compiler > to do the right optiomazations instead, so remove inline for > at803x_disable_rx_delay() and at803x_disable_tx_delay() > > Signed-off-by: Vinod Koul > --- > drivers/net/phy/at803x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c > index 8ff12938ab47..c6e7d800fd7a 100644 > --- a/drivers/net/phy/at803x.c > +++ b/drivers/net/phy/at803x.c > @@ -110,13 +110,13 @@ static int at803x_debug_reg_mask(struct phy_device *phydev, u16 reg, > return phy_write(phydev, AT803X_DEBUG_DATA, val); > } > > -static inline int at803x_disable_rx_delay(struct phy_device *phydev) > +static int at803x_disable_rx_delay(struct phy_device *phydev) > { > return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0, > AT803X_DEBUG_RX_CLK_DLY_EN, 0); > } > > -static inline int at803x_disable_tx_delay(struct phy_device *phydev) > +static int at803x_disable_tx_delay(struct phy_device *phydev) > { > return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_5, > AT803X_DEBUG_TX_CLK_DLY_EN, 0); > -- > 2.20.1 > Reviewed-by: Niklas Cassel