From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH] net: dsa: qca8k: Enable delay for RGMII_ID mode
Date: Mon, 18 Feb 2019 14:36:21 +0100
Message-ID: <20190218133621.GC14879@lunn.ch>
References: <20190218130352.9373-1-vkoul@kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <netdev-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20190218130352.9373-1-vkoul@kernel.org>
Sender: netdev-owner@vger.kernel.org
To: Vinod Koul <vkoul@kernel.org>
Cc: David S Miller <davem@davemloft.net>, linux-arm-msm@vger.kernel.org, Bjorn Andersson <bjorn.andersson@linaro.org>, netdev@vger.kernel.org, Niklas Cassel <niklas.cassel@linaro.org>, Florian Fainelli <f.fainelli@gmail.com>, Michal =?utf-8?B?Vm9rw6HEjQ==?= <michal.vokac@ysoft.com>
List-Id: linux-arm-msm@vger.kernel.org

On Mon, Feb 18, 2019 at 06:33:51PM +0530, Vinod Koul wrote:
> +	case PHY_INTERFACE_MODE_RGMII_ID:
> +		/* RGMII_ID needs internal delay. This is enabled through
> +		 * PORT5_PAD_CTRL for all ports, rather than individual port
> +		 * registers
> +		 */
> +		qca8k_write(priv, reg,
> +			    QCA8K_PORT_PAD_RGMII_EN |
> +			    QCA8K_PORT_PAD_RGMII_TX_DELAY(3) |
> +			    QCA8K_PORT_PAD_RGMII_RX_DELAY(3));

Hi Vinod

Could you add some #defines for the delay values?

    Thanks
	Andrew