From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+ From: Stanislaw Gruszka Message-Id: <20190218144755.GB9602@redhat.com> Date: Mon, 18 Feb 2019 15:47:56 +0100 To: Lorenzo Bianconi Cc: Stefan Wahren , Alan Stern , Felix Fietkau , Doug Anderson , Minas Harutyunyan , USB list , linux-wireless List-ID: T24gTW9uLCBGZWIgMTgsIDIwMTkgYXQgMDM6MjU6MjhQTSArMDEwMCwgTG9yZW56byBCaWFuY29u aSB3cm90ZToKPiA+IGNvbW1pdCAwZDk4MTMzMTliNDAzOTlhMGQ4ZmQ3NjFkMmZjZmVkZWU1NzAx NDg3Cj4gPiBBdXRob3I6IExvcmVuem8gQmlhbmNvbmkgPGxvcmVuem8uYmlhbmNvbmlAcmVkaGF0 LmNvbT4KPiA+IERhdGU6ICAgRnJpIFNlcCA3IDIzOjEzOjEyIDIwMTggKzAyMDAKPiAKPiBbLi4u XQo+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL21lZGlhdGVrL210NzYv bXQ3NngwMl91dGlsLmMgYi9kcml2ZXJzL25ldC93aXJlbGVzcy9tZWRpYXRlay9tdDc2L210NzZ4 MDJfdXRpbC5jCj4gPiBpbmRleCAwNjI2MTRhZDBkNTEuLjA4NDI1YjFkMmMzMCAxMDA2NDQKPiA+ IC0tLSBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL21lZGlhdGVrL210NzYvbXQ3NngwMl91dGlsLmMK PiA+ICsrKyBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL21lZGlhdGVrL210NzYvbXQ3NngwMl91dGls LmMKPiA+IEBAIC01NTAsMjEgKzU1MCwzMyBAQCB2b2lkIG10NzZ4MDJfc3RhX3JhdGVfdGJsX3Vw ZGF0ZShzdHJ1Y3QgaWVlZTgwMjExX2h3ICpodywKPiA+ICB9Cj4gPiAgRVhQT1JUX1NZTUJPTF9H UEwobXQ3NngwMl9zdGFfcmF0ZV90YmxfdXBkYXRlKTsKPiA+ICAKPiA+IC1pbnQgbXQ3NngwMl9p bnNlcnRfaGRyX3BhZChzdHJ1Y3Qgc2tfYnVmZiAqc2tiKQo+ID4gK3ZvaWQgbXQ3NngwMl9hbGln bl9za2Ioc3RydWN0IHNrX2J1ZmYgKnNrYikKPiA+ICB7Cj4gPiAtCWludCBsZW4gPSBpZWVlODAy MTFfZ2V0X2hkcmxlbl9mcm9tX3NrYihza2IpOwo+ID4gKwlpbnQgYWxpZ24gPSAoKHVuc2lnbmVk IGxvbmcpIHNrYi0+ZGF0YSkgJiAzOwo+ID4gKwlpbnQgaGRybGVuLCBza2JsZW47Cj4gPiAgCj4g PiAtCWlmIChsZW4gJSA0ID09IDApCj4gPiAtCQlyZXR1cm4gMDsKPiA+ICsJaGRybGVuID0gaWVl ZTgwMjExX2dldF9oZHJsZW5fZnJvbV9za2Ioc2tiKTsKPiA+ICsJV0FSTl9PTl9PTkNFKGFsaWdu ID09IDAgJiYgKGhkcmxlbiAmIDMpKTsKPiA+ICsKPiA+ICsJaWYgKGFsaWduID09IDApCj4gPiAr CQlyZXR1cm47Cj4gCj4gSGkgU3RhbmlzbGF3LAo+IAo+IGlzIGl0IHBvc3NpYmxlIHRoYXQgc2ti LT5kYXRhIGlzIDQgYnl0ZSBhbGlnbmVkIGJ1dCBoZHJsZW4gaXMgbm90PyAoZS5nIDRhZGRyCj4g ZGF0YSBmcmFtZXMsIG5vdCBxb3MpPwoKSXQgbWlnaHQgYmUgcG9zc2libGUsIHNvIGZvciBub3cg SSBhZGQgdGhpcyAKCldBUk5fT05fT05DRShhbGlnbiA9PSAwICYmIChoZHJsZW4gJiAzKSk7Cgph bmQgcGxhbiB0byBkbyBzb21lIGludmVzdGlnYXRpb24gb24gZnJhbWUgYWxpbWVudC4KCj4gYXJl IHlvdSBzdXJlIHRoaXMgaXMgdHJ1ZSAqb25seSogZm9yIHByb2JlIHJlcXVlc3RzPwo+IHRoaXMg Y291bGQgaGl0IHBlcmZvcm1hbmNlcyBhbmQgaXQgaXMgdXNlZCBldmVuIGluIHBjaSBjb2RlCgpJ J20gbm90IDEwMCUgc3VyZSwgYnV0IEkgaGF2ZW4ndCBzZWVuIGFueSBvdGhlciBmcmFtZXMgd2l0 aAp0aGF0LiBBbGwgb3RoZXIgdW5hbGlnbmVkIGZyYW1lcyBJJ3ZlIHNlZW4gaW4gbXkgdGVzdHMg aGFkCnVuYWxpZ25lZCBoZWFkZXIgYW5kIGFkZGluZyBoZWFkZXIgcGFkIGFsaWduZWQgdGhlbS4K QnV0IG9idmlvdXNseSBJJ3ZlIGhhdmVuJ3QgdGVzdGVkIGFsbCBwb3NzaWJsZSBzY2VuYXJpb3Mu CgpTdGFuaXNsYXcK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B053C43381 for ; Mon, 18 Feb 2019 14:48:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 174EC2070B for ; Mon, 18 Feb 2019 14:48:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732983AbfBROsH (ORCPT ); Mon, 18 Feb 2019 09:48:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34526 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731038AbfBROsF (ORCPT ); Mon, 18 Feb 2019 09:48:05 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 578838E6EE; Mon, 18 Feb 2019 14:48:04 +0000 (UTC) Received: from localhost (unknown [10.40.205.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 91DB55D719; Mon, 18 Feb 2019 14:47:57 +0000 (UTC) Date: Mon, 18 Feb 2019 15:47:56 +0100 From: Stanislaw Gruszka To: Lorenzo Bianconi Cc: Stefan Wahren , Alan Stern , Felix Fietkau , Doug Anderson , Minas Harutyunyan , USB list , linux-wireless Subject: Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+ Message-ID: <20190218144755.GB9602@redhat.com> References: <20190212093035.GB12906@redhat.com> <404607590.373282.1550126997144@email.ionos.de> <20190214092530.GA17273@redhat.com> <878a7160-2e91-d057-6d27-c6b9d85f700e@i2se.com> <20190215071226.GA2372@redhat.com> <1411983628.668277.1550315118443@email.ionos.de> <20190216140739.GA2236@redhat.com> <2009016263.528260.1550344627996@email.ionos.de> <20190218135247.GA9602@redhat.com> <20190218142527.GA9283@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190218142527.GA9283@localhost.localdomain> User-Agent: Mutt/1.8.3 (2017-05-23) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 18 Feb 2019 14:48:05 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, Feb 18, 2019 at 03:25:28PM +0100, Lorenzo Bianconi wrote: > > commit 0d9813319b40399a0d8fd761d2fcfedee5701487 > > Author: Lorenzo Bianconi > > Date: Fri Sep 7 23:13:12 2018 +0200 > > [...] > > > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_util.c b/drivers/net/wireless/mediatek/mt76/mt76x02_util.c > > index 062614ad0d51..08425b1d2c30 100644 > > --- a/drivers/net/wireless/mediatek/mt76/mt76x02_util.c > > +++ b/drivers/net/wireless/mediatek/mt76/mt76x02_util.c > > @@ -550,21 +550,33 @@ void mt76x02_sta_rate_tbl_update(struct ieee80211_hw *hw, > > } > > EXPORT_SYMBOL_GPL(mt76x02_sta_rate_tbl_update); > > > > -int mt76x02_insert_hdr_pad(struct sk_buff *skb) > > +void mt76x02_align_skb(struct sk_buff *skb) > > { > > - int len = ieee80211_get_hdrlen_from_skb(skb); > > + int align = ((unsigned long) skb->data) & 3; > > + int hdrlen, skblen; > > > > - if (len % 4 == 0) > > - return 0; > > + hdrlen = ieee80211_get_hdrlen_from_skb(skb); > > + WARN_ON_ONCE(align == 0 && (hdrlen & 3)); > > + > > + if (align == 0) > > + return; > > Hi Stanislaw, > > is it possible that skb->data is 4 byte aligned but hdrlen is not? (e.g 4addr > data frames, not qos)? It might be possible, so for now I add this WARN_ON_ONCE(align == 0 && (hdrlen & 3)); and plan to do some investigation on frame aliment. > are you sure this is true *only* for probe requests? > this could hit performances and it is used even in pci code I'm not 100% sure, but I haven't seen any other frames with that. All other unaligned frames I've seen in my tests had unaligned header and adding header pad aligned them. But obviously I've haven't tested all possible scenarios. Stanislaw