From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Joe Ranieri <jranieri@grammatech.com>
Cc: git@vger.kernel.org
Subject: Re: [BUG] ls-files showing deleted files (unchecked lstat return value)
Date: Mon, 18 Feb 2019 16:17:25 +0100 [thread overview]
Message-ID: <20190218151725.GL1622@szeder.dev> (raw)
In-Reply-To: <1ff48830-f3de-11f4-9014-c20eb3890c21@grammatech.com>
On Sun, Feb 17, 2019 at 08:49:39AM -0500, Joe Ranieri wrote:
> "git ls-files -m" can show deleted files, despite -d not having been
> specified.
To my understanding that's intentional: a deleted file is considered
modified, because its content clearly doesn't match the tracked
content.
> This is due to ls-files.c's show_files function calling lstat but
> not checking the return value before calling ie_modified with the
> uninitialized stat structure.
>
> This problem was found using the static analysis tool GrammaTech CodeSonar.
next prev parent reply other threads:[~2019-02-18 15:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-17 13:49 [BUG] ls-files showing deleted files (unchecked lstat return value) Joe Ranieri
2019-02-17 15:59 ` Randall S. Becker
2019-02-18 14:09 ` Joe Ranieri
2019-02-18 15:17 ` SZEDER Gábor [this message]
2019-02-18 16:14 ` Randall S. Becker
2019-02-20 22:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218151725.GL1622@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=git@vger.kernel.org \
--cc=jranieri@grammatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.