From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 1/2] drm: panel-orientation-quirks: Get rid of superfluous (void *) casting Date: Mon, 18 Feb 2019 16:25:49 +0100 Message-ID: <20190218152549.GB21562@ulmo> References: <20190216195834.6245-1-howl.nsp@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1754043713==" Return-path: Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id D6A03891CB for ; Mon, 18 Feb 2019 15:25:52 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id n2so6659667wrw.8 for ; Mon, 18 Feb 2019 07:25:52 -0800 (PST) In-Reply-To: <20190216195834.6245-1-howl.nsp@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David =?utf-8?Q?Santamar=C3=ADa?= Rogado Cc: David Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1754043713== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZoaI/ZTpAVc4A5k6" Content-Disposition: inline --ZoaI/ZTpAVc4A5k6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 16, 2019 at 08:58:33PM +0100, David Santamar=C3=ADa Rogado wrot= e: > From: howl Any reason why this differs from the Signed-off-by line? Perhaps check your git configuration if this wasn't on purpose. Or perhaps you've fixed the configuration since you authored the commits, in which case you should be able to fix this by doing this: $ git commit --reset-author --amend You'd need to run that for each of the commits. Thierry >=20 > The (void *) casting in the driver_data variable assignment is superfluou= s. > Spotted by Jani Nikula. >=20 > Signed-off-by: David Santamar=C3=ADa Rogado > --- > drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) >=20 > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu= /drm/drm_panel_orientation_quirks.c > index 52e445bb1aa5..61d3361381b7 100644 > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c > @@ -86,13 +86,13 @@ static const struct dmi_system_id orientation_data[] = =3D { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Acer"), > DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"), > }, > - .driver_data =3D (void *)&acer_s1003, > + .driver_data =3D &acer_s1003, > }, { /* Asus T100HA */ > .matches =3D { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100HAN"), > }, > - .driver_data =3D (void *)&asus_t100ha, > + .driver_data =3D &asus_t100ha, > }, { /* > * GPD Pocket, note that the the DMI data is less generic then > * it seems, devices with a board-vendor of "AMI Corporation" > @@ -105,7 +105,7 @@ static const struct dmi_system_id orientation_data[] = =3D { > DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"), > DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"), > }, > - .driver_data =3D (void *)&gpd_pocket, > + .driver_data =3D &gpd_pocket, > }, { /* GPD Win (same note on DMI match as GPD Pocket) */ > .matches =3D { > DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"), > @@ -113,7 +113,7 @@ static const struct dmi_system_id orientation_data[] = =3D { > DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"), > DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"), > }, > - .driver_data =3D (void *)&gpd_win, > + .driver_data =3D &gpd_win, > }, { /* GPD Win 2 (too generic strings, also match on bios date) */ > .matches =3D { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Default string"), > @@ -121,7 +121,7 @@ static const struct dmi_system_id orientation_data[] = =3D { > DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"), > DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"), > }, > - .driver_data =3D (void *)&gpd_win2, > + .driver_data =3D &gpd_win2, > }, { /* I.T.Works TW891 */ > .matches =3D { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."), > @@ -129,7 +129,7 @@ static const struct dmi_system_id orientation_data[] = =3D { > DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "To be filled by O.E.M."), > DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"), > }, > - .driver_data =3D (void *)&itworks_tw891, > + .driver_data =3D &itworks_tw891, > }, { /* > * Lenovo Ideapad Miix 310 laptop, only some production batches > * have a portrait screen, the resolution checks makes the quirk > @@ -140,20 +140,20 @@ static const struct dmi_system_id orientation_data[= ] =3D { > DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80SG"), > DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"), > }, > - .driver_data =3D (void *)&lcd800x1280_rightside_up, > + .driver_data =3D &lcd800x1280_rightside_up, > }, { /* Lenovo Ideapad Miix 320 */ > .matches =3D { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), > DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"), > DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"), > }, > - .driver_data =3D (void *)&lcd800x1280_rightside_up, > + .driver_data =3D &lcd800x1280_rightside_up, > }, { /* VIOS LTH17 */ > .matches =3D { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"), > DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "LTH17"), > }, > - .driver_data =3D (void *)&lcd800x1280_rightside_up, > + .driver_data =3D &lcd800x1280_rightside_up, > }, > {} > }; > --=20 > 2.20.1 >=20 --ZoaI/ZTpAVc4A5k6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlxqznoACgkQ3SOs138+ s6HpUw/9HSjSAbLjG2kIE4kYWNgu4Y5a0PpwVz0R1X94z7PJ8LGtfABLt3h3GzvY bt3xteqRPcWMr6dlnxYurZ6Ut2NoyHiZlle1wtfZhZhmnzx4HLdGLNxSvwAAn42J mXQRzuX3r34S1TNm3ilzWuS8kdy55NyjazOpJwPj1NWq+1nHV8bQqONYKtIVn+NW 4FYGSLQrqf6zdF6+Yi6QeRY9TFE4O4nCYSSDfQoOwaxhaeqzD69/8Wzbow1wmU3C G5Q+tplDv4o8VgxZgogQjHAsQhdbQR69EffVHrwDZhYaViXBlRHl8lKoQ8QETcE0 qtBXNyaN2K+ulJwFbRKcW2mCwSFz2gUbSluwqslAsdxGouIIcaseqcFZbbP4qGkW +V4KzsPpRD39N/2Uy4hRfvSjaya5TbAiuCNv4GD3Nk1Px/xltAcP2+XsvKK+ySJp ocqWhjUD+lcJspjaeZhyn9IEQ5XcGQd17Z41tWHnxG3vT3+ASeJCdnnfEwJby03t u5GvZYYj7XtkmeZUmM1G8vTLu8iwC0Yk4AJeqZbYmywGzqyDo95CyM1X1FoXVoYx T7mqjW+o/URIeWUBamGROEiRv4S/X+nSyvktWFvy/OdhZ5cW1vRDzT0Z67sZUEP9 EojKt43w8HMtyQCafsoR7dVD6Xpptzb/0VaRLw8nCqHZ/OH5DYE= =PnlK -----END PGP SIGNATURE----- --ZoaI/ZTpAVc4A5k6-- --===============1754043713== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1754043713==--