From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/icl: Fix checks for userspace ctm + ycbcr output Date: Mon, 18 Feb 2019 22:28:07 +0200 Message-ID: <20190218202807.GY20097@intel.com> References: <20190215233541.16445-1-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 850BD89182 for ; Mon, 18 Feb 2019 20:28:11 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190215233541.16445-1-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBGZWIgMTUsIDIwMTkgYXQgMDM6MzU6NDFQTSAtMDgwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBXZSByZWNlbnRseSBhZGRlZCBzdXBwb3J0IGZvciBnZW4xMSdzIG5ldyAib3V0cHV0IGNz YyIgd2hpY2ggY2FuIGJlIHVzZWQKPiBpbmRlcGVuZGVudGx5IG9mIHRoZSByZWd1bGFyIHBpcGUg Q1NDLiAgVGhlIGlkZWEgaXMgdGhhdCB0aGlzIG5ldyBvdXRwdXQKPiBjc2MgYWxsb3dzIHVzIHRv IHVzZSBhIHVzZXJzcGFjZS1wcm92aWRlZCBjb2xvciB0cmFuc2Zvcm1hdGlvbiBtYXRyaXggYXQK PiB0aGUgc2FtZSB0aW1lIHdlIGRyaXZlIGEgWUNCQ1IgZGlzcGxheSBtb2RlIHJlcXVpcmluZyBS R0ItPllVVgo+IGNvbnZlcnNpb24uICBIb3dldmVyIHdoZW4gbGFuZGluZyB0aGF0IHN1cHBvcnQg d2Ugb25seSB1cGRhdGVkIHRoZSBjb2xvcgo+IG1hbmFnZW1lbnQgY29kZSBhbmQgb3Zlcmxvb2tl ZCB0aGF0IHRoZXJlIHdhcyBhbiBhZGRpdGlvbmFsIGF0b21pYyBjaGVjawo+IGluIHRoZSBtb2Rl c2V0IHBhdGggKGluIGludGVsX2NydGNfY29tcHV0ZV9jb25maWcoKSkgdGhhdCBzdGlsbCBhc3N1 bWVzCj4gd2Ugb25seSBoYXZlIGEgc2luZ2xlIENTQyB1bml0IHRvIHdvcmsgd2l0aC4gIExldCdz IHVwZGF0ZSB0aGF0IGNoZWNrIHRvCj4gb25seSBhcHBseSB0byBwcmUtZ2VuMTEgcGxhdGZvcm1z IGFuZCBtb3ZlIGl0IGludG8gdGhlIGNvbG9yIG1hbmFnZW1lbnQKPiBjb2RlIHRvIGVuc3VyZSBp dCBnZXRzIGNhbGxlZCBvbiBhbGwgY29tbWl0cywgbm90IGp1c3QgbW9kZXNldHMuCj4gCj4gQWxz bywgaWYgd2UncmUgKm9ubHkqIHVzaW5nIHRoZSBvdXRwdXQgQ1NDIGFuZCBub3QgdGhlIHBpcGUg Q1NDLCB0aGVyZSdzCj4gbm8gbmVlZCB0byBzZXQgY3J0Y19zdGF0ZS0+Y3NjX2VuYWJsZSwgc28g bGV0J3MgYWxzbyBub3QgY29uc2lkZXIgdGhlCj4gb3V0cHV0IGZvcm1hdCB3aGVuIHNldHRpbmcg Y3NjX2VuYWJsZSBvbiBnZW4xMSsgcGxhdGZvcm1zLgo+IAo+IEZpeGVzOiBhOTFkZTU4MDU0MWMg KCJkcm0vaTkxNS9pY2w6IEVuYWJsZSBwaXBlIG91dHB1dCBjc2MiKQo+IENjOiBVbWEgU2hhbmth ciA8dW1hLnNoYW5rYXJAaW50ZWwuY29tPgo+IENjOiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRl bi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxl LnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IE1hdHQgUm9wZXIgPG1h dHRoZXcuZC5yb3BlckBpbnRlbC5jb20+Cj4gLS0tCj4gSXQgbWlnaHQgYWxzbyBiZSB3b3J0aCBt b3ZpbmcgdGhlIGZ1bGwtPmxpbWl0ZWQgcmFuZ2UgUkdCIGNvbnZlcnNpb24KPiBmcm9tIHRoZSBw aXBlIENTQyB0byB0aGUgb3V0cHV0IENTQyBvbiBnZW4xMSBhdCBzb21lIHBvaW50Lgo+IAo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jICAgfCAxNiArKysrKysrKysrKysrLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDEyIC0tLS0tLS0tLS0t LQo+ICAyIGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDE1IGRlbGV0aW9ucygtKQo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY29sb3IuYwo+IGluZGV4IGRhN2EwN2Q1Y2NlYS4uYjQ3 ZTZkMWFhYWVjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9y LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jCj4gQEAgLTc4MCw5 ICs3ODAsMTAgQEAgaW50IGludGVsX2NvbG9yX2NoZWNrKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRl ICpjcnRjX3N0YXRlKQo+ICAJICAgIElTX0JST0FEV0VMTChkZXZfcHJpdikgfHwgSVNfSEFTV0VM TChkZXZfcHJpdikpCj4gIAkJbGltaXRlZF9jb2xvcl9yYW5nZSA9IGNydGNfc3RhdGUtPmxpbWl0 ZWRfY29sb3JfcmFuZ2U7Cj4gIAo+IC0JY3J0Y19zdGF0ZS0+Y3NjX2VuYWJsZSA9Cj4gLQkJY3J0 Y19zdGF0ZS0+b3V0cHV0X2Zvcm1hdCAhPSBJTlRFTF9PVVRQVVRfRk9STUFUX1JHQiB8fAo+IC0J CWNydGNfc3RhdGUtPmJhc2UuY3RtIHx8IGxpbWl0ZWRfY29sb3JfcmFuZ2U7Cj4gKwljcnRjX3N0 YXRlLT5jc2NfZW5hYmxlID0gY3J0Y19zdGF0ZS0+YmFzZS5jdG0gfHwgbGltaXRlZF9jb2xvcl9y YW5nZTsKPiArCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpIDwgMTEpCj4gKwkJY3J0Y19zdGF0ZS0+ Y3NjX2VuYWJsZSB8PQo+ICsJCQljcnRjX3N0YXRlLT5vdXRwdXRfZm9ybWF0ICE9IElOVEVMX09V VFBVVF9GT1JNQVRfUkdCOwo+ICAKPiAgCXJldCA9IGludGVsX2NvbG9yX2FkZF9hZmZlY3RlZF9w bGFuZXMoY3J0Y19zdGF0ZSk7Cj4gIAlpZiAocmV0KQo+IEBAIC04MjIsNiArODIzLDE1IEBAIGlu dCBpbnRlbF9jb2xvcl9jaGVjayhzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkK PiAgCQkJY3J0Y19zdGF0ZS0+Y3NjX21vZGUgfD0gSUNMX09VVFBVVF9DU0NfRU5BQkxFOwo+ICAK PiAgCQljcnRjX3N0YXRlLT5jc2NfbW9kZSB8PSBJQ0xfQ1NDX0VOQUJMRTsKPiArCX0gZWxzZSBp ZiAoY3J0Y19zdGF0ZS0+b3V0cHV0X2Zvcm1hdCAhPSBJTlRFTF9PVVRQVVRfRk9STUFUX1JHQiAm Jgo+ICsJCSAgIGNydGNfc3RhdGUtPmJhc2UuY3RtKSB7Cj4gKwkJLyoKPiArCQkgKiBUaGVyZSBp cyBvbmx5IG9uZSBwaXBlIENTQyB1bml0IHBlciBwaXBlIG9uIHByZS1nZW4xMSwgYW5kCj4gKwkJ ICogd2UgbmVlZCB0aGF0IGZvciBvdXRwdXQgY29udmVyc2lvbiBmcm9tIFJHQi0+WUNCQ1IuIFNv IGlmCj4gKwkJICogQ1RNIGlzIGFscmVhZHkgYXBwbGllZCB3ZSBjYW4ndCBzdXBwb3J0IFlDQkNS IG91dHB1dC4KPiArCQkgKi8KPiArCQlEUk1fREVCVUdfS01TKCJZQ0JDUjQyMCBhbmQgQ1RNIHRv Z2V0aGVyIGFyZSBub3QgcG9zc2libGVcbiIpOwo+ICsJCXJldHVybiAtRUlOVkFMOwoKQlRXIHdl IGhhdmUgcXVpdGUgYSBmZXcgaWxsZWdhbCBjb21iaW5hdGlvbnMgd2UncmUgbm90IGN1cnJlbnRs eQpjYXRjaGluZy4gSSBoYWNrZWQgdG9nZXRoZXIgc29tZSBjaGVja3MgZm9yIHRoZW0gaGVyZToK aHR0cHM6Ly9naXRodWIuY29tL3ZzeXJqYWxhL2xpbnV4L2NvbW1pdC8wYmM1NWFlZjA1NDg5YTdl NzgyYmMxNGI3ZDUwNzBlZWE1MmNlNWVhCmFuZCB0aGVuIEknbSBsaWZ0aW5nIHNvbWUgb2YgdGhv c2UgcmVzdHJpY3Rpb25zIGZvciBwcmUtZ2xrIGhlcmUKaHR0cHM6Ly9naXRodWIuY29tL3ZzeXJq YWxhL2xpbnV4L2NvbW1pdC84ZGI5MjllZTgxMDRjMWVlNjQwMTU3ZDRlYThiZTE1ZWEyNzQ1MWM1 CgpTYWRseSBvbiBnbGsgbG9zdCB0aGUgZmxleGliaWxpdHkgdG8gcmVvcmRlciB0aGUgY3NjIHZz LiBhIHNpbmdsZSBMVVQuCkkgdGhpbmsgd2hhdCB3ZSBuZWVkIHRvIGRvIHRoZXJlIGlzIHRvIHVz ZSB0aGUgZ2FtbWEgTFVUIHRvIGRvIHRoZQpsaW1pdGVkIHJhbmdlIGNvbXByZXNzaW9uLCBhbmQg Zm9yIHRoZSBZQ2JDciBjYXNlIHdlIG1pZ2h0IGp1c3QgaGF2ZQp0byBsb2FkIHRoZSBzb2Z0d2Fy ZSBnYW1tYSBMVVQgaW50byB0aGUgaHcgZGVnYW1tYSBMVVQgYXMgYmVzdCB3ZSBjYW4uCk90aGVy d2lzZSB0aGUgdXNlciBtYXkganVzdCBnZXQgYSB0b3RhbGx5IHVuZXhwZWN0ZWQgZmFpbCB3aGVu IHdlCmF1dG9tYWdpY2FsbHkgZGVjaWRlIHRoYXQgbGltaXRlZCByYW5nZS9ZQ2JDciBvdXRwdXQg aXMgcmVxdWlyZWQuCgo+ICAJfQo+ICAKPiAgCXJldHVybiAwOwo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMKPiBpbmRleCBhZmEyMWRhYWFlNTEuLjgxYmZkYmQ5OTA5MiAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtNjg1NSwxOCArNjg1NSw2IEBA IHN0YXRpYyBpbnQgaW50ZWxfY3J0Y19jb21wdXRlX2NvbmZpZyhzdHJ1Y3QgaW50ZWxfY3J0YyAq Y3J0YywKPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiAgCX0KPiAgCj4gLQlpZiAoKHBpcGVfY29uZmln LT5vdXRwdXRfZm9ybWF0ID09IElOVEVMX09VVFBVVF9GT1JNQVRfWUNCQ1I0MjAgfHwKPiAtCSAg ICAgcGlwZV9jb25maWctPm91dHB1dF9mb3JtYXQgPT0gSU5URUxfT1VUUFVUX0ZPUk1BVF9ZQ0JD UjQ0NCkgJiYKPiAtCSAgICAgcGlwZV9jb25maWctPmJhc2UuY3RtKSB7Cj4gLQkJLyoKPiAtCQkg KiBUaGVyZSBpcyBvbmx5IG9uZSBwaXBlIENTQyB1bml0IHBlciBwaXBlLCBhbmQgd2UgbmVlZCB0 aGF0Cj4gLQkJICogZm9yIG91dHB1dCBjb252ZXJzaW9uIGZyb20gUkdCLT5ZQ0JDUi4gU28gaWYg Q1RNIGlzIGFscmVhZHkKPiAtCQkgKiBhcHBsaWVkIHdlIGNhbid0IHN1cHBvcnQgWUNCQ1I0MjAg b3V0cHV0Lgo+IC0JCSAqLwo+IC0JCURSTV9ERUJVR19LTVMoIllDQkNSNDIwIGFuZCBDVE0gdG9n ZXRoZXIgYXJlIG5vdCBwb3NzaWJsZVxuIik7Cj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4gLQl9Cj4g LQo+ICAJLyoKPiAgCSAqIFBpcGUgaG9yaXpvbnRhbCBzaXplIG11c3QgYmUgZXZlbiBpbjoKPiAg CSAqIC0gRFZPIGdhbmdlZCBtb2RlCj4gLS0gCj4gMi4xNC41CgotLSAKVmlsbGUgU3lyasOkbMOk CkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==