All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: saumah <saumah@gmail.com>
Cc: morris_ku@sunix.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] 8250_pci.c change for fix hanging problem.
Date: Tue, 19 Feb 2019 10:23:28 +0100	[thread overview]
Message-ID: <20190219092328.GA30490@kroah.com> (raw)
In-Reply-To: <20190219085031.3776-1-saumah@gmail.com>

On Tue, Feb 19, 2019 at 04:50:31PM +0800, saumah wrote:
> 8250_pci.c change for fix hanging problem while suspend machine. 8250_pci.c support the same vendor id and device id definition as sunix multi-I/O card driver, when the sunix multi-io borad driver is installed,there are two drivers to support the same sunix multi-io card,it will cause operation error.
> 
> Signed-off-by: saumah <saumah@gmail.com>
> ---
>  8250_pci.c | 163 +----------------------------------------------------
>  1 file changed, 1 insertion(+), 162 deletions(-)

You can't just delete a ton of code, you just broke a bunch of existing
devices out there :(

Also, the patch is at the wrong level of the kernel source tree, you
need to use your full name for author and signed-off-by, you forgot to
 cc: the linux-serial mailing list, and you need to wrap your changelog
text properly.

Please look at Documentation/SubmittingPatches for how to do all of this
and then redo and resend the patch.

thanks,

greg k-h

      reply	other threads:[~2019-02-19  9:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-19  8:50 [PATCH V2] 8250_pci.c change for fix hanging problem saumah
2019-02-19  9:23 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190219092328.GA30490@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=morris_ku@sunix.com \
    --cc=saumah@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.