From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+ From: Stanislaw Gruszka Message-Id: <20190219105941.GB22999@redhat.com> Date: Tue, 19 Feb 2019 11:59:41 +0100 To: Stefan Wahren Cc: Lorenzo Bianconi , Alan Stern , Felix Fietkau , Doug Anderson , Minas Harutyunyan , USB list , linux-wireless List-ID: T24gTW9uLCBGZWIgMTgsIDIwMTkgYXQgMTE6MTk6NDBQTSArMDEwMCwgU3RlZmFuIFdhaHJlbiB3 cm90ZToKPiBIaSwKPiAKPiA+IFN0YW5pc2xhdyBHcnVzemthIDxzZ3J1c3prYUByZWRoYXQuY29t PiBoYXQgYW0gMTguIEZlYnJ1YXIgMjAxOSB1bSAxNDo1MiBnZXNjaHJpZWJlbjoKPiA+IAo+ID4g Cj4gPiBPbiBTYXQsIEZlYiAxNiwgMjAxOSBhdCAwODoxNzowN1BNICswMTAwLCBTdGVmYW4gV2Fo cmVuIHdyb3RlOgo+ID4gPiB0aGlzIGlzIGEgbWlzdW5kZXJzdGFuZGluZy4gVGhlIHdhcm5pbmcg aXMgYWJvdXQgbWVtb3J5IGFsaWdubWVudCB0byAzMiBiaXQgYWRkcmVzc2VzLCBub3QgYWJvdXQg cGFnZSBhbGlnbm1lbnQuIFRoaXMgaXMgYSB0eXBpY2FsIEFSTSByZXN0cmljdGlvbi4gTWF5YmUg d2UgbmVlZCB0byBtYWtlIHN1cmUgaW4gbXQ3NiB0aGF0IHRoZSBETUEgYnVmZmVyIG5lZWRzIHRv IGJlIGFsaWduZWQuIEJ1dCBpdCdzIGFsc28gcG9zc2libGUgdGhhdCB0aGUgd2FybmluZyBpc24n dCB0aGUgcm9vdCBjYXVzZSBvZiBvdXIgcHJvYmxlbS4KPiA+ID4gCj4gPiAKPiA+IEkgc2VlLCBp dCBuZWVkcyA0IGJ5dGVzIGFsaWdubWVudCAuIFRoZXJlIGlzIGFscmVhZHkgZHdjMiBjb2RlIGNo ZWNrcwo+ID4gdGhhdCBhbmQgYWxsb2NhdGUgbmV3IGJ1ZmZlciBpZiB0aGUgYWxpZ25tZW50IGlz IG5vdCByaWdodDoKPiA+IGR3YzJfYWxsb2NfZG1hX2FsaWduZWRfYnVmZmVyKCksIGJ1dCBpdCBk b2VzIG5vdGhpbmcgaWYgdXJiLT5zZwo+ID4gaXMgbm90IE5VTEwuIEkgdGhvdWdodCBtdDc2dXNi IGFscmVhZHkgcHJvdmlkZSBhbGlnbmVkIGJ1ZmZlcnMsIGJ1dAo+ID4gbG9va3MgaXQgZG9lcyBu b3QgZm9yIG9uZSBUWCBzcGVjaWFsIGNhc2UsIHdoaWNoIGFyZSBQUk9CRSBSRVFVRVNUCj4gPiBm cmFtZXMuIE90aGVyIGZyYW1lcyBhcmUgYWxpZ25lZCBieSBpbnNlcnRpbmcgTDIgaGVhZGVyIHBh ZC4gT25lCj4gPiBzb2x1dGlvbiBmb3IgdGhpcyB3b3VsZCBiZSBqdXN0IHN1Ym1pdCB1cmIgd2l0 aCAgTlVMTCBzZyAoc2FtZSBhcwo+ID4gTG9yZW56bydzIHBhdGNoZXMgZG8sIGJ1dCBzdGlsbCBh bGxvY2F0aW5nIGJ1ZmZlcnMgdmlhIGJ1Zi0+c2cpLAo+ID4gYnV0IEkgdGhpbmssIHlvdSBoYXZl IHJpZ2h0LCB3ZSBzaG91bGQgcHJvdmlkZSA0IGJ5dGVzIGFsaWduZWQgYnVmZmVycwo+ID4gYnkg ZGVmYXVsdCBhcyBvdGhlciBETUEgaGFyZHdhcmUgbWF5IHJlcXVpcmUgdGhhdC4gSSdtIGF0dGFj aGluZyB5ZXQKPiA+IGFub3RoZXIgcGF0Y2ggdG8gdGVzdCwgd2hpY2ggZml4IHVwIGFsaWdubWVu dCBmb3IgUFJPQkUgUkVRVUVTVCBmcmFtZXMuCj4gPiAKPiA+ID4gPiBBdHRhY2hlZCBwYXRjaCBz aG91bGQgZml4IHRoaXMsIHBsZXNlIHRlc3QsIHRoYW5rcyBpbiBhZHZhbmNlLgo+IAo+IGkgc2F3 IEZlbGl4IGRlY2lkZWQgdG8gdXNlIExvcmVuem8ncyBhcHByb2FjaC4KPiAKPiBUaGUgcGF0Y2hl cyAxLDMsNSBhcHBsaWVkIG9uIHRvZGF5J3MgbmV4dCBmaXhlZCBvbmx5IHRoZSB3YXJuaW5nIGFu ZCB3aWZpIGlzIHN0aWxsIGJyb2tlbiAoYXV0aGVudGljYXRpb24gdGltZW91dCkuCj4gCj4gSGVy ZSBhcmUgdGhlIGxvZ3MgZm9yIG11bHRpX3Y3X2RlZmNvbmZpZzoKPiBodHRwczovL2dpc3QuZ2l0 aHViLmNvbS9sYXRlZ29vZGJ5ZS8wYTdjNWNlYTdkYmYyNWQwZGU3OTQ0YzA1ZDIyOWQ3OQoKSXQg d291bGQgYmUgaW50ZXJlc3Rpbmcgd2h5IHVyYi0+bnVtX3NncyA9IDAgJiB1cmItPnNnIGNhdXNl CnRoZSB0cm91Ymxlcy4gVGhpcyBpcyBob3cgdXNiX3NnX2luaXQoKSBzdWJtaXQgdXJicyBmb3Ig c2dfdGFibGVzaXplID0gMApjb250cm9sbGVycy4gU28gZWl0aGVyIGFyZSB0aGVyZSBhcmUgc29t ZSByZXF1aXJlbWVudCBvbiB1cmItPnNnCm1hcHBlZCB2aWEgZG1hX21hcF9wYWdlKCkgKHdoaWNo IG10NzZ1c2IgZG9lcyBub3QgbWVldCkgbm90IG5lZWRlZApmb3IgdXJiLT50cmFuc2Zlcl9idWZm ZXIgbWFwcGVkIHZpYSBkbWFfbWFwX3NpbmdsZSgpIG9yIHRoZXJlCmlzIHNvbWV0aGluZyB3cm9u ZyBpbiBkd2MyIHdpdGggc2cgYW5kIHRoaXMgZHJpdmVyIHdpbGwgbm90Cndvcmsgd2l0aCB1cmJf c2dfaW5pdCgpIGFzIHdlbGwuIEkgZG9uJ3QgaGF2ZSBoYXJkd2FyZSB0byBpbnZlc3RpZ2F0ZQp0 aGlzIGFuZCBkb24ndCB3YW50IHRvIGJvdGhlciB5b3Ugd2l0aCBtb3JlIHBhdGNoZXMuCgo+ID4g PiBBbnl3YXkgaSB0ZXN0ZWQgdGhlIGZvbGxvd2luZyBwYXRjaCBjb21iaW5hdGlvbnMgYWdhaW5z dCBuZXh0IHdpdGggdGhlIHNhbWUgcmVzdWx0cyBhcyAxLDIsMyAobm8gd2lmaSwgYWxpZ25tZW50 IHdhcm5pbmcpOgo+ID4gPiAxLDMKPiA+ID4gMSwyLDMsNAo+ID4gCj4gPiBJIG5vdGljZWQgb24g bXkgc2V0dXAgdGhhdCBwYXRjaCA0IGNhbiBjYXVzZSB0cm91YmxlcywgYnV0IHN0aWxsCj4gPiBk ZXZpY2UgaXMgd29ya2FibGUgaGVyZSBvbiBteSBQQyBtYWNoaW5lcy4KPiA+IAo+ID4gPiA+ID4g QnR3IGkgY2FuIGNvbmZpcm0gYSByZWdyZXNzaW9uIHdhcyBpbnRyb2R1Y2VkIGFmdGVyIDQuMTks IGJlY2F1c2UgaW4gNC4xOSB0aGVyZSB3YXMgbm8gZmlybXdhcmUgdGltZW91dCBidXQgZXZlbiBu byB3b3JraW5nIHdpZmk6Cj4gPiA+ID4gCj4gPiA+ID4gWW91IG1lbnQgJ25vIHdvcmtpbmcgd2lm aScgb3IgJ3dvcmtpbmcgd2lmaSc/Cj4gPiA+IAo+ID4gPiBXaWZpIGlzIGJyb2tlbiBpbiA0LjE5 LCA0LjIwLCA1LjAgYW5kIG5leHQuIEl0IG9ubHkgd29ya2VkIHdpdGggTG9yZW56bydzIFNHIGF2 b2lkIHBhdGNoZXMgc28gZmFyLiBCdHcgdGhlIHJlZ3Jlc3Npb24gKGZpcm13YXJlIHRpbWVvdXQp IHN0YXJ0ZWQgaW4gNC4yMC4gSSBhbHNvIHRlc3RlZCBpdCB0b2RheS4KPiA+IAo+ID4gVGhhdCBz b21ld2hhdCBzdHJhbmdlIGJlY2F1c2UgNC4xOSBtdDc2eDB1IGRvZXMgbm90IHVzZSBTRy4KPiA+ IE9uIDQuMTkgdGhlcmUgaXMgcGh5IGNhbGlicmF0aW9uIGJ1ZyBmaXhlZCBpbiA0LjE5LjU6Cj4g Cj4gU29ycnkgZm9yIGJlaW5nIGlucHJlY2lzZS4gSSB3YXMgdGFsa2luZyBhYm91dCB0aGUgYnJh bmNoZXMgbm90IHRoZSBleGFjdCB0YWdzLiBJIHRlc3RlZCA0LjE5LjIzIHdpdGhvdXQgbHVjay4K CkluIGdpdGh1YiBsaW5rIHlvdSBwcm92aWRlZCBzb21lb25lIHJlcG9ydCBtdDc2eDB1IHdvcmtp bmcgb24gNC4xOSB3aXRoCmR3Y19vdGcgd2l0aCBkaXNhYmxlZCBGSVEgaXJxLCBzbyBwZXJoYXBz IHRoaXMgaXMgZHVlIHRvIGJ1ZyBpbiBkd2MyCmZpeGVkIGluIC1uZXh0IGJ1dCBub3QgYmFja3Bv cnRlZCB0byA0LjE5LgoKPiBNYW55IHRoYW5rcyBhbnl3YXkKClRoYW5rcyBmb3IgdGVzdGluZyEK ClN0YW5pc2xhdwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EE11C43381 for ; Tue, 19 Feb 2019 10:59:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 40A6C206BB for ; Tue, 19 Feb 2019 10:59:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727464AbfBSK7u (ORCPT ); Tue, 19 Feb 2019 05:59:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55334 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725763AbfBSK7u (ORCPT ); Tue, 19 Feb 2019 05:59:50 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 76CCC87621; Tue, 19 Feb 2019 10:59:49 +0000 (UTC) Received: from localhost (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTP id E2D4661B81; Tue, 19 Feb 2019 10:59:43 +0000 (UTC) Date: Tue, 19 Feb 2019 11:59:41 +0100 From: Stanislaw Gruszka To: Stefan Wahren Cc: Lorenzo Bianconi , Alan Stern , Felix Fietkau , Doug Anderson , Minas Harutyunyan , USB list , linux-wireless Subject: Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+ Message-ID: <20190219105941.GB22999@redhat.com> References: <20190212093035.GB12906@redhat.com> <404607590.373282.1550126997144@email.ionos.de> <20190214092530.GA17273@redhat.com> <878a7160-2e91-d057-6d27-c6b9d85f700e@i2se.com> <20190215071226.GA2372@redhat.com> <1411983628.668277.1550315118443@email.ionos.de> <20190216140739.GA2236@redhat.com> <2009016263.528260.1550344627996@email.ionos.de> <20190218135247.GA9602@redhat.com> <1181760295.588129.1550528380134@email.ionos.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1181760295.588129.1550528380134@email.ionos.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 19 Feb 2019 10:59:49 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, Feb 18, 2019 at 11:19:40PM +0100, Stefan Wahren wrote: > Hi, > > > Stanislaw Gruszka hat am 18. Februar 2019 um 14:52 geschrieben: > > > > > > On Sat, Feb 16, 2019 at 08:17:07PM +0100, Stefan Wahren wrote: > > > this is a misunderstanding. The warning is about memory alignment to 32 bit addresses, not about page alignment. This is a typical ARM restriction. Maybe we need to make sure in mt76 that the DMA buffer needs to be aligned. But it's also possible that the warning isn't the root cause of our problem. > > > > > > > I see, it needs 4 bytes alignment . There is already dwc2 code checks > > that and allocate new buffer if the alignment is not right: > > dwc2_alloc_dma_aligned_buffer(), but it does nothing if urb->sg > > is not NULL. I thought mt76usb already provide aligned buffers, but > > looks it does not for one TX special case, which are PROBE REQUEST > > frames. Other frames are aligned by inserting L2 header pad. One > > solution for this would be just submit urb with NULL sg (same as > > Lorenzo's patches do, but still allocating buffers via buf->sg), > > but I think, you have right, we should provide 4 bytes aligned buffers > > by default as other DMA hardware may require that. I'm attaching yet > > another patch to test, which fix up alignment for PROBE REQUEST frames. > > > > > > Attached patch should fix this, plese test, thanks in advance. > > i saw Felix decided to use Lorenzo's approach. > > The patches 1,3,5 applied on today's next fixed only the warning and wifi is still broken (authentication timeout). > > Here are the logs for multi_v7_defconfig: > https://gist.github.com/lategoodbye/0a7c5cea7dbf25d0de7944c05d229d79 It would be interesting why urb->num_sgs = 0 & urb->sg cause the troubles. This is how usb_sg_init() submit urbs for sg_tablesize = 0 controllers. So either are there are some requirement on urb->sg mapped via dma_map_page() (which mt76usb does not meet) not needed for urb->transfer_buffer mapped via dma_map_single() or there is something wrong in dwc2 with sg and this driver will not work with urb_sg_init() as well. I don't have hardware to investigate this and don't want to bother you with more patches. > > > Anyway i tested the following patch combinations against next with the same results as 1,2,3 (no wifi, alignment warning): > > > 1,3 > > > 1,2,3,4 > > > > I noticed on my setup that patch 4 can cause troubles, but still > > device is workable here on my PC machines. > > > > > > > Btw i can confirm a regression was introduced after 4.19, because in 4.19 there was no firmware timeout but even no working wifi: > > > > > > > > You ment 'no working wifi' or 'working wifi'? > > > > > > Wifi is broken in 4.19, 4.20, 5.0 and next. It only worked with Lorenzo's SG avoid patches so far. Btw the regression (firmware timeout) started in 4.20. I also tested it today. > > > > That somewhat strange because 4.19 mt76x0u does not use SG. > > On 4.19 there is phy calibration bug fixed in 4.19.5: > > Sorry for being inprecise. I was talking about the branches not the exact tags. I tested 4.19.23 without luck. In github link you provided someone report mt76x0u working on 4.19 with dwc_otg with disabled FIQ irq, so perhaps this is due to bug in dwc2 fixed in -next but not backported to 4.19. > Many thanks anyway Thanks for testing! Stanislaw