From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:59045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gw3N5-0000Lh-Um for qemu-devel@nongnu.org; Tue, 19 Feb 2019 06:15:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gw3Mt-0004AI-T5 for qemu-devel@nongnu.org; Tue, 19 Feb 2019 06:15:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54784) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gw3Mt-00049V-Jp for qemu-devel@nongnu.org; Tue, 19 Feb 2019 06:15:19 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8688013985C for ; Tue, 19 Feb 2019 11:15:18 +0000 (UTC) Date: Tue, 19 Feb 2019 11:15:05 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20190219111505.GD7154@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20190219101510.9356-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190219101510.9356-1-kraxel@redhat.com> Subject: Re: [Qemu-devel] [PATCH] audio: don't use alsa by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, david@redhat.com On Tue, Feb 19, 2019 at 11:15:10AM +0100, Gerd Hoffmann wrote: > In case no sound hardware is present the driver initializes > successfully and throws errors later on, i.e. effectively the > automatic probing doesn't work. So the driver should not be > used by default (until that is fixed). Drop the can_be_default > flag. > > Explicitly picking the alsa driver (using QEMU_AUDIO_DRV=alsa > environment variable) will continue to work. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1816052 > Signed-off-by: Gerd Hoffmann > --- > audio/alsaaudio.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c > index 635be73bf4..1cc570e30b 100644 > --- a/audio/alsaaudio.c > +++ b/audio/alsaaudio.c > @@ -1218,7 +1218,6 @@ static struct audio_driver alsa_audio_driver = { > .init = alsa_audio_init, > .fini = alsa_audio_fini, > .pcm_ops = &alsa_pcm_ops, > - .can_be_default = 1, > .max_voices_out = INT_MAX, > .max_voices_in = INT_MAX, > .voice_size_out = sizeof (ALSAVoiceOut), This fixes the problem with alsa, but then we get exactly the same problem with sdl audio iniitalizing but then not working. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|