All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kalle Valo <kvalo@codeaurora.org>, kbuild@01.org, kbuild-all@01.org
Cc: "Arend van Spriel" <arend.vanspriel@broadcom.com>,
	"Rafał Miłecki" <zajec5@gmail.com>,
	linux-wireless@vger.kernel.org,
	brcm80211-dev-list.pdl@broadcom.com,
	"Rafał Miłecki" <rafal@milecki.pl>,
	brcm80211-dev-list@cypress.com
Subject: Re: [kbuild] [PATCH] brcmfmac: use bphy_err() in all wiphy-related code
Date: Tue, 19 Feb 2019 14:28:53 +0300	[thread overview]
Message-ID: <20190219112853.GV2304@kadam> (raw)
In-Reply-To: <20190215103803.GF2304@kadam>

On Fri, Feb 15, 2019 at 01:38:03PM +0300, Dan Carpenter wrote:
> On Fri, Feb 15, 2019 at 12:04:31PM +0200, Kalle Valo wrote:
> > > 3e0a97e1 drivers/net/wireless/brcm80211/brcmfmac/fweh.c Arend van
> > > Spriel 2012-11-14 108 void *data)
> > > 3e0a97e1 drivers/net/wireless/brcm80211/brcmfmac/fweh.c Arend van
> > 
> > This report is very hard to read as the lines seem to be wrapped.
> > 
> 
> I feel like removing the filenames would make the reports more legible.
> We can get that information from the git hash if we really need it.
> 
> Maybe just put the filename at the start:
> 
> drivers/net/wireless/brcm80211/brcmfmac/fweh.c
> 5c36b99a Arend van Spriel 2012-11-14 104
> 3e0a97e1 Arend van Spriel 2012-11-14 105 static int brcmf_fweh_call_event_handler(struct brcmf_if *ifp,

These emails are actually from the Intel zero day devs.  I just hit
forward on them.  They have silently implemented the formatting changes
we asked for.

:)

Thanks so much!

regards,
dan carpenter


      parent reply	other threads:[~2019-02-19 11:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-13 11:26 [PATCH] brcmfmac: use bphy_err() in all wiphy-related code Rafał Miłecki
2019-02-14 12:38 ` Arend Van Spriel
2019-02-14 12:46   ` Rafał Miłecki
2019-02-14 12:57 ` [PATCH V2] " Rafał Miłecki
2019-02-15  6:43   ` [PATCH V3] " Rafał Miłecki
2019-02-15  8:37     ` Rafał Miłecki
     [not found]       ` <5cb6383e-2e4c-8586-61a2-3f47de2743dd@broadcom.com>
2019-02-15  9:47         ` Rafał Miłecki
2019-02-15 10:10     ` Rafał Miłecki
2019-02-15 10:37       ` Kalle Valo
2019-02-19 22:42     ` [PATCH V4] " Rafał Miłecki
2019-02-20 17:54       ` Kalle Valo
2019-02-15  6:16 ` [PATCH] " Dan Carpenter
2019-02-15 10:04   ` Kalle Valo
2019-02-15 10:08     ` Rafał Miłecki
2019-02-15 10:44       ` Kalle Valo
2019-02-15 10:38     ` Dan Carpenter
2019-02-15 10:40       ` Arend Van Spriel
2019-02-19 11:28       ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190219112853.GV2304@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=arend.vanspriel@broadcom.com \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211-dev-list@cypress.com \
    --cc=kbuild-all@01.org \
    --cc=kbuild@01.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rafal@milecki.pl \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.