From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v4,2/6] usb:common Separated decoding functions from dwc3 driver. From: Greg Kroah-Hartman Message-Id: <20190219131402.GB20719@kroah.com> Date: Tue, 19 Feb 2019 14:14:02 +0100 To: Pawel Laszczak Cc: devicetree@vger.kernel.org, felipe.balbi@linux.intel.com, mark.rutland@arm.com, linux-usb@vger.kernel.org, hdegoede@redhat.com, heikki.krogerus@linux.intel.com, andy.shevchenko@gmail.com, robh+dt@kernel.org, rogerq@ti.com, linux-kernel@vger.kernel.org, jbergsagel@ti.com, nsekhar@ti.com, nm@ti.com, sureshp@cadence.com, peter.chen@nxp.com, kurahul@cadence.com List-ID: T24gVGh1LCBGZWIgMTQsIDIwMTkgYXQgMDc6NDU6MTBQTSArMDAwMCwgUGF3ZWwgTGFzemN6YWsg d3JvdGU6Cj4gUGF0Y2ggbW92ZXMgc29tZSBkZWNvZGluZyBmdW5jdGlvbnMgZnJvbSBkcml2ZXIv dXNiL2R3YzMvZGVidWcuaCBkcml2ZXIKPiB0byBkcml2ZXIvdXNiL2NvbW1vbi9kZWJ1Zy5jIGZp bGUuIFRoZXNlIG1vdmVkIGZ1bmN0aW9ucyBpbmNsdWRlOgo+ICAgICBkd2MzX2RlY29kZV9nZXRf c3RhdHVzCj4gICAgIGR3YzNfZGVjb2RlX3NldF9jbGVhcl9mZWF0dXJlCj4gICAgIGR3YzNfZGVj b2RlX3NldF9hZGRyZXNzCj4gICAgIGR3YzNfZGVjb2RlX2dldF9zZXRfZGVzY3JpcHRvcgo+ICAg ICBkd2MzX2RlY29kZV9nZXRfY29uZmlndXJhdGlvbgo+ICAgICBkd2MzX2RlY29kZV9zZXRfY29u ZmlndXJhdGlvbgo+ICAgICBkd2MzX2RlY29kZV9nZXRfaW50Zgo+ICAgICBkd2MzX2RlY29kZV9z ZXRfaW50Zgo+ICAgICBkd2MzX2RlY29kZV9zeW5jaF9mcmFtZQo+ICAgICBkd2MzX2RlY29kZV9z ZXRfc2VsCj4gICAgIGR3YzNfZGVjb2RlX3NldF9pc29jaF9kZWxheQo+ICAgICBkd2MzX2RlY29k ZV9jdHJsCj4gCj4gVGhlc2UgZnVuY3Rpb25zIGFyZSB1c2VkIGFsc28gaW4gaW5yb2R1Y2VkIGNk bnMzIGRyaXZlci4KPiAKPiBBbGwgZnVuY3Rpb25zIHByZWZpeGVzIHdlcmUgY2hhbmdlZCBmcm9t IGR3YzMgdG8gdXNiLgo+IEFsc28sIGZ1bmN0aW9uJ3MgcGFyYW1ldGVycyBoYXMgYmVlbiBleHRl bmRlZCBhY2NvcmRpbmcgdG8gdGhlIG5hbWUKPiBvZiBmaWVsZHMgaW4gc3RhbmRhcmQgU0VUVVAg cGFja2V0Lgo+IEFkZGl0aW9uYWxseSwgcGF0Y2ggYWRkcyB1c2JfZGVjb2RlX2N0cmwgZnVuY3Rp b24gdG8KPiBpbmNsdWRlL2xpbnV4L3VzYi9jaDkuaCBmaWxlLgo+IAo+IFNpZ25lZC1vZmYtYnk6 IFBhd2VsIExhc3pjemFrIDxwYXdlbGxAY2FkZW5jZS5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvdXNi L2NvbW1vbi9NYWtlZmlsZSB8ICAgMiArLQo+ICBkcml2ZXJzL3VzYi9jb21tb24vZGVidWcuYyAg fCAyNzAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIGRyaXZlcnMvdXNi L2R3YzMvZGVidWcuaCAgICB8IDI0OSAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0K PiAgZHJpdmVycy91c2IvZHdjMy90cmFjZS5oICAgIHwgICAyICstCj4gIGluY2x1ZGUvbGludXgv dXNiL2NoOS5oICAgICB8ICAyNSArKysrCj4gIDUgZmlsZXMgY2hhbmdlZCwgMjk3IGluc2VydGlv bnMoKyksIDI1MSBkZWxldGlvbnMoLSkKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvdXNi L2NvbW1vbi9kZWJ1Zy5jCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL2NvbW1vbi9NYWtl ZmlsZSBiL2RyaXZlcnMvdXNiL2NvbW1vbi9NYWtlZmlsZQo+IGluZGV4IGZiNGQ1ZWY0MTY1Yy4u M2QzZDI5NjJlYTRiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdXNiL2NvbW1vbi9NYWtlZmlsZQo+ ICsrKyBiL2RyaXZlcnMvdXNiL2NvbW1vbi9NYWtlZmlsZQo+IEBAIC00LDcgKzQsNyBAQAo+ICAj Cj4gIAo+ICBvYmotJChDT05GSUdfVVNCX0NPTU1PTikJICArPSB1c2ItY29tbW9uLm8KPiAtdXNi LWNvbW1vbi15CQkJICArPSBjb21tb24ubwo+ICt1c2ItY29tbW9uLXkJCQkgICs9IGNvbW1vbi5v IGRlYnVnLm8KCkl0J3MgbmljZSB0byBoYXZlIHRoZXNlIGluIGEgY29tbW9uIHBsYWNlLCBidXQg eW91IGp1c3QgYmxvYXRlZCBhbGwgb2YKdGhlIFVTQi1lbmFibGVkIHN5c3RlbXMgaW4gdGhlIHdv cmxkIGZvciB0aGUgdXNlIG9mIDIgb2RkLWJhbGwgc3lzdGVtCmNvbnRyb2xsZXJzIHRoYXQgYWxt b3N0IG5vIG9uZSBoYXMgOikKClNvLCBhbnkgd2F5IHRvIG9ubHkgcHVsbCBpbiB0aGlzIGZpbGUg aWYgeW91IGFjdHVhbGx5IG5lZWQgdGhlc2UKZnVuY3Rpb25zPwoKdGhhbmtzLAoKZ3JlZyBrLWgK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v4 2/6] usb:common Separated decoding functions from dwc3 driver. Date: Tue, 19 Feb 2019 14:14:02 +0100 Message-ID: <20190219131402.GB20719@kroah.com> References: <1550173514-23573-1-git-send-email-pawell@cadence.com> <1550173514-23573-3-git-send-email-pawell@cadence.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1550173514-23573-3-git-send-email-pawell@cadence.com> Sender: linux-kernel-owner@vger.kernel.org To: Pawel Laszczak Cc: devicetree@vger.kernel.org, felipe.balbi@linux.intel.com, mark.rutland@arm.com, linux-usb@vger.kernel.org, hdegoede@redhat.com, heikki.krogerus@linux.intel.com, andy.shevchenko@gmail.com, robh+dt@kernel.org, rogerq@ti.com, linux-kernel@vger.kernel.org, jbergsagel@ti.com, nsekhar@ti.com, nm@ti.com, sureshp@cadence.com, peter.chen@nxp.com, kurahul@cadence.com List-Id: devicetree@vger.kernel.org On Thu, Feb 14, 2019 at 07:45:10PM +0000, Pawel Laszczak wrote: > Patch moves some decoding functions from driver/usb/dwc3/debug.h driver > to driver/usb/common/debug.c file. These moved functions include: > dwc3_decode_get_status > dwc3_decode_set_clear_feature > dwc3_decode_set_address > dwc3_decode_get_set_descriptor > dwc3_decode_get_configuration > dwc3_decode_set_configuration > dwc3_decode_get_intf > dwc3_decode_set_intf > dwc3_decode_synch_frame > dwc3_decode_set_sel > dwc3_decode_set_isoch_delay > dwc3_decode_ctrl > > These functions are used also in inroduced cdns3 driver. > > All functions prefixes were changed from dwc3 to usb. > Also, function's parameters has been extended according to the name > of fields in standard SETUP packet. > Additionally, patch adds usb_decode_ctrl function to > include/linux/usb/ch9.h file. > > Signed-off-by: Pawel Laszczak > --- > drivers/usb/common/Makefile | 2 +- > drivers/usb/common/debug.c | 270 ++++++++++++++++++++++++++++++++++++ > drivers/usb/dwc3/debug.h | 249 --------------------------------- > drivers/usb/dwc3/trace.h | 2 +- > include/linux/usb/ch9.h | 25 ++++ > 5 files changed, 297 insertions(+), 251 deletions(-) > create mode 100644 drivers/usb/common/debug.c > > diff --git a/drivers/usb/common/Makefile b/drivers/usb/common/Makefile > index fb4d5ef4165c..3d3d2962ea4b 100644 > --- a/drivers/usb/common/Makefile > +++ b/drivers/usb/common/Makefile > @@ -4,7 +4,7 @@ > # > > obj-$(CONFIG_USB_COMMON) += usb-common.o > -usb-common-y += common.o > +usb-common-y += common.o debug.o It's nice to have these in a common place, but you just bloated all of the USB-enabled systems in the world for the use of 2 odd-ball system controllers that almost no one has :) So, any way to only pull in this file if you actually need these functions? thanks, greg k-h