From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org, pkshih@realtek.com,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH 1/8] rtlwifi: Remove CamelCase variables from base code
Date: Tue, 19 Feb 2019 15:04:08 +0000 (UTC) [thread overview]
Message-ID: <20190219150408.1C6D7608CE@smtp.codeaurora.org> (raw)
In-Reply-To: <20190214223644.8035-2-Larry.Finger@lwfinger.net>
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> There are a number of CamelCase variables remaining in the source
> files of modules rtl_pci, rtl_usb, and rtlwifi.
>
> The following checkpatch excettions are also fixed:
>
> for_kalle1/0001-rtlwifi-Remove-CamelCase-variables-from-base-code.patch
> -----------------------------------------------------------------------
> CHECK: Unnecessary parentheses around 'rtlefuse->efuse_map[EFUSE_INIT_MAP][base + i] !=
> rtlefuse->efuse_map[EFUSE_MODIFY_MAP][base + i]'
> #68: FILE: drivers/net/wireless/realtek/rtlwifi/efuse.c:377:
> + if ((rtlefuse->efuse_map[EFUSE_INIT_MAP][base + i] !=
> + rtlefuse->efuse_map[EFUSE_MODIFY_MAP][base + i]) ||
> + (rtlefuse->efuse_map[EFUSE_INIT_MAP][base + i + 1] !=
> + rtlefuse->efuse_map[EFUSE_MODIFY_MAP][base + i +
> 1])) {
>
> CHECK: Unnecessary parentheses around 'rtlefuse->efuse_map[EFUSE_INIT_MAP][base + i + 1] !=
> rtlefuse->efuse_map[EFUSE_MODIFY_MAP][base + i +
> 1]'
> #68: FILE: drivers/net/wireless/realtek/rtlwifi/efuse.c:377:
> + if ((rtlefuse->efuse_map[EFUSE_INIT_MAP][base + i] !=
> + rtlefuse->efuse_map[EFUSE_MODIFY_MAP][base + i]) ||
> + (rtlefuse->efuse_map[EFUSE_INIT_MAP][base + i + 1] !=
> + rtlefuse->efuse_map[EFUSE_MODIFY_MAP][base + i +
> 1])) {
>
> WARNING: line over 80 characters
> #70: FILE: drivers/net/wireless/realtek/rtlwifi/efuse.c:379:
> + (rtlefuse->efuse_map[EFUSE_INIT_MAP][base + i + 1] !=
>
> CHECK: No space is necessary after a cast
> #186: FILE: drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c:396:
> + status->rx_is40mhzpacket = (bool) GET_RX_DESC_BW(pdesc);
>
> CHECK: No space is necessary after a cast
> #208: FILE: drivers/net/wireless/realtek/rtlwifi/rtl8192ce/trx.c:335:
> + stats->rx_is40mhzpacket = (bool) GET_RX_DESC_BW(pdesc);
>
> CHECK: No space is necessary after a cast
> #243: FILE: drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c:301:
> + stats->rx_is40mhzpacket = (bool) GET_RX_DESC_BW(pdesc);
>
> CHECK: No space is necessary after a cast
> #252: FILE: drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c:368:
> + stats.rx_is40mhzpacket = (bool) GET_RX_DESC_BW(rxdesc);
>
> CHECK: No space is necessary after a cast
> #265: FILE: drivers/net/wireless/realtek/rtlwifi/rtl8192de/trx.c:475:
> + stats->rx_is40mhzpacket = (bool) GET_RX_DESC_BW(pdesc);
>
> WARNING: Unnecessary space before function pointer arguments
> #455: FILE: drivers/net/wireless/realtek/rtlwifi/wifi.h:1462:
> + void (*writen_sync) (struct rtl_priv *rtlpriv, u32 addr, void *buf,
>
> WARNING: Unnecessary space before function pointer arguments
> #483: FILE: drivers/net/wireless/realtek/rtlwifi/wifi.h:2257:
> + void (*fill_fake_txdesc) (struct ieee80211_hw *hw, u8 *pdesc,
>
> Note that not all checkpatch exceptions are addressed. Those will be
> handled in later patches.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
8 patches applied to wireless-drivers-next.git, thanks.
e703c5dd2d69 rtlwifi: Remove CamelCase variables from base code
2171def56daf rtlwifi: btcoexist: Remove CamelCase variable
d420110635ad rtlwifi: rtl8188ee: Remove CamelCase variable
ff9704538e6d rtlwifi: rtl8192{c,u}: Remove CamelCase variables
b83faeda028b rtlwifi: rtl8188de: Remove CamelCase variables
2a83ad1fe330 rtlwifi: rtl8192se: Remove CamelCase variables
92a1aa25c782 rtlwifi: rtl8723{be,ae}: Remove CamelCase variables
9c66a7e5d39c rtlwifi: rtl8821ae: Remove CamelCase variables
--
https://patchwork.kernel.org/patch/10813947/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-02-19 15:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 22:36 [PATCH 0/8] rtlwifi: Remove CamelCase variables from all drivers Larry Finger
2019-02-14 22:36 ` [PATCH 1/8] rtlwifi: Remove CamelCase variables from base code Larry Finger
2019-02-19 15:04 ` Kalle Valo [this message]
2019-02-14 22:36 ` [PATCH 2/8] rtlwifi: btcoexist: Remove CamelCase variable Larry Finger
2019-02-14 22:36 ` [PATCH 3/8] rtlwifi: rtl8188ee: " Larry Finger
2019-02-14 22:36 ` [PATCH 4/8] rtlwifi: rtl8192{c,u}: Remove CamelCase variables Larry Finger
2019-02-14 22:36 ` [PATCH 5/8] rtlwifi: rtl8188de: " Larry Finger
2019-02-14 22:36 ` [PATCH 6/8] rtlwifi: rtl8192se: " Larry Finger
2019-02-14 22:36 ` [PATCH 7/8] rtlwifi: rtl8723{be,ae}: " Larry Finger
2019-02-14 22:36 ` [PATCH 8/8] rtlwifi: rtl8821ae: " Larry Finger
2019-02-15 10:54 ` [PATCH 0/8] rtlwifi: Remove CamelCase variables from all drivers Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219150408.1C6D7608CE@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.