From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 19 Feb 2019 16:13:31 -0000 Received: from mga07.intel.com ([134.134.136.100]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gw81R-0001WK-5Z for speck@linutronix.de; Tue, 19 Feb 2019 17:13:29 +0100 Date: Tue, 19 Feb 2019 08:13:25 -0800 From: Andi Kleen Subject: [MODERATED] Re: [patch 5/8] MDS basics 5 Message-ID: <20190219161325.GV16922@tassilo.jf.intel.com> References: <20190219124406.449727187@linutronix.de> <20190219125346.227346514@linutronix.de> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Tue, Feb 19, 2019 at 04:07:11PM +0100, speck for Thomas Gleixner wrote: > On Tue, 19 Feb 2019, speck for Thomas Gleixner wrote: > > +/* Update the static key controlling the MDS CPU buffer clear in idle */ > > +static void update_mds_branch_idle(void) > > +{ > > + if (sched_smt_active()) > > + static_branch_enable(&user_mds_clear_cpu_buffers); > > + else > > + static_branch_disable(&user_mds_clear_cpu_buffers); > > Those obviously need s/user/idle/ Please don't post untested crap like this. It would be really bad if someone applied it. This can be easily verified just by looking at a few PT traces. Or just use MDSv2 which actually worked. BTW even for the minimum version virtualization is definitely needed. -Andi