From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Glisse Subject: Re: [PATCH v5 0/9] mmu notifier provide context informations Date: Tue, 19 Feb 2019 16:30:33 -0500 Message-ID: <20190219213032.GE3959@redhat.com> References: <20190219200430.11130-1-jglisse@redhat.com> <20190219203032.GC3959@redhat.com> <20190219205751.GD3959@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Williams Cc: Jan Kara , KVM list , Radim =?utf-8?B?S3LEjW3DocWZ?= , Maling list - DRI developers , Michal Hocko , Linux MM , Ross Zwisler , Andrea Arcangeli , linux-rdma , Jason Gunthorpe , Ralph Campbell , Arnd Bergmann , John Hubbard , Peter Xu , Rodrigo Vivi , Felix Kuehling , Linux Kernel Mailing List , linux-fsdevel , Paolo Bonzini , Andrew Morton , Christian =?iso-8859-1?Q?K=F6nig?= List-Id: linux-rdma@vger.kernel.org T24gVHVlLCBGZWIgMTksIDIwMTkgYXQgMDE6MTk6MDlQTSAtMDgwMCwgRGFuIFdpbGxpYW1zIHdy b3RlOgo+IE9uIFR1ZSwgRmViIDE5LCAyMDE5IGF0IDEyOjU4IFBNIEplcm9tZSBHbGlzc2UgPGpn bGlzc2VAcmVkaGF0LmNvbT4gd3JvdGU6Cj4gPgo+ID4gT24gVHVlLCBGZWIgMTksIDIwMTkgYXQg MTI6NDA6MzdQTSAtMDgwMCwgRGFuIFdpbGxpYW1zIHdyb3RlOgo+ID4gPiBPbiBUdWUsIEZlYiAx OSwgMjAxOSBhdCAxMjozMCBQTSBKZXJvbWUgR2xpc3NlIDxqZ2xpc3NlQHJlZGhhdC5jb20+IHdy b3RlOgo+ID4gPiA+Cj4gPiA+ID4gT24gVHVlLCBGZWIgMTksIDIwMTkgYXQgMTI6MTU6NTVQTSAt MDgwMCwgRGFuIFdpbGxpYW1zIHdyb3RlOgo+ID4gPiA+ID4gT24gVHVlLCBGZWIgMTksIDIwMTkg YXQgMTI6MDQgUE0gPGpnbGlzc2VAcmVkaGF0LmNvbT4gd3JvdGU6Cj4gPiA+ID4gPiA+Cj4gPiA+ ID4gPiA+IEZyb206IErDqXLDtG1lIEdsaXNzZSA8amdsaXNzZUByZWRoYXQuY29tPgo+ID4gPiA+ ID4gPgo+ID4gPiA+ID4gPiBTaW5jZSBsYXN0IHZlcnNpb24gWzRdIGkgYWRkZWQgdGhlIGV4dHJh IGJpdHMgbmVlZGVkIGZvciB0aGUgY2hhbmdlX3B0ZQo+ID4gPiA+ID4gPiBvcHRpbWl6YXRpb24g KHdoaWNoIGlzIGEgS1NNIHRoaW5nKS4gSGVyZSBpIGFtIG5vdCBwb3N0aW5nIHVzZXJzIG9mCj4g PiA+ID4gPiA+IHRoaXMsIHRoZXkgd2lsbCBiZSBwb3N0ZWQgdG8gdGhlIGFwcHJvcHJpYXRlIHN1 Yi1zeXN0ZW1zIChLVk0sIEdQVSwKPiA+ID4gPiA+ID4gUkRNQSwgLi4uKSBvbmNlIHRoaXMgc2Vy aWUgZ2V0IHVwc3RyZWFtLiBJZiB5b3Ugd2FudCB0byBsb29rIGF0IHVzZXJzCj4gPiA+ID4gPiA+ IG9mIHRoaXMgc2VlIFs1XSBbNl0uIElmIHRoaXMgZ2V0cyBpbiA1LjEgdGhlbiBpIHdpbGwgYmUg c3VibWl0dGluZwo+ID4gPiA+ID4gPiB0aG9zZSB1c2VycyBmb3IgNS4yIChpbmNsdWRpbmcgS1ZN IGlmIEtWTSBmb2xrcyBmZWVsIGNvbWZvcnRhYmxlIHdpdGgKPiA+ID4gPiA+ID4gaXQpLgo+ID4g PiA+ID4KPiA+ID4gPiA+IFRoZSB1c2VycyBsb29rIHNtYWxsIGFuZCBzdHJhaWdodGZvcndhcmQu IFdoeSBub3QgYXdhaXQgYWNrcyBhbmQKPiA+ID4gPiA+IHJldmlld2VkLWJ5J3MgZm9yIHRoZSB1 c2VycyBsaWtlIGEgdHlwaWNhbCB1cHN0cmVhbSBzdWJtaXNzaW9uIGFuZAo+ID4gPiA+ID4gbWVy Z2UgdGhlbSB0b2dldGhlcj8gSXMgYWxsIG9mIHRoZSBmdW5jdGlvbmFsaXR5IG9mIHRoaXMKPiA+ ID4gPiA+IGluZnJhc3RydWN0dXJlIGNvbnN1bWVkIGJ5IHRoZSBwcm9wb3NlZCB1c2Vycz8gTGFz dCB0aW1lIEkgY2hlY2tlZCBpdAo+ID4gPiA+ID4gd2FzIG9ubHkgYSBzdWJzZXQuCj4gPiA+ID4K PiA+ID4gPiBZZXMgcHJldHR5IG11Y2ggYWxsIGlzIHVzZSwgdGhlIHVudXNlIGNhc2UgaXMgU09G VF9ESVJUWSBhbmQgQ0xFQVIKPiA+ID4gPiB2cyBVTk1BUC4gQm90aCBvZiB3aGljaCBpIGludGVu ZCB0byB1c2UuIFRoZSBSRE1BIGZvbGtzIGFscmVhZHkgYWNrCj4gPiA+ID4gdGhlIHBhdGNoZXMg SUlSQywgc28gZGlkIHJhZGVvbiBhbmQgYW1kZ3B1LiBJIGJlbGlldmUgdGhlIGk5MTUgZm9sa3MK PiA+ID4gPiB3ZXJlIG9rIHdpdGggaXQgdG9vLiBJIGRvIG5vdCB3YW50IHRvIG1lcmdlIHRoaW5n cyB0aHJvdWdoIEFuZHJldwo+ID4gPiA+IGZvciBhbGwgb2YgdGhpcyB3ZSBkaXNjdXNzZWQgdGhh dCBpbiB0aGUgcGFzdCwgbWVyZ2UgbW0gYml0cyB0aHJvdWdoCj4gPiA+ID4gQW5kcmV3IGluIG9u ZSByZWxlYXNlIGFuZCBiaXRzIHRoYXQgdXNlIHRoaW5ncyBpbiB0aGUgbmV4dCByZWxlYXNlLgo+ ID4gPgo+ID4gPiBPaywgSSB3YXMgdHJ5aW5nIHRvIGZpbmQgdGhlIGxpbmtzIHRvIHRoZSBhY2tz IG9uIHRoZSBtYWlsaW5nIGxpc3QsCj4gPiA+IHRob3NlIHJlZmVyZW5jZXMgd291bGQgYWRkcmVz cyBteSBjb25jZXJucy4gSSBzZWUgbm8gcmVhc29uIHRvIHJ1c2gKPiA+ID4gU09GVF9ESVJUWSBh bmQgQ0xFQVIgYWhlYWQgb2YgdGhlIHVwc3RyZWFtIHVzZXIuCj4gPgo+ID4gSSBpbnRlbmQgdG8g cG9zdCB1c2VyIGZvciB0aG9zZSBpbiBuZXh0IGNvdXBsZSB3ZWVrcyBmb3IgNS4yIEhNTSBiaXRz Lgo+ID4gU28gdXNlciBmb3IgdGhpcyAoQ0xFQVIvVU5NQVAvU09GVERJUlRZKSB3aWxsIGRlZmlu aXRseSBtYXRlcmlhbGl6ZSBpbgo+ID4gdGltZSBmb3IgNS4yLgo+ID4KPiA+IEFDS1MgQU1EL1JB REVPTiBodHRwczovL2xrbWwub3JnL2xrbWwvMjAxOS8yLzEvMzk1Cj4gPiBBQ0tTIFJETUEgaHR0 cHM6Ly9sa21sLm9yZy9sa21sLzIwMTgvMTIvNi8xNDczCj4gCj4gTmljZSwgdGhhbmtzIQo+IAo+ ID4gRm9yIEtWTSBBbmRyZWEgQXJjYW5nZWxpIHNlZW1zIHRvIGxpa2UgdGhlIHdob2xlIGlkZWEg dG8gcmVzdG9yZSB0aGUKPiA+IGNoYW5nZV9wdGUgb3B0aW1pemF0aW9uIGJ1dCBpIGhhdmUgbm90 IGdvdCBBQ0sgZnJvbSBSYWRpbSBvciBQYW9sbywKPiA+IGhvd2V2ZXIgZ2l2ZW4gdGhlIHNtYWxs IHBlcmZvcm1hbmNlIGltcHJvdmVtZW50IGZpZ3VyZSBpIGdldCB3aXRoIGl0Cj4gPiBpIGRvIG5v dCBzZWUgd2hpbGUgdGhleSB3b3VsZCBub3QgQUNLLgo+IAo+IFN1cmUsIGJ1dCBubyBuZWVkIHRv IHB1c2ggYWhlYWQgd2l0aG91dCB0aGF0IGNvbmZpcm1hdGlvbiwgcmlnaHQ/IEF0Cj4gbGVhc3Qg Zm9yIHRoZSBwaWVjZSB0aGF0IEtWTSBjYXJlcyBhYm91dCwgbWF5YmUgdGhhdCdzIGFscmVhZHkg Y292ZXJlZAo+IGluIHRoZSBpbmZyYXN0cnVjdHVyZSBSRE1BIGFuZCBSQURFT04gYXJlIHVzaW5n PwoKVGhlIGNoYW5nZV9wdGUoKSBmb3IgS1ZNIGlzIGp1c3Qgb25lIGJpdCBmbGFnIG9uIHRvcCBv ZiB0aGUgcmVzdC4gU28KaSBkb24ndCBzZWUgbXVjaCB2YWx1ZSBpbiBzYXZpbmcgdGhpcyBsYXN0 IHBhdGNoLiBJIHdpbGwgYmUgd29ya2luZwp3aXRoIEtWTSBmb2xrcyB0byBtZXJnZSBLVk0gYml0 cyBpbiA1LjIuIElmIHRoZXkgZG8gbm90IHdhbnQgdGhhdCB0aGVuCnJlbW92aW5nIHRoYXQgZXh0 cmEgZmxhZ3MgaXMgbm90IG11Y2ggd29yay4KCkJ1dCBpZiB5b3UgcHJlZmVyIHRoYW4gQW5kcmV3 IGNhbiBkcm9wIHRoZSBsYXN0IHBhdGNoIGluIHRoZSBzZXJpZS4KCkNoZWVycywKSsOpcsO0bWUK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16AE2C43381 for ; Tue, 19 Feb 2019 21:30:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA5FC21773 for ; Tue, 19 Feb 2019 21:30:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729502AbfBSVar (ORCPT ); Tue, 19 Feb 2019 16:30:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55262 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727736AbfBSVar (ORCPT ); Tue, 19 Feb 2019 16:30:47 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 332EDC007325; Tue, 19 Feb 2019 21:30:46 +0000 (UTC) Received: from redhat.com (ovpn-122-134.rdu2.redhat.com [10.10.122.134]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C5FB060BE8; Tue, 19 Feb 2019 21:30:35 +0000 (UTC) Date: Tue, 19 Feb 2019 16:30:33 -0500 From: Jerome Glisse To: Dan Williams Cc: Linux MM , Andrew Morton , Linux Kernel Mailing List , Christian =?iso-8859-1?Q?K=F6nig?= , Joonas Lahtinen , Jani Nikula , Rodrigo Vivi , Jan Kara , Andrea Arcangeli , Peter Xu , Felix Kuehling , Jason Gunthorpe , Ross Zwisler , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Michal Hocko , Ralph Campbell , John Hubbard , KVM list , Maling list - DRI developers , linux-rdma , linux-fsdevel , Arnd Bergmann Subject: Re: [PATCH v5 0/9] mmu notifier provide context informations Message-ID: <20190219213032.GE3959@redhat.com> References: <20190219200430.11130-1-jglisse@redhat.com> <20190219203032.GC3959@redhat.com> <20190219205751.GD3959@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 19 Feb 2019 21:30:46 +0000 (UTC) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Feb 19, 2019 at 01:19:09PM -0800, Dan Williams wrote: > On Tue, Feb 19, 2019 at 12:58 PM Jerome Glisse wrote: > > > > On Tue, Feb 19, 2019 at 12:40:37PM -0800, Dan Williams wrote: > > > On Tue, Feb 19, 2019 at 12:30 PM Jerome Glisse wrote: > > > > > > > > On Tue, Feb 19, 2019 at 12:15:55PM -0800, Dan Williams wrote: > > > > > On Tue, Feb 19, 2019 at 12:04 PM wrote: > > > > > > > > > > > > From: Jérôme Glisse > > > > > > > > > > > > Since last version [4] i added the extra bits needed for the change_pte > > > > > > optimization (which is a KSM thing). Here i am not posting users of > > > > > > this, they will be posted to the appropriate sub-systems (KVM, GPU, > > > > > > RDMA, ...) once this serie get upstream. If you want to look at users > > > > > > of this see [5] [6]. If this gets in 5.1 then i will be submitting > > > > > > those users for 5.2 (including KVM if KVM folks feel comfortable with > > > > > > it). > > > > > > > > > > The users look small and straightforward. Why not await acks and > > > > > reviewed-by's for the users like a typical upstream submission and > > > > > merge them together? Is all of the functionality of this > > > > > infrastructure consumed by the proposed users? Last time I checked it > > > > > was only a subset. > > > > > > > > Yes pretty much all is use, the unuse case is SOFT_DIRTY and CLEAR > > > > vs UNMAP. Both of which i intend to use. The RDMA folks already ack > > > > the patches IIRC, so did radeon and amdgpu. I believe the i915 folks > > > > were ok with it too. I do not want to merge things through Andrew > > > > for all of this we discussed that in the past, merge mm bits through > > > > Andrew in one release and bits that use things in the next release. > > > > > > Ok, I was trying to find the links to the acks on the mailing list, > > > those references would address my concerns. I see no reason to rush > > > SOFT_DIRTY and CLEAR ahead of the upstream user. > > > > I intend to post user for those in next couple weeks for 5.2 HMM bits. > > So user for this (CLEAR/UNMAP/SOFTDIRTY) will definitly materialize in > > time for 5.2. > > > > ACKS AMD/RADEON https://lkml.org/lkml/2019/2/1/395 > > ACKS RDMA https://lkml.org/lkml/2018/12/6/1473 > > Nice, thanks! > > > For KVM Andrea Arcangeli seems to like the whole idea to restore the > > change_pte optimization but i have not got ACK from Radim or Paolo, > > however given the small performance improvement figure i get with it > > i do not see while they would not ACK. > > Sure, but no need to push ahead without that confirmation, right? At > least for the piece that KVM cares about, maybe that's already covered > in the infrastructure RDMA and RADEON are using? The change_pte() for KVM is just one bit flag on top of the rest. So i don't see much value in saving this last patch. I will be working with KVM folks to merge KVM bits in 5.2. If they do not want that then removing that extra flags is not much work. But if you prefer than Andrew can drop the last patch in the serie. Cheers, Jérôme