From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gwFqy-0003sC-3i for mharc-qemu-trivial@gnu.org; Tue, 19 Feb 2019 19:35:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwFqu-0003rM-Np for qemu-trivial@nongnu.org; Tue, 19 Feb 2019 19:35:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwFqh-0007Du-Pr for qemu-trivial@nongnu.org; Tue, 19 Feb 2019 19:34:59 -0500 Received: from mga01.intel.com ([192.55.52.88]:28232) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gwFq9-0006Zn-Hl; Tue, 19 Feb 2019 19:34:26 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Feb 2019 16:32:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,388,1544515200"; d="scan'208";a="148209999" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga001.fm.intel.com with ESMTP; 19 Feb 2019 16:32:20 -0800 From: Wei Yang To: qemu-devel@nongnu.org, qemu-trivial@nongnu.org Cc: mjt@tls.msk.ru, imammedo@redhat.com, philmd@redhat.com, eblake@redhat.com, peter.maydell@linaro.org, Wei Yang Date: Wed, 20 Feb 2019 08:31:13 +0800 Message-Id: <20190220003113.20746-3-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190220003113.20746-1-richardw.yang@linux.intel.com> References: <20190220003113.20746-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.88 Subject: [Qemu-trivial] [PATCH v2 2/2] CODING_STYLE: indent example code as all others X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 00:35:11 -0000 All the example code are indented with four spaces except this one. Fix this by adding four spaces here. Signed-off-by: Wei Yang Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé --- CODING_STYLE | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CODING_STYLE b/CODING_STYLE index 403904667a..5679b2fd69 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -131,10 +131,10 @@ block to a separate function altogether. When comparing a variable for (in)equality with a constant, list the constant on the right, as in: -if (a == 1) { - /* Reads like: "If a equals 1" */ - do_something(); -} + if (a == 1) { + /* Reads like: "If a equals 1" */ + do_something(); + } Rationale: Yoda conditions (as in 'if (1 == a)') are awkward to read. Besides, good compilers already warn users when '==' is mis-typed as '=', -- 2.19.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:36592) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwFqY-0003aW-AL for qemu-devel@nongnu.org; Tue, 19 Feb 2019 19:34:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwFqI-0007AU-DX for qemu-devel@nongnu.org; Tue, 19 Feb 2019 19:34:34 -0500 From: Wei Yang Date: Wed, 20 Feb 2019 08:31:13 +0800 Message-Id: <20190220003113.20746-3-richardw.yang@linux.intel.com> In-Reply-To: <20190220003113.20746-1-richardw.yang@linux.intel.com> References: <20190220003113.20746-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH v2 2/2] CODING_STYLE: indent example code as all others List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-trivial@nongnu.org Cc: mjt@tls.msk.ru, imammedo@redhat.com, philmd@redhat.com, eblake@redhat.com, peter.maydell@linaro.org, Wei Yang All the example code are indented with four spaces except this one. Fix this by adding four spaces here. Signed-off-by: Wei Yang Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé --- CODING_STYLE | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CODING_STYLE b/CODING_STYLE index 403904667a..5679b2fd69 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -131,10 +131,10 @@ block to a separate function altogether. When comparing a variable for (in)equality with a constant, list the constant on the right, as in: -if (a == 1) { - /* Reads like: "If a equals 1" */ - do_something(); -} + if (a == 1) { + /* Reads like: "If a equals 1" */ + do_something(); + } Rationale: Yoda conditions (as in 'if (1 == a)') are awkward to read. Besides, good compilers already warn users when '==' is mis-typed as '=', -- 2.19.1