From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 03/25] chardev/wctablet: Use unsigned type to hold unsigned value Date: Wed, 20 Feb 2019 02:02:10 +0100 Message-ID: <20190220010232.18731-4-philmd@redhat.com> References: <20190220010232.18731-1-philmd@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gwGJ7-0000Ih-Gt for xen-devel@lists.xenproject.org; Wed, 20 Feb 2019 01:04:17 +0000 In-Reply-To: <20190220010232.18731-1-philmd@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: qemu-devel@nongnu.org, Prasad J Pandit , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini Cc: Corey Minyard , Stefano Stabellini , Samuel Thibault , Li Zhijian , Amit Shah , "Michael S. Tsirkin" , Jason Wang , Cornelia Huck , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Paul Durrant , qemu-ppc@nongnu.org, Gerd Hoffmann , Pavel Dovgalyuk , Zhang Chen , Anthony Perard , xen-devel@lists.xenproject.org, Stefan Berger , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Gibson List-Id: xen-devel@lists.xenproject.org VGFibGV0Q2hhcmRldjo6cXVlcnkgaXMgYW4gYXJyYXkgb2YgdWludDhfdC4KVXNlIHRoZSBzYW1l IHR5cGUgdG8gaG9sZCBpdCAodGhpcyBhbHNvIHNpbGVudCBhIC1Xc2lnbi1jb252ZXJzaW9uCndh cm5pbmcgaW4gdGhlIHRyYWNlIGZ1bmN0aW9uKS4KClNpZ25lZC1vZmYtYnk6IFBoaWxpcHBlIE1h dGhpZXUtRGF1ZMOpIDxwaGlsbWRAcmVkaGF0LmNvbT4KLS0tCiBjaGFyZGV2L3RyYWNlLWV2ZW50 cyB8IDIgKy0KIGNoYXJkZXYvd2N0YWJsZXQuYyAgIHwgNSArKystLQogMiBmaWxlcyBjaGFuZ2Vk LCA0IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvY2hhcmRldi90 cmFjZS1ldmVudHMgYi9jaGFyZGV2L3RyYWNlLWV2ZW50cwppbmRleCBkMGU1ZjNiYmMxLi41NjJi ZmU3MGU5IDEwMDY0NAotLS0gYS9jaGFyZGV2L3RyYWNlLWV2ZW50cworKysgYi9jaGFyZGV2L3Ry YWNlLWV2ZW50cwpAQCAtNSw3ICs1LDcgQEAgd2N0X2luaXQodm9pZCkgIiIKIHdjdF9jbWRfcmUo dm9pZCkgIiIKIHdjdF9jbWRfc3Qodm9pZCkgIiIKIHdjdF9jbWRfc3Aodm9pZCkgIiIKLXdjdF9j bWRfdHMoaW50IGlucHV0KSAiMHglMDJ4Igord2N0X2NtZF90cyh1aW50OF90IGlucHV0KSAiMHgl MDJ4Igogd2N0X2NtZF9vdGhlcihjb25zdCBjaGFyICpjbWQpICIlcyIKIHdjdF9zcGVlZChpbnQg c3BlZWQpICIlZCIKIApkaWZmIC0tZ2l0IGEvY2hhcmRldi93Y3RhYmxldC5jIGIvY2hhcmRldi93 Y3RhYmxldC5jCmluZGV4IDM1ZGJkMjlhMzMuLmNmN2EwOGEzNjMgMTAwNjQ0Ci0tLSBhL2NoYXJk ZXYvd2N0YWJsZXQuYworKysgYi9jaGFyZGV2L3djdGFibGV0LmMKQEAgLTIwNyw3ICsyMDcsOCBA QCBzdGF0aWMgaW50IHdjdGFibGV0X2Nocl93cml0ZShzdHJ1Y3QgQ2hhcmRldiAqY2hyLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgdWludDhfdCAqYnVmLCBpbnQgbGVuKQog ewogICAgIFRhYmxldENoYXJkZXYgKnRhYmxldCA9IFdDVEFCTEVUX0NIQVJERVYoY2hyKTsKLSAg ICB1bnNpZ25lZCBpbnQgaSwgY2xlbjsKKyAgICBzaXplX3QgaTsKKyAgICB1bnNpZ25lZCBpbnQg Y2xlbjsKICAgICBjaGFyICpwb3M7CiAKICAgICBpZiAodGFibGV0LT5saW5lX3NwZWVkICE9IDk2 MDApIHsKQEAgLTI2OSw3ICsyNzAsNyBAQCBzdGF0aWMgaW50IHdjdGFibGV0X2Nocl93cml0ZShz dHJ1Y3QgQ2hhcmRldiAqY2hyLAogCiAgICAgfSBlbHNlIGlmIChzdHJuY21wKChjaGFyICopdGFi bGV0LT5xdWVyeSwgIlRTIiwgMikgPT0gMCAmJgogICAgICAgICAgICAgICAgY2xlbiA9PSAzKSB7 Ci0gICAgICAgIHVuc2lnbmVkIGludCBpbnB1dCA9IHRhYmxldC0+cXVlcnlbMl07CisgICAgICAg IHVpbnQ4X3QgaW5wdXQgPSB0YWJsZXQtPnF1ZXJ5WzJdOwogICAgICAgICB1aW50OF90IGNvZGVz WzddID0gewogICAgICAgICAgICAgMHhhMywKICAgICAgICAgICAgICgoaW5wdXQgJiAweDgwKSA9 PSAwKSA/IDB4N2UgOiAweDdmLAotLSAKMi4yMC4xCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxA bGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFu L2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:41086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwGQp-00052u-1P for qemu-devel@nongnu.org; Tue, 19 Feb 2019 20:12:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwGJ3-0001nT-Uw for qemu-devel@nongnu.org; Tue, 19 Feb 2019 20:04:19 -0500 From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Date: Wed, 20 Feb 2019 02:02:10 +0100 Message-Id: <20190220010232.18731-4-philmd@redhat.com> In-Reply-To: <20190220010232.18731-1-philmd@redhat.com> References: <20190220010232.18731-1-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v3 03/25] chardev/wctablet: Use unsigned type to hold unsigned value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Prasad J Pandit , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini Cc: Jason Wang , Anthony Perard , qemu-ppc@nongnu.org, Stefan Berger , David Gibson , Gerd Hoffmann , Zhang Chen , xen-devel@lists.xenproject.org, Cornelia Huck , Samuel Thibault , Christian Borntraeger , Amit Shah , Li Zhijian , Corey Minyard , "Michael S. Tsirkin" , Paul Durrant , Halil Pasic , Stefano Stabellini , qemu-s390x@nongnu.org, Pavel Dovgalyuk , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= TabletChardev::query is an array of uint8_t. Use the same type to hold it (this also silent a -Wsign-conversion warning in the trace function). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- chardev/trace-events | 2 +- chardev/wctablet.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/chardev/trace-events b/chardev/trace-events index d0e5f3bbc1..562bfe70e9 100644 --- a/chardev/trace-events +++ b/chardev/trace-events @@ -5,7 +5,7 @@ wct_init(void) "" wct_cmd_re(void) "" wct_cmd_st(void) "" wct_cmd_sp(void) "" -wct_cmd_ts(int input) "0x%02x" +wct_cmd_ts(uint8_t input) "0x%02x" wct_cmd_other(const char *cmd) "%s" wct_speed(int speed) "%d" =20 diff --git a/chardev/wctablet.c b/chardev/wctablet.c index 35dbd29a33..cf7a08a363 100644 --- a/chardev/wctablet.c +++ b/chardev/wctablet.c @@ -207,7 +207,8 @@ static int wctablet_chr_write(struct Chardev *chr, const uint8_t *buf, int len) { TabletChardev *tablet =3D WCTABLET_CHARDEV(chr); - unsigned int i, clen; + size_t i; + unsigned int clen; char *pos; =20 if (tablet->line_speed !=3D 9600) { @@ -269,7 +270,7 @@ static int wctablet_chr_write(struct Chardev *chr, =20 } else if (strncmp((char *)tablet->query, "TS", 2) =3D=3D 0 && clen =3D=3D 3) { - unsigned int input =3D tablet->query[2]; + uint8_t input =3D tablet->query[2]; uint8_t codes[7] =3D { 0xa3, ((input & 0x80) =3D=3D 0) ? 0x7e : 0x7f, --=20 2.20.1