Re: [PATCH 2/2] Staging: rtl8192e: Avoid using bool structure members

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Wed, Feb 20, 2019 at 01:00:11PM +0530, Bhanusree Pola wrote:
> Use 'u8' with bitfield instead of 'bool' to avoid alignment
> issues and remove checkpatch.pl check:
> CHECK: Avoid using bool structure members because of possible alignment
> issues
> 
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> ---
>  drivers/staging/rtl8192e/dot11d.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192e/dot11d.h b/drivers/staging/rtl8192e/dot11d.h
> index 44f11f629922..f3e8373b1312 100644
> --- a/drivers/staging/rtl8192e/dot11d.h
> +++ b/drivers/staging/rtl8192e/dot11d.h
> @@ -29,7 +29,7 @@ enum dot11d_state {
>   */
>  
>  struct rt_dot11d_info {
> -	bool enabled;
> +	u8 enabled:1;

Ick, no, that might just have caused a lot more work to have happen to
access that variable (think about how a bool is stored and accessed vs.
a bitfield).

There's nothing wrong with this bool as-is, I would leave it alone.

thanks,

greg k-h