From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] runc: depend on linux headers >= 3.11 for O_TMPFILE
Date: Wed, 20 Feb 2019 09:01:08 +0100 [thread overview]
Message-ID: <20190220090108.6e2d1e9a@windsurf> (raw)
In-Reply-To: <20190219223530.15956-1-christian@paral.in>
Hello Christian,
On Tue, 19 Feb 2019 14:35:28 -0800
Christian Stewart <christian@paral.in> wrote:
> Add dependency on headers >= 3.11. O_TMPFILE, required by runc, was not
> available until this version.
>
> Fixes:
>
> http://autobuild.buildroot.net/results/63e9d88ae5177541be463f1e2aafec59aa410479
I don't see how it can fix this build issue, because the defconfig for
this failure has:
BR2_TOOLCHAIN_HEADERS_AT_LEAST="3.12"
so it *is* using kernel headers more recent than 3.11.
I had a look at your build issue following your e-mail yesterday, and
indeed O_TMPFILE was added in the kernel headers in 3.11, but
apparently having 3.11 kernel headers is not sufficient. I suppose some
code is also needed in the C library, and because the toolchain used by
this configuration has an old glibc, it doesn't have everything needed
for O_TMPFILE.
So, your patch is OK in the sense that indeed >= 3.11 is needed, but it
is wrong in the sense that it is not going to fix the build issue
you're pointing to.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-02-20 8:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 22:35 [Buildroot] [PATCH 1/3] runc: depend on linux headers >= 3.11 for O_TMPFILE Christian Stewart
2019-02-19 22:35 ` [Buildroot] [PATCH 2/3] docker-containerd: propagate runc headers >= 3.11 dependency Christian Stewart
2019-02-20 21:31 ` Arnout Vandecappelle
2019-02-19 22:35 ` [Buildroot] [PATCH 3/3] docker-engine: " Christian Stewart
2019-02-20 8:01 ` Thomas Petazzoni [this message]
2019-02-20 21:30 ` [Buildroot] [PATCH 1/3] runc: depend on linux headers >= 3.11 for O_TMPFILE Arnout Vandecappelle
2019-02-25 22:59 ` Peter Korsgaard
2019-02-26 7:32 ` Thomas Petazzoni
2019-02-26 8:33 ` Peter Korsgaard
2019-02-26 9:17 ` Thomas Petazzoni
2019-02-26 10:10 ` Peter Korsgaard
2019-02-27 9:07 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220090108.6e2d1e9a@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.