From: Johan Hovold <johan@kernel.org>
To: Daniele Palmas <dnlplm@gmail.com>
Cc: Johan Hovold <johan@kernel.org>, linux-usb <linux-usb@vger.kernel.org>
Subject: [1/1] USB: serial: option: add Telit ME910 ECM composition
Date: Wed, 20 Feb 2019 10:53:35 +0100 [thread overview]
Message-ID: <20190220095335.GA20231@localhost> (raw)
On Wed, Feb 20, 2019 at 10:47:59AM +0100, Daniele Palmas wrote:
> Hi Johan,
>
> Il giorno mer 20 feb 2019 alle ore 10:39 Johan Hovold
> <johan@kernel.org> ha scritto:
> >
> > On Wed, Feb 20, 2019 at 10:13:09AM +0100, Daniele Palmas wrote:
> > > This patch adds Telit ME910 family ECM composition 0x1102.
> > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> > > index aef15497ff31..0cf943281065 100644
> > > --- a/drivers/usb/serial/option.c
> > > +++ b/drivers/usb/serial/option.c
> > > @@ -1148,6 +1148,8 @@ static const struct usb_device_id option_ids[] = {
> > > .driver_info = NCTRL(0) | RSVD(1) | RSVD(3) },
> > > { USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_ME910_DUAL_MODEM),
> > > .driver_info = NCTRL(0) | RSVD(3) },
> > > + { USB_DEVICE(TELIT_VENDOR_ID, 0x1102), /* TELIT ME910 (ECM) */
> > > + .driver_info = NCTRL(0) | RSVD(3) | RSVD(4) },
> >
> > I realise this probably just reuses a pattern from the earlier Telit
> > entries, but why not match on the interface class instead of
> > blacklisting interface 3 and 4?
> >
>
> Yes, it was just for keeping the entry coherent with previous ME910
> related ones.
>
> I can send a V2 fixing this.
Please do, thanks. Let's try to keep the explicit blacklisting to a
minimum.
Johan
next reply other threads:[~2019-02-20 9:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 9:53 Johan Hovold [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-20 9:47 [1/1] USB: serial: option: add Telit ME910 ECM composition Daniele Palmas
2019-02-20 9:39 Johan Hovold
2019-02-20 9:13 Daniele Palmas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220095335.GA20231@localhost \
--to=johan@kernel.org \
--cc=dnlplm@gmail.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.