From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH v3 19/25] s390/ebcdic: Use size_t to iterate over arrays Date: Wed, 20 Feb 2019 10:40:51 +0100 Message-ID: <20190220104051.72f1aca0.cohuck@redhat.com> References: <20190220010232.18731-1-philmd@redhat.com> <20190220010232.18731-20-philmd@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gwONH-0004zV-UP for xen-devel@lists.xenproject.org; Wed, 20 Feb 2019 09:41:07 +0000 In-Reply-To: <20190220010232.18731-20-philmd@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: Li Zhijian , "Michael S. Tsirkin" , Jason Wang , qemu-devel@nongnu.org, Gerd Hoffmann , Stefano Stabellini , Samuel Thibault , Halil Pasic , Christian Borntraeger , Anthony Perard , xen-devel@lists.xenproject.org, Corey Minyard , Amit Shah , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , qemu-s390x@nongnu.org, Paul Durrant , Pavel Dovgalyuk , Zhang Chen , David Gibson , Prasad J Pandit , qemu-ppc@nongnu.org, Paolo Bonzini , Stefan Berger List-Id: xen-devel@lists.xenproject.org T24gV2VkLCAyMCBGZWIgMjAxOSAwMjowMjoyNiArMDEwMApQaGlsaXBwZSBNYXRoaWV1LURhdWTD qSA8cGhpbG1kQHJlZGhhdC5jb20+IHdyb3RlOgoKPiBTaWduZWQtb2ZmLWJ5OiBQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSA8cGhpbG1kQHJlZGhhdC5jb20+Cj4gLS0tCj4gIGluY2x1ZGUvaHcvczM5 MHgvZWJjZGljLmggfCA4ICsrKystLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMo KyksIDQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvaHcvczM5MHgvZWJj ZGljLmggYi9pbmNsdWRlL2h3L3MzOTB4L2ViY2RpYy5oCj4gaW5kZXggNjlhMDRjYWI2Mi4uZDg5 MTc0ZTExMyAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2h3L3MzOTB4L2ViY2RpYy5oCj4gKysrIGIv aW5jbHVkZS9ody9zMzkweC9lYmNkaWMuaAo+IEBAIC04MywxOCArODMsMTggQEAgc3RhdGljIGNv bnN0IHVpbnQ4X3QgYXNjaWkyZWJjZGljW10gPSB7Cj4gICAgICAweDkwLCAweDNGLCAweDNGLCAw eDNGLCAweDNGLCAweEVBLCAweDNGLCAweEZGCj4gIH07Cj4gIAo+IC1zdGF0aWMgaW5saW5lIHZv aWQgZWJjZGljX3B1dCh1aW50OF90ICpwLCBjb25zdCBjaGFyICphc2NpaSwgaW50IGxlbikKPiAr c3RhdGljIGlubGluZSB2b2lkIGViY2RpY19wdXQodWludDhfdCAqcCwgY29uc3QgY2hhciAqYXNj aWksIHNpemVfdCBsZW4pCj4gIHsKPiAtICAgIGludCBpOwo+ICsgICAgc2l6ZV90IGk7Cj4gIAo+ ICAgICAgZm9yIChpID0gMDsgaSA8IGxlbjsgaSsrKSB7Cj4gICAgICAgICAgcFtpXSA9IGFzY2lp MmViY2RpY1sodWludDhfdClhc2NpaVtpXV07Cj4gICAgICB9Cj4gIH0KPiAgCj4gLXN0YXRpYyBp bmxpbmUgdm9pZCBhc2NpaV9wdXQodWludDhfdCAqcCwgY29uc3QgY2hhciAqZWJjZGljLCBpbnQg bGVuKQo+ICtzdGF0aWMgaW5saW5lIHZvaWQgYXNjaWlfcHV0KHVpbnQ4X3QgKnAsIGNvbnN0IGNo YXIgKmViY2RpYywgc2l6ZV90IGxlbikKPiAgewo+IC0gICAgaW50IGk7Cj4gKyAgICBzaXplX3Qg aTsKPiAgCj4gICAgICBmb3IgKGkgPSAwOyBpIDwgbGVuOyBpKyspIHsKPiAgICAgICAgICBwW2ld ID0gZWJjZGljMmFzY2lpWyh1aW50OF90KWViY2RpY1tpXV07CgpNYWtpbmcgdGhlIHBhc3NlZCBs ZW4gcGFyYW1ldGVyIGEgc2l6ZV90IG1ha2VzIHNlbnNlOyBidXQgdXNpbmcgYQpzaXplX3QgYXMg YW4gYXJyYXkgaXRlcmF0b3IgbG9va3MgYSBiaXQgdW5pZGlvbWF0aWMuLi4gaXQncyBub3Qgd3Jv bmcsCnRob3VnaC4KCkFja2VkLWJ5OiBDb3JuZWxpYSBIdWNrIDxjb2h1Y2tAcmVkaGF0LmNvbT4K Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZl bCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlz dHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:36047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwONJ-0001xo-7O for qemu-devel@nongnu.org; Wed, 20 Feb 2019 04:41:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwONI-0008Re-CQ for qemu-devel@nongnu.org; Wed, 20 Feb 2019 04:41:09 -0500 Date: Wed, 20 Feb 2019 10:40:51 +0100 From: Cornelia Huck Message-ID: <20190220104051.72f1aca0.cohuck@redhat.com> In-Reply-To: <20190220010232.18731-20-philmd@redhat.com> References: <20190220010232.18731-1-philmd@redhat.com> <20190220010232.18731-20-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 19/25] s390/ebcdic: Use size_t to iterate over arrays List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: qemu-devel@nongnu.org, Prasad J Pandit , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , Paolo Bonzini , Jason Wang , Anthony Perard , qemu-ppc@nongnu.org, Stefan Berger , David Gibson , Gerd Hoffmann , Zhang Chen , xen-devel@lists.xenproject.org, Samuel Thibault , Christian Borntraeger , Amit Shah , Li Zhijian , Corey Minyard , "Michael S. Tsirkin" , Paul Durrant , Halil Pasic , Stefano Stabellini , qemu-s390x@nongnu.org, Pavel Dovgalyuk On Wed, 20 Feb 2019 02:02:26 +0100 Philippe Mathieu-Daud=C3=A9 wrote: > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > include/hw/s390x/ebcdic.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/include/hw/s390x/ebcdic.h b/include/hw/s390x/ebcdic.h > index 69a04cab62..d89174e113 100644 > --- a/include/hw/s390x/ebcdic.h > +++ b/include/hw/s390x/ebcdic.h > @@ -83,18 +83,18 @@ static const uint8_t ascii2ebcdic[] =3D { > 0x90, 0x3F, 0x3F, 0x3F, 0x3F, 0xEA, 0x3F, 0xFF > }; > =20 > -static inline void ebcdic_put(uint8_t *p, const char *ascii, int len) > +static inline void ebcdic_put(uint8_t *p, const char *ascii, size_t len) > { > - int i; > + size_t i; > =20 > for (i =3D 0; i < len; i++) { > p[i] =3D ascii2ebcdic[(uint8_t)ascii[i]]; > } > } > =20 > -static inline void ascii_put(uint8_t *p, const char *ebcdic, int len) > +static inline void ascii_put(uint8_t *p, const char *ebcdic, size_t len) > { > - int i; > + size_t i; > =20 > for (i =3D 0; i < len; i++) { > p[i] =3D ebcdic2ascii[(uint8_t)ebcdic[i]]; Making the passed len parameter a size_t makes sense; but using a size_t as an array iterator looks a bit unidiomatic... it's not wrong, though. Acked-by: Cornelia Huck