From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH v3 20/25] s390x/sclp: Use a const variable to improve readability Date: Wed, 20 Feb 2019 11:53:16 +0100 Message-ID: <20190220115316.3e471bff.cohuck@redhat.com> References: <20190220010232.18731-1-philmd@redhat.com> <20190220010232.18731-21-philmd@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gwPVE-00032Y-NP for xen-devel@lists.xenproject.org; Wed, 20 Feb 2019 10:53:24 +0000 In-Reply-To: <20190220010232.18731-21-philmd@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: Li Zhijian , "Michael S. Tsirkin" , Jason Wang , qemu-devel@nongnu.org, Gerd Hoffmann , Stefano Stabellini , Samuel Thibault , Halil Pasic , Christian Borntraeger , Anthony Perard , xen-devel@lists.xenproject.org, Corey Minyard , Amit Shah , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , qemu-s390x@nongnu.org, Paul Durrant , Pavel Dovgalyuk , Zhang Chen , David Gibson , Prasad J Pandit , qemu-ppc@nongnu.org, Paolo Bonzini , Stefan Berger List-Id: xen-devel@lists.xenproject.org T24gV2VkLCAyMCBGZWIgMjAxOSAwMjowMjoyNyArMDEwMApQaGlsaXBwZSBNYXRoaWV1LURhdWTD qSA8cGhpbG1kQHJlZGhhdC5jb20+IHdyb3RlOgoKPiBXZSB3aWxsIHJldXNlIHRoaXMgdmFyaWFi bGUgaW4gdGhlIG5leHQgcGF0Y2guCj4gCj4gU2lnbmVkLW9mZi1ieTogUGhpbGlwcGUgTWF0aGll dS1EYXVkw6kgPHBoaWxtZEByZWRoYXQuY29tPgo+IC0tLQo+ICBody9jaGFyL3NjbHBjb25zb2xl LWxtLmMgfCA3ICsrKystLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMyBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvaHcvY2hhci9zY2xwY29uc29sZS1sbS5jIGIv aHcvY2hhci9zY2xwY29uc29sZS1sbS5jCj4gaW5kZXggZGJjOTFhMWU1Yi4uNDk1NDNlMmM4MyAx MDA2NDQKPiAtLS0gYS9ody9jaGFyL3NjbHBjb25zb2xlLWxtLmMKPiArKysgYi9ody9jaGFyL3Nj bHBjb25zb2xlLWxtLmMKPiBAQCAtMjEwLDEzICsyMTAsMTQgQEAgc3RhdGljIGludCBwcm9jZXNz X21kYihTQ0xQRXZlbnQgKmV2ZW50LCBNREJPICptZGJvKQo+ICAgICAgaW50IHJjOwo+ICAgICAg aW50IGxlbjsKPiAgICAgIHVpbnQ4X3QgYnVmZmVyW1NJWkVfQlVGRkVSXTsKPiAtCj4gLSAgICBs ZW4gPSBiZTE2X3RvX2NwdShtZGJvLT5sZW5ndGgpOwo+IC0gICAgbGVuIC09IHNpemVvZihtZGJv LT5sZW5ndGgpICsgc2l6ZW9mKG1kYm8tPnR5cGUpCj4gKyAgICBjb25zdCBzaXplX3QgaGxlbiA9 IHNpemVvZihtZGJvLT5sZW5ndGgpCj4gKyAgICAgICAgICAgICsgc2l6ZW9mKG1kYm8tPnR5cGUp Cj4gICAgICAgICAgICAgICsgc2l6ZW9mKG1kYm8tPm10by5saW5lX3R5cGVfZmxhZ3MpCj4gICAg ICAgICAgICAgICsgc2l6ZW9mKG1kYm8tPm10by5hbGFybV9jb250cm9sKQo+ICAgICAgICAgICAg ICArIHNpemVvZihtZGJvLT5tdG8uX3Jlc2VydmVkKTsKPiAgCj4gKyAgICBsZW4gPSBiZTE2X3Rv X2NwdShtZGJvLT5sZW5ndGgpOwo+ICsgICAgbGVuIC09IGhsZW47Cj4gICAgICBhc3NlcnQobGVu IDw9IFNJWkVfQlVGRkVSKTsKPiAgCj4gICAgICAvKiBjb252ZXJ0IEVCQ0RJQyBTQ0xQIGNvbnRl bnRzIHRvIEFTQ0lJIGNvbnNvbGUgbWVzc2FnZSAqLwoKSSdkIHByb2JhYmx5IG1lcmdlIHRoaXMg d2l0aCB0aGUgbmV4dCBwYXRjaCwgdGhvdWdoLgoKUmV2aWV3ZWQtYnk6IENvcm5lbGlhIEh1Y2sg PGNvaHVja0ByZWRoYXQuY29tPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJv amVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hl bi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:50982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwPVT-0003h5-9i for qemu-devel@nongnu.org; Wed, 20 Feb 2019 05:53:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwPVS-0008Qn-Fx for qemu-devel@nongnu.org; Wed, 20 Feb 2019 05:53:39 -0500 Date: Wed, 20 Feb 2019 11:53:16 +0100 From: Cornelia Huck Message-ID: <20190220115316.3e471bff.cohuck@redhat.com> In-Reply-To: <20190220010232.18731-21-philmd@redhat.com> References: <20190220010232.18731-1-philmd@redhat.com> <20190220010232.18731-21-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 20/25] s390x/sclp: Use a const variable to improve readability List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: qemu-devel@nongnu.org, Prasad J Pandit , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , Paolo Bonzini , Jason Wang , Anthony Perard , qemu-ppc@nongnu.org, Stefan Berger , David Gibson , Gerd Hoffmann , Zhang Chen , xen-devel@lists.xenproject.org, Samuel Thibault , Christian Borntraeger , Amit Shah , Li Zhijian , Corey Minyard , "Michael S. Tsirkin" , Paul Durrant , Halil Pasic , Stefano Stabellini , qemu-s390x@nongnu.org, Pavel Dovgalyuk On Wed, 20 Feb 2019 02:02:27 +0100 Philippe Mathieu-Daud=C3=A9 wrote: > We will reuse this variable in the next patch. >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > hw/char/sclpconsole-lm.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/hw/char/sclpconsole-lm.c b/hw/char/sclpconsole-lm.c > index dbc91a1e5b..49543e2c83 100644 > --- a/hw/char/sclpconsole-lm.c > +++ b/hw/char/sclpconsole-lm.c > @@ -210,13 +210,14 @@ static int process_mdb(SCLPEvent *event, MDBO *mdbo) > int rc; > int len; > uint8_t buffer[SIZE_BUFFER]; > - > - len =3D be16_to_cpu(mdbo->length); > - len -=3D sizeof(mdbo->length) + sizeof(mdbo->type) > + const size_t hlen =3D sizeof(mdbo->length) > + + sizeof(mdbo->type) > + sizeof(mdbo->mto.line_type_flags) > + sizeof(mdbo->mto.alarm_control) > + sizeof(mdbo->mto._reserved); > =20 > + len =3D be16_to_cpu(mdbo->length); > + len -=3D hlen; > assert(len <=3D SIZE_BUFFER); > =20 > /* convert EBCDIC SCLP contents to ASCII console message */ I'd probably merge this with the next patch, though. Reviewed-by: Cornelia Huck