From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters From: Heikki Krogerus Message-Id: <20190220143053.GD5054@kuha.fi.intel.com> Date: Wed, 20 Feb 2019 16:30:53 +0200 To: Nikolaus Voss Cc: Greg Kroah-Hartman , Guenter Roeck , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gV2VkLCBGZWIgMjAsIDIwMTkgYXQgMDQ6MTQ6MjNQTSArMDIwMCwgSGVpa2tpIEtyb2dlcnVz IHdyb3RlOgo+IE9uIFdlZCwgRmViIDIwLCAyMDE5IGF0IDAyOjM4OjQ3UE0gKzAxMDAsIE5pa29s YXVzIFZvc3Mgd3JvdGU6Cj4gPiBPbiBXZWQsIDIwIEZlYiAyMDE5LCBIZWlra2kgS3JvZ2VydXMg d3JvdGU6Cj4gPiA+IE9uIFdlZCwgRmViIDIwLCAyMDE5IGF0IDAxOjU3OjMwUE0gKzAxMDAsIE5p a29sYXVzIFZvc3Mgd3JvdGU6Cj4gPiA+ID4gQ29tbWl0IDFhMmY0NzRkMzI4ZiBoYW5kbGVzIGJs b2NrIF9yZWFkc18gc2VwYXJhdGVseSB3aXRoIHBsYWluLUkyQwo+ID4gPiA+IGFkYXB0ZXJzLCBi dXQgdGhlIHByb2JsZW0gZGVzY3JpYmVkIHdpdGggcmVnbWFwLWkyYyBub3QgaGFuZGxpbmcKPiA+ ID4gPiBTTUJ1cyBibG9jayB0cmFuc2ZlcnMgKGkuZS4gcmVhZCBhbmQgd3JpdGVzKSBjb3JyZWN0 bHkgYWxzbyBleGlzdHMKPiA+ID4gPiB3aXRoIHdyaXRlcy4KPiA+ID4gPiAKPiA+ID4gPiBBcyB3 b3JrYXJvdW5kLCB0aGlzIHBhdGNoIGFkZHMgYSBibG9jayB3cml0ZSBmdW5jdGlvbiB0aGUgc2Ft ZSB3YXkKPiA+ID4gPiAxYTJmNDc0ZDMyOGYgYWRkcyBhIGJsb2NrIHJlYWQgZnVuY3Rpb24uCj4g PiA+ID4gCj4gPiA+ID4gRml4ZXM6IDFhMmY0NzRkMzI4ZiAoInVzYjogdHlwZWM6IHRwczY1OTh4 OiBoYW5kbGUgYmxvY2sgcmVhZHMgc2VwYXJhdGVseSB3aXRoIHBsYWluLUkyQyBhZGFwdGVycyIp Cj4gPiA+ID4gRml4ZXM6IDBhNGMwMDViZDE3MSAoInVzYjogdHlwZWM6IGRyaXZlciBmb3IgVEkg VFBTNjU5OHggVVNCIFBvd2VyIERlbGl2ZXJ5IGNvbnRyb2xsZXJzIikKPiA+ID4gPiBTaWduZWQt b2ZmLWJ5OiBOaWtvbGF1cyBWb3NzIDxuaWtvbGF1cy52b3NzQGxvZXdlbnN0ZWlubWVkaWNhbC5k ZT4KPiA+ID4gCj4gPiA+IFlvdSBhcmUgbWlzc2luZyBhICJmcm9tIiBsaW5lIHdpdGggYWRkcmVz cyB0aGF0IG1hdGNoZXMgeW91ciBTb0IKPiA+ID4gYWRkcmVzcy4KPiA+IAo+ID4gVGhhdCdzIGJl Y2F1c2UgSSBjdXJyZW50bHkgY2Fubm90IHNlbmQgcGF0Y2ggbWFpbHMgZnJvbSBteSBjb21wYW55 IGFjY291bnQKPiA+IGFzIG91ciBNVEEgYnJlYWtzIGRpZmZzLgo+IAo+IEkgdW5kZXJzdGFuZCwg YnV0IHlvdSBjYW4gaGF2ZSBhIHNlcGFyYXRlICJGcm9tIGxpbmUiIGluIHlvdXIgcGF0Y2gsCj4g aS5lLiB5b3Ugc2VuZCB0aGUgcGF0Y2ggdXNpbmcgb25lIGFkZHJlc3MsIGFuZCBoYXZlIGFuIGV4 dHJhICJGcm9tCj4gbGluZSIgKG91dHNpZGUgb2YgdGhlIG1haWwgaGVhZGVyKSB3aXRoIGFub3Ro ZXIgYWRkcmVzcy4KPiAKPiBUaGF0IG90aGVyIEZyb20gbGluZSB3aWxsIGJlIGludGVycHJldGVk IGFzIHRoZSBhdXRob3IgYWRkcmVzcywgYW5kCj4gaXQgc2hvdWxkIG1hdGNoIHlvdXIgU29CIGFk ZHJlc3MuCj4gCj4gCj4gVHJ5IHNvbWV0aGluZyBsaWtlIHRoaXMgaW4gYSBicmFuY2ggd2hlcmUg dGhpcyBwYXRjaCBpcyB0aGUgSEVBRDoKPiAKPiAgICAgICAgICUgZXhwb3J0IE1ZX0NPTU1JVD0k KGdpdCBzaG93IC1zIC0tcHJldHR5PSVoIEhFQUQpCj4gICAgICAgICAlIGdpdCByZXNldCBIRUFE Xgo+ICAgICAgICAgJSBHSVRfQ09NTUlUVEVSX0lERU5UPSdOaWtvbGF1cyBWb3NzIDxuaWtvbGF1 cy52b3NzQGxvZXdlbnN0ZWlubWVkaWNhbC5kZT4nIFwKPiAgICAgICAgICAgR0lUX0FVVEhPUl9J REVOVD0nTmlrb2xhdXMgVm9zcyA8bmlrb2xhdXMudm9zc0Bsb2V3ZW5zdGVpbm1lZGljYWwuZGU+ JyBcCj4gICAgICAgICAgIGdpdCBjb21taXQgLWEgLUMgJE1ZX0NPTU1JVAoKQ29ycmVjdGlvbiBo ZXJlOgoKICAgICAgICAlIEdJVF9DT01NSVRURVJfSURFTlQ9J05pa29sYXVzIFZvc3MgPG5pa29s YXVzLnZvc3NAbG9ld2Vuc3RlaW5tZWRpY2FsLmRlPicgXAogICAgICAgICAgR0lUX0FVVEhPUl9J REVOVD0nTmlrb2xhdXMgVm9zcyA8bmlrb2xhdXMudm9zc0Bsb2V3ZW5zdGVpbm1lZGljYWwuZGU+ JyBcCiAgICAgICAgICBnaXQgY29tbWl0IC1hIC1DICRNWV9DT01NSVQgLS1yZXNldC1hdXRob3IK ClRoYXQgIi0tcmVzZXQtYXV0aG9yIiB3YXMgbWlzc2luZy4gU29ycnkgZm9yIHRoYXQuCgoKdGhh bmtzLAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEB0EC43381 for ; Wed, 20 Feb 2019 14:31:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8E5B2085A for ; Wed, 20 Feb 2019 14:31:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727139AbfBTObJ (ORCPT ); Wed, 20 Feb 2019 09:31:09 -0500 Received: from mga07.intel.com ([134.134.136.100]:52672 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725801AbfBTObI (ORCPT ); Wed, 20 Feb 2019 09:31:08 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2019 06:30:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,391,1544515200"; d="scan'208";a="148386792" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 20 Feb 2019 06:30:54 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Wed, 20 Feb 2019 16:30:53 +0200 Date: Wed, 20 Feb 2019 16:30:53 +0200 From: Heikki Krogerus To: Nikolaus Voss Cc: Greg Kroah-Hartman , Guenter Roeck , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters Message-ID: <20190220143053.GD5054@kuha.fi.intel.com> References: <20180425142209.30745-1-heikki.krogerus@linux.intel.com> <20190220110017.BFA344CE86@mail.steuer-voss.de> <20190220125731.02E274CFE0@mail.steuer-voss.de> <20190220133036.GB5054@kuha.fi.intel.com> <20190220141423.GC5054@kuha.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190220141423.GC5054@kuha.fi.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 20, 2019 at 04:14:23PM +0200, Heikki Krogerus wrote: > On Wed, Feb 20, 2019 at 02:38:47PM +0100, Nikolaus Voss wrote: > > On Wed, 20 Feb 2019, Heikki Krogerus wrote: > > > On Wed, Feb 20, 2019 at 01:57:30PM +0100, Nikolaus Voss wrote: > > > > Commit 1a2f474d328f handles block _reads_ separately with plain-I2C > > > > adapters, but the problem described with regmap-i2c not handling > > > > SMBus block transfers (i.e. read and writes) correctly also exists > > > > with writes. > > > > > > > > As workaround, this patch adds a block write function the same way > > > > 1a2f474d328f adds a block read function. > > > > > > > > Fixes: 1a2f474d328f ("usb: typec: tps6598x: handle block reads separately with plain-I2C adapters") > > > > Fixes: 0a4c005bd171 ("usb: typec: driver for TI TPS6598x USB Power Delivery controllers") > > > > Signed-off-by: Nikolaus Voss > > > > > > You are missing a "from" line with address that matches your SoB > > > address. > > > > That's because I currently cannot send patch mails from my company account > > as our MTA breaks diffs. > > I understand, but you can have a separate "From line" in your patch, > i.e. you send the patch using one address, and have an extra "From > line" (outside of the mail header) with another address. > > That other From line will be interpreted as the author address, and > it should match your SoB address. > > > Try something like this in a branch where this patch is the HEAD: > > % export MY_COMMIT=$(git show -s --pretty=%h HEAD) > % git reset HEAD^ > % GIT_COMMITTER_IDENT='Nikolaus Voss ' \ > GIT_AUTHOR_IDENT='Nikolaus Voss ' \ > git commit -a -C $MY_COMMIT Correction here: % GIT_COMMITTER_IDENT='Nikolaus Voss ' \ GIT_AUTHOR_IDENT='Nikolaus Voss ' \ git commit -a -C $MY_COMMIT --reset-author That "--reset-author" was missing. Sorry for that. thanks, -- heikki