From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, "Kevin Wolf" <kwolf@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eric Blake" <eblake@redhat.com>
Subject: [Qemu-devel] [PATCH v2 1/2] iotests: ensure we print nbd server log on error
Date: Wed, 20 Feb 2019 14:58:18 +0000 [thread overview]
Message-ID: <20190220145819.30969-2-berrange@redhat.com> (raw)
In-Reply-To: <20190220145819.30969-1-berrange@redhat.com>
If we abort the iotest early the server.log file might contain useful
information for diagnosing the problem. Ensure its contents are
displayed in this case.
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
tests/qemu-iotests/233 | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/qemu-iotests/233 b/tests/qemu-iotests/233
index fc345a1a46..27932df075 100755
--- a/tests/qemu-iotests/233
+++ b/tests/qemu-iotests/233
@@ -30,6 +30,8 @@ _cleanup()
{
nbd_server_stop
_cleanup_test_img
+ # If we aborted early we want to see this log for diagnosis
+ test -f "$TEST_DIR/server.log" && cat "$TEST_DIR/server.log"
rm -f "$TEST_DIR/server.log"
tls_x509_cleanup
}
@@ -120,6 +122,7 @@ $QEMU_IO -f $IMGFMT -r -U -c 'r -P 0x22 1m 1m' "$TEST_IMG" | _filter_qemu_io
echo
echo "== final server log =="
cat "$TEST_DIR/server.log"
+rm -f $TEST_DIR/server.log
# success, all done
echo "*** done"
--
2.20.1
next prev parent reply other threads:[~2019-02-20 16:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 14:58 [Qemu-devel] [PATCH v2 0/2] Fix NBD TLS iotests on RHEL-7 Daniel P. Berrangé
2019-02-20 14:58 ` Daniel P. Berrangé [this message]
2019-02-22 15:06 ` [Qemu-devel] [PATCH v2 1/2] iotests: ensure we print nbd server log on error Max Reitz
2019-02-22 15:16 ` Daniel P. Berrangé
2019-02-22 15:54 ` Eric Blake
2019-02-22 16:00 ` Max Reitz
2019-02-22 16:38 ` Daniel P. Berrangé
2019-02-20 14:58 ` [Qemu-devel] [PATCH v2 2/2] iotests: avoid broken pipe with certtool Daniel P. Berrangé
2019-02-20 16:11 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220145819.30969-2-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.