From: Jonathan Cameron <jic23@kernel.org>
To: Mircea Caprioru <mircea.caprioru@analog.com>
Cc: <Michael.Hennerich@analog.com>, <lars@metafoo.de>,
<gregkh@linuxfoundation.org>, <linux-kernel@vger.kernel.org>,
<linux-iio@vger.kernel.org>
Subject: Re: [PATCH] staging: iio: ad7192: Fix ad7193 channel address
Date: Wed, 20 Feb 2019 15:35:01 +0000 [thread overview]
Message-ID: <20190220153501.4fed22c0@archlinux> (raw)
In-Reply-To: <20190220110820.25580-1-mircea.caprioru@analog.com>
On Wed, 20 Feb 2019 13:08:20 +0200
Mircea Caprioru <mircea.caprioru@analog.com> wrote:
> This patch fixes the differential channels addresses for the ad7193.
>
> Signed-off-by: Mircea Caprioru <mircea.caprioru@analog.com>
Hi
This is an impressively confusing datasheet, but I agree with the fix.
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
> ---
> drivers/staging/iio/adc/ad7192.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index acdbc07fd259..2fc8bc22b57b 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -109,10 +109,10 @@
> #define AD7192_CH_AIN3 BIT(6) /* AIN3 - AINCOM */
> #define AD7192_CH_AIN4 BIT(7) /* AIN4 - AINCOM */
>
> -#define AD7193_CH_AIN1P_AIN2M 0x000 /* AIN1(+) - AIN2(-) */
> -#define AD7193_CH_AIN3P_AIN4M 0x001 /* AIN3(+) - AIN4(-) */
> -#define AD7193_CH_AIN5P_AIN6M 0x002 /* AIN5(+) - AIN6(-) */
> -#define AD7193_CH_AIN7P_AIN8M 0x004 /* AIN7(+) - AIN8(-) */
> +#define AD7193_CH_AIN1P_AIN2M 0x001 /* AIN1(+) - AIN2(-) */
> +#define AD7193_CH_AIN3P_AIN4M 0x002 /* AIN3(+) - AIN4(-) */
> +#define AD7193_CH_AIN5P_AIN6M 0x004 /* AIN5(+) - AIN6(-) */
> +#define AD7193_CH_AIN7P_AIN8M 0x008 /* AIN7(+) - AIN8(-) */
> #define AD7193_CH_TEMP 0x100 /* Temp senseor */
> #define AD7193_CH_AIN2P_AIN2M 0x200 /* AIN2(+) - AIN2(-) */
> #define AD7193_CH_AIN1 0x401 /* AIN1 - AINCOM */
prev parent reply other threads:[~2019-02-20 15:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 11:08 [PATCH] staging: iio: ad7192: Fix ad7193 channel address Mircea Caprioru
2019-02-20 15:35 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220153501.4fed22c0@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=gregkh@linuxfoundation.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mircea.caprioru@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.