From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters From: Greg Kroah-Hartman Message-Id: <20190220162214.GA2017@kroah.com> Date: Wed, 20 Feb 2019 17:22:14 +0100 To: Nikolaus Voss Cc: Heikki Krogerus , Guenter Roeck , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gV2VkLCBGZWIgMjAsIDIwMTkgYXQgMDQ6MjI6MDBQTSArMDEwMCwgTmlrb2xhdXMgVm9zcyB3 cm90ZToKPiA+ID4gdjI6IGZpeCB0cHM2NTk4eF9leGVjX2NtZCBhbHNvCj4gPiA+IC0tLQo+ID4g PiAgZHJpdmVycy91c2IvdHlwZWMvdHBzNjU5OHguYyB8IDI2ICsrKysrKysrKysrKysrKysrKysr LS0tLS0tCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlv bnMoLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi90eXBlYy90cHM2NTk4 eC5jIGIvZHJpdmVycy91c2IvdHlwZWMvdHBzNjU5OHguYwo+ID4gPiBpbmRleCBjODRjOGMxODll OTAuLmM1NGI3M2ZiMmEyZiAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy91c2IvdHlwZWMvdHBz NjU5OHguYwo+ID4gPiArKysgYi9kcml2ZXJzL3VzYi90eXBlYy90cHM2NTk4eC5jCj4gPiA+IEBA IC0xMTAsNiArMTEwLDIwIEBAIHRwczY1OTh4X2Jsb2NrX3JlYWQoc3RydWN0IHRwczY1OTh4ICp0 cHMsIHU4IHJlZywgdm9pZCAqdmFsLCBzaXplX3QgbGVuKQo+ID4gPiAgCXJldHVybiAwOwo+ID4g PiAgfQo+ID4gPiAKPiA+ID4gK3N0YXRpYyBpbnQgdHBzNjU5OHhfYmxvY2tfd3JpdGUoc3RydWN0 IHRwczY1OTh4ICp0cHMsIHU4IHJlZywKPiA+ID4gKwkJCQl2b2lkICp2YWwsIHNpemVfdCBsZW4p Cj4gPiA+ICt7Cj4gPiA+ICsJdTggZGF0YVtsZW4gKyAxXTsKPiA+IAo+ID4gSSB0aG91Z2h0IHRo ZSBidWlsZCBzeXN0ZW0gbm93IHdhcm5lZCB3aGVuIHlvdSBkaWQgdGhpcyA6KAo+IAo+IEkgbXVz dCBhZG1pdCBJJ20gZGV2ZWxvcGluZyBvbiA0LjE5IHN0YWJsZSBzZXJpZXMsIHNvIG5vIHdhcm5p bmdzLi4uCgpJY2ssIG5vLCB5b3UgYXJlIDYgbW9udGhzIGJlaGluZCB3aGVyZSB0aGUgcmVzdCBv ZiB1cyBhcmUgOigKCkFsd2F5cywgYXQgdGhlIHZlcnkgbGVhc3QsIHdvcmsgb2ZmIG9mIExpbnVz J3MgdHJlZS4gIEZvciBiZXN0IHJlc3VsdHMsCndvcmsgb2ZmIG9mIGxpbnV4LW5leHQuCgp0aGFu a3MsCgpncmVnIGstaAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 201CBC43381 for ; Wed, 20 Feb 2019 16:22:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D56E720880 for ; Wed, 20 Feb 2019 16:22:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550679740; bh=fhYMzW8a8EF9pe32EJElYf1tc9spgS9Uz6UOvPJERAs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=vaFMlY9cMZOWZu5U6QAdBkDO1/QJlf96qKme4kWg7zoSFXexaPtSwRAAS+vQ7iEtB xKdA4agOs7pi5ZPAbBxkTG/jAVDPBp+oOOGrhTFGNN8oAft9vnfIq7YWanQ3T5Ssyo zYdFLztgVIuaSvLb7TMWBITJjJf/efiFJwBCYIHQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726738AbfBTQWS (ORCPT ); Wed, 20 Feb 2019 11:22:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:50276 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725836AbfBTQWR (ORCPT ); Wed, 20 Feb 2019 11:22:17 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C91892146E; Wed, 20 Feb 2019 16:22:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550679737; bh=fhYMzW8a8EF9pe32EJElYf1tc9spgS9Uz6UOvPJERAs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=szbFMox9vttCEethehu0Ekvfn7uE5GK2Mbos/gLnWVfF9C4dM6n0nZ8ZcheUH7QPM 3newzFKmHa/hXQzMt6dL/t4jgqXYC2B6A6k0KZyLT96daIRFV8D52I0BSWwIuwMhxy Khs1K5vsv37jNqKJYXa6DcZX/7hs1rEFTyDL7Xiw= Date: Wed, 20 Feb 2019 17:22:14 +0100 From: Greg Kroah-Hartman To: Nikolaus Voss Cc: Heikki Krogerus , Guenter Roeck , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters Message-ID: <20190220162214.GA2017@kroah.com> References: <20180425142209.30745-1-heikki.krogerus@linux.intel.com> <20190220110017.BFA344CE86@mail.steuer-voss.de> <20190220125731.02E274CFE0@mail.steuer-voss.de> <20190220150227.GA17103@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 20, 2019 at 04:22:00PM +0100, Nikolaus Voss wrote: > > > v2: fix tps6598x_exec_cmd also > > > --- > > > drivers/usb/typec/tps6598x.c | 26 ++++++++++++++++++++------ > > > 1 file changed, 20 insertions(+), 6 deletions(-) > > > > > > diff --git a/drivers/usb/typec/tps6598x.c b/drivers/usb/typec/tps6598x.c > > > index c84c8c189e90..c54b73fb2a2f 100644 > > > --- a/drivers/usb/typec/tps6598x.c > > > +++ b/drivers/usb/typec/tps6598x.c > > > @@ -110,6 +110,20 @@ tps6598x_block_read(struct tps6598x *tps, u8 reg, void *val, size_t len) > > > return 0; > > > } > > > > > > +static int tps6598x_block_write(struct tps6598x *tps, u8 reg, > > > + void *val, size_t len) > > > +{ > > > + u8 data[len + 1]; > > > > I thought the build system now warned when you did this :( > > I must admit I'm developing on 4.19 stable series, so no warnings... Ick, no, you are 6 months behind where the rest of us are :( Always, at the very least, work off of Linus's tree. For best results, work off of linux-next. thanks, greg k-h