From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+ From: Stanislaw Gruszka Message-Id: <20190220163229.GB14165@redhat.com> Date: Wed, 20 Feb 2019 17:32:29 +0100 To: Lorenzo Bianconi Cc: Felix Fietkau , Stefan Wahren , Alan Stern , Doug Anderson , Minas Harutyunyan , USB list , linux-wireless List-ID: T24gV2VkLCBGZWIgMjAsIDIwMTkgYXQgMDU6MjI6MThQTSArMDEwMCwgTG9yZW56byBCaWFuY29u aSB3cm90ZToKPiA+IE9uIFdlZCwgRmViIDIwLCAyMDE5IGF0IDAyOjIyOjA4UE0gKzAxMDAsIExv cmVuem8gQmlhbmNvbmkgd3JvdGU6Cj4gPiA+ID4gT24gVHVlLCBGZWIgMTksIDIwMTkgYXQgMDE6 MTk6MjZQTSArMDEwMCwgRmVsaXggRmlldGthdSB3cm90ZToKPiA+ID4gPiA+ID4+ID4+IFRoZSB3 YXkgSSBzZWUgaXQsIHdlIGhhdmUgdHdvIGNob2ljZXMuCj4gPiA+ID4gPiA+PiA+PiAxLiBGaXgg ZHdjMiB0byBkbyBpdHMgYWxpZ25tZW50IHF1aXJrIGZvciB0aGUgdXJiLT5zZyAhPSBOVUxMIGNh c2UKPiA+ID4gPiA+ID4+ID4+IDIuIFJlbHkgb24gdXJiLT50cmFuc2Zlcl9idWZmZXIgYW5kIGtl ZXAgdXJiLT5zZyBOVUxMCj4gPiA+ID4gPiA+PiA+IAo+ID4gPiA+ID4gPj4gPiBJIGFncmVlLCBp ZiB0aGlzIGlzIG9ubHkgbmVlZGVkIGZvciBkd2MyLiBUaG91Z2ggSSB3b3VsZCBpbnZlc3RpZ2F0 ZQo+ID4gPiA+ID4gPj4gPiBpZiB0aGlzIGlzIG5vdCBhIGJ1ZyBvbiBvdGhlciBwbGF0Zm9ybXMg YXMgd2VsbC4KPiA+ID4gPiA+ID4+ID5Gcm9tIHdoYXQgSSBjYW4gc2VlLCB1c2luZyBMb3Jlbnpv J3MgcGF0Y2hlcyBzZWVtcyB0byBiZSB0aGUgYmV0dGVyCj4gPiA+ID4gPiA+PiBzb2x1dGlvbiwg c2luY2UgdGhleSBhdm9pZCB0aGVzZSBjb3JuZXIgY2FzZXMgaW4gZHdjMiAoYW5kIG1heWJlIG90 aGVyCj4gPiA+ID4gPiA+PiBkcml2ZXJzIGFzIHdlbGwpLiBJIHdpbGwgYXBwbHkgdGhlbSBhbmQg dGhlbiB3ZSdsbCBzZWUgaWYgd2UgbmVlZCB0byBkbwo+ID4gPiA+ID4gPj4gYW55IGZ1cnRoZXIg aW1wcm92ZW1lbnRzIGxhdGVyIG9uLgo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gVGhleSB3b3Jr IG9uIHJwaSBkd2MyLCBidXQgdGhleSBkbyBub3QgYWRkcmVzcyByb290IG9mIHRoZSBwcm9ibGVt Lgo+ID4gPiA+ID4gPiBUaGVyZSBpcyBjbGVhcmx5IHNvbWV0aGluZyB3cm9uZyBob3cgbXQ3NnVz YiBoYW5kbGUgU0csIHdoYXQgaXMgbm90Cj4gPiA+ID4gPiA+IGZpeGVkLiBBbmQgYWRkaW5nIGRp c2FibGVfdXNiX3NnIG1vZHVsZSBwYXJhbWV0ZXIgZm9yIGhjZCdzIHN1cHBvcnRpbmcKPiA+ID4g PiA+ID4gU0cgc2hvdWxkIGJlIHJlZCBmbGFnLgo+ID4gPiA+ID4gSSB0aGluayB3ZSdyZSBzaW1w bHkgZGVhbGluZyB3aXRoIG11bHRpcGxlIGlzc3VlcyBoZXJlLCBvbmx5IHNvbWUgb2YKPiA+ID4g PiA+IHdoaWNoIGFyZSBmaXhlZCBieSBMb3JlbnpvJ3MgcGF0Y2hlcy4KPiA+ID4gPiA+IEknbSBw cmV0dHkgc3VyZSBpdCdzIHN0aWxsIHdyb25nIGZvciBtdDc2IHRvIHRyeSB0byBhbGlnbiBpdHMg YnVmZmVycywKPiA+ID4gPiA+IHNpbmNlIHRoZSBMaW51eCBVU0IgQVBJIHN1cHBvcnRzIG5vbi1h bGlnbmVkIHRyYW5zZmVyIGJ1ZmZlcnMgYW5kIGl0Cj4gPiA+ID4gPiBzaG91bGQgYmUgdXAgdG8g dGhlIGNvbnRyb2xsZXIgZHJpdmVyIHRvIGRlYWwgd2l0aCB0aGF0Lgo+ID4gPiA+IAo+ID4gPiA+ IEFncmVlLgo+ID4gPiA+IAo+ID4gPiA+ID4gZHdjMiB0cmllcyB0byBkbyB0aGF0LCBidXQgdGhh dCBoYXMgbGltaXRhdGlvbnMgd2hpY2ggSSBhbHJlYWR5IHBvaW50ZWQKPiA+ID4gPiA+IG91dCBh bmQgd2hpY2ggYXJlIHByb3Blcmx5IGRlYWx0IHdpdGggYnkgTG9yZW56bydzIHBhdGNoZXMuCj4g PiA+ID4gCj4gPiA+ID4gSSBwbGFuZWQgdG8ganVzdCBhY2NlcHQgY3VycmVudCBzb2x1dGlvbiwg YnV0IEkgc3RhcnRlZCB0byB3b3JrIG9uIHBhdGNoCj4gPiA+ID4gdGhhdCByZW1vdmUgbGVuLCBz Z2xlbiBhcmd1bWVudHMgZnJvbSBtdDc2dV9idWZfYWxsb2MoKSBhbmQgdXNlCj4gPiA+ID4gcS0+ YnVmX3NpemUgYW5kIFNLQl9XSVRIX09WRVJIRUFEKHEtPmJ1Zl9zaXplKSBkaXJlY3RseSBhbmQg cmVhbGl6ZWQgaG93Cj4gPiA+ID4gcmVsYXRlZCBjb2RlIGlzIG5vdyB0YW5nbGVkLgo+ID4gPiA+ IAo+ID4gPiA+IFdvdWxkIGJlIG9rIHRvIHNlbmQgdGhpcyBwYXRjaCB3aXRoIHByb3BlciBjaGFu Z2Vsb2cgYXMgZml4IGZvciBSUEkKPiA+ID4gPiBhZ2FpbnN0IHdpcmVsZXNzLWRyaXZlcnMgYW5k IGNjOnN0YWJsZSAoYXNzdW1pbmcgaXQgd29ya3MgYW5kIHJlYWxseQo+ID4gPiA+IGZpeCB0aGlu Z3Mgb24gUlBJKSBhbmQgcmV2ZXJ0IExvcmVuem8ncyBwYXRjaGVzIGluIC1uZXh0ID8KPiA+ID4g Cj4gPiA+IEhpIFN0YW5pc2xhdywKPiA+ID4gCj4gPiA+IHdoYXQgaXMgdGhlIGFkdmFudGFnZSBv ZiBkb2luZyBzbz8KPiA+IFRvIGhhdmUgc21hbGwgZml4IHByb3BlciBmb3IgLXN0YWJsZSB0byBm aXggdGhlIHByb2JsZW0gaW4gNC4yMCBhbmQgNC4xOSwKPiA+IGFuZCBoYXZlIHNpbXBsZXIgY29k ZS4KPiAKPiBtZXJnaW5nIHRoZSBzZXJpZXMgSSBzZW50IHdlIHdpbGwgaGF2ZSBhIHByZXR0eSBz aW1wbGUgYXBwcm9hY2gsIGp1c3QgYQo+IHNpbmdsZSByb3V0aW5lIHRoYXQgYWxsb2NhdGVzIHRo ZSByeCBidWZmZXJzIGluIHRoZSBjb250cm9sIHBhdGggYWNjb3JkaW5nIHRvCj4gdGhlIG9wZXJh dGluZyBtb2RlLgoKU28gd2lsbCB5b3UgZG8gdGhlIGJhY2twb3J0IG9mIHlvdXIgcGF0Y2hlcyBh bmQgcG9zdCB0aGVtIHRvIC1zdGFibGUgPwpEbyB5b3UgdGhpbmsgZ3JlZy1raCB3aWxsIGFjY2Vw dCB0aG9zZSA/CgpTdGFuaXNsYXcK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1C5AC43381 for ; Wed, 20 Feb 2019 16:32:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B49D02147A for ; Wed, 20 Feb 2019 16:32:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726389AbfBTQcd (ORCPT ); Wed, 20 Feb 2019 11:32:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44970 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725796AbfBTQcd (ORCPT ); Wed, 20 Feb 2019 11:32:33 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 15BBFC0C275F; Wed, 20 Feb 2019 16:32:33 +0000 (UTC) Received: from localhost (ovpn-204-136.brq.redhat.com [10.40.204.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7757F600C0; Wed, 20 Feb 2019 16:32:30 +0000 (UTC) Date: Wed, 20 Feb 2019 17:32:29 +0100 From: Stanislaw Gruszka To: Lorenzo Bianconi Cc: Felix Fietkau , Stefan Wahren , Alan Stern , Doug Anderson , Minas Harutyunyan , USB list , linux-wireless Subject: Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+ Message-ID: <20190220163229.GB14165@redhat.com> References: <20190218135247.GA9602@redhat.com> <0e29e99a-6ed4-40fe-1f38-30f1b5530a16@nbd.name> <20190218150303.GD9602@redhat.com> <20190219104208.GA22999@redhat.com> <58097bb1-d726-c48e-2a40-2e12098dfb15@nbd.name> <20190220130009.GA2377@redhat.com> <20190220132206.GF2626@localhost.localdomain> <20190220161415.GA14165@redhat.com> <20190220162217.GH2626@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190220162217.GH2626@localhost.localdomain> User-Agent: Mutt/1.8.3 (2017-05-23) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 20 Feb 2019 16:32:33 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, Feb 20, 2019 at 05:22:18PM +0100, Lorenzo Bianconi wrote: > > On Wed, Feb 20, 2019 at 02:22:08PM +0100, Lorenzo Bianconi wrote: > > > > On Tue, Feb 19, 2019 at 01:19:26PM +0100, Felix Fietkau wrote: > > > > > >> >> The way I see it, we have two choices. > > > > > >> >> 1. Fix dwc2 to do its alignment quirk for the urb->sg != NULL case > > > > > >> >> 2. Rely on urb->transfer_buffer and keep urb->sg NULL > > > > > >> > > > > > > >> > I agree, if this is only needed for dwc2. Though I would investigate > > > > > >> > if this is not a bug on other platforms as well. > > > > > >> >From what I can see, using Lorenzo's patches seems to be the better > > > > > >> solution, since they avoid these corner cases in dwc2 (and maybe other > > > > > >> drivers as well). I will apply them and then we'll see if we need to do > > > > > >> any further improvements later on. > > > > > > > > > > > > They work on rpi dwc2, but they do not address root of the problem. > > > > > > There is clearly something wrong how mt76usb handle SG, what is not > > > > > > fixed. And adding disable_usb_sg module parameter for hcd's supporting > > > > > > SG should be red flag. > > > > > I think we're simply dealing with multiple issues here, only some of > > > > > which are fixed by Lorenzo's patches. > > > > > I'm pretty sure it's still wrong for mt76 to try to align its buffers, > > > > > since the Linux USB API supports non-aligned transfer buffers and it > > > > > should be up to the controller driver to deal with that. > > > > > > > > Agree. > > > > > > > > > dwc2 tries to do that, but that has limitations which I already pointed > > > > > out and which are properly dealt with by Lorenzo's patches. > > > > > > > > I planed to just accept current solution, but I started to work on patch > > > > that remove len, sglen arguments from mt76u_buf_alloc() and use > > > > q->buf_size and SKB_WITH_OVERHEAD(q->buf_size) directly and realized how > > > > related code is now tangled. > > > > > > > > Would be ok to send this patch with proper changelog as fix for RPI > > > > against wireless-drivers and cc:stable (assuming it works and really > > > > fix things on RPI) and revert Lorenzo's patches in -next ? > > > > > > Hi Stanislaw, > > > > > > what is the advantage of doing so? > > To have small fix proper for -stable to fix the problem in 4.20 and 4.19, > > and have simpler code. > > merging the series I sent we will have a pretty simple approach, just a > single routine that allocates the rx buffers in the control path according to > the operating mode. So will you do the backport of your patches and post them to -stable ? Do you think greg-kh will accept those ? Stanislaw