From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+ From: Lorenzo Bianconi Message-Id: <20190220163609.GI2626@localhost.localdomain> Date: Wed, 20 Feb 2019 17:36:10 +0100 To: Stanislaw Gruszka Cc: Felix Fietkau , Stefan Wahren , Alan Stern , Doug Anderson , Minas Harutyunyan , USB list , linux-wireless List-ID: PiBPbiBXZWQsIEZlYiAyMCwgMjAxOSBhdCAwNToyMjoxOFBNICswMTAwLCBMb3JlbnpvIEJpYW5j b25pIHdyb3RlOgo+ID4gPiBPbiBXZWQsIEZlYiAyMCwgMjAxOSBhdCAwMjoyMjowOFBNICswMTAw LCBMb3JlbnpvIEJpYW5jb25pIHdyb3RlOgo+ID4gPiA+ID4gT24gVHVlLCBGZWIgMTksIDIwMTkg YXQgMDE6MTk6MjZQTSArMDEwMCwgRmVsaXggRmlldGthdSB3cm90ZToKPiA+ID4gPiA+ID4gPj4g Pj4gVGhlIHdheSBJIHNlZSBpdCwgd2UgaGF2ZSB0d28gY2hvaWNlcy4KPiA+ID4gPiA+ID4gPj4g Pj4gMS4gRml4IGR3YzIgdG8gZG8gaXRzIGFsaWdubWVudCBxdWlyayBmb3IgdGhlIHVyYi0+c2cg IT0gTlVMTCBjYXNlCj4gPiA+ID4gPiA+ID4+ID4+IDIuIFJlbHkgb24gdXJiLT50cmFuc2Zlcl9i dWZmZXIgYW5kIGtlZXAgdXJiLT5zZyBOVUxMCj4gPiA+ID4gPiA+ID4+ID4gCj4gPiA+ID4gPiA+ ID4+ID4gSSBhZ3JlZSwgaWYgdGhpcyBpcyBvbmx5IG5lZWRlZCBmb3IgZHdjMi4gVGhvdWdoIEkg d291bGQgaW52ZXN0aWdhdGUKPiA+ID4gPiA+ID4gPj4gPiBpZiB0aGlzIGlzIG5vdCBhIGJ1ZyBv biBvdGhlciBwbGF0Zm9ybXMgYXMgd2VsbC4KPiA+ID4gPiA+ID4gPj4gPkZyb20gd2hhdCBJIGNh biBzZWUsIHVzaW5nIExvcmVuem8ncyBwYXRjaGVzIHNlZW1zIHRvIGJlIHRoZSBiZXR0ZXIKPiA+ ID4gPiA+ID4gPj4gc29sdXRpb24sIHNpbmNlIHRoZXkgYXZvaWQgdGhlc2UgY29ybmVyIGNhc2Vz IGluIGR3YzIgKGFuZCBtYXliZSBvdGhlcgo+ID4gPiA+ID4gPiA+PiBkcml2ZXJzIGFzIHdlbGwp LiBJIHdpbGwgYXBwbHkgdGhlbSBhbmQgdGhlbiB3ZSdsbCBzZWUgaWYgd2UgbmVlZCB0byBkbwo+ ID4gPiA+ID4gPiA+PiBhbnkgZnVydGhlciBpbXByb3ZlbWVudHMgbGF0ZXIgb24uCj4gPiA+ID4g PiA+ID4gCj4gPiA+ID4gPiA+ID4gVGhleSB3b3JrIG9uIHJwaSBkd2MyLCBidXQgdGhleSBkbyBu b3QgYWRkcmVzcyByb290IG9mIHRoZSBwcm9ibGVtLgo+ID4gPiA+ID4gPiA+IFRoZXJlIGlzIGNs ZWFybHkgc29tZXRoaW5nIHdyb25nIGhvdyBtdDc2dXNiIGhhbmRsZSBTRywgd2hhdCBpcyBub3QK PiA+ID4gPiA+ID4gPiBmaXhlZC4gQW5kIGFkZGluZyBkaXNhYmxlX3VzYl9zZyBtb2R1bGUgcGFy YW1ldGVyIGZvciBoY2QncyBzdXBwb3J0aW5nCj4gPiA+ID4gPiA+ID4gU0cgc2hvdWxkIGJlIHJl ZCBmbGFnLgo+ID4gPiA+ID4gPiBJIHRoaW5rIHdlJ3JlIHNpbXBseSBkZWFsaW5nIHdpdGggbXVs dGlwbGUgaXNzdWVzIGhlcmUsIG9ubHkgc29tZSBvZgo+ID4gPiA+ID4gPiB3aGljaCBhcmUgZml4 ZWQgYnkgTG9yZW56bydzIHBhdGNoZXMuCj4gPiA+ID4gPiA+IEknbSBwcmV0dHkgc3VyZSBpdCdz IHN0aWxsIHdyb25nIGZvciBtdDc2IHRvIHRyeSB0byBhbGlnbiBpdHMgYnVmZmVycywKPiA+ID4g PiA+ID4gc2luY2UgdGhlIExpbnV4IFVTQiBBUEkgc3VwcG9ydHMgbm9uLWFsaWduZWQgdHJhbnNm ZXIgYnVmZmVycyBhbmQgaXQKPiA+ID4gPiA+ID4gc2hvdWxkIGJlIHVwIHRvIHRoZSBjb250cm9s bGVyIGRyaXZlciB0byBkZWFsIHdpdGggdGhhdC4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gQWdyZWUu Cj4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gZHdjMiB0cmllcyB0byBkbyB0aGF0LCBidXQgdGhhdCBo YXMgbGltaXRhdGlvbnMgd2hpY2ggSSBhbHJlYWR5IHBvaW50ZWQKPiA+ID4gPiA+ID4gb3V0IGFu ZCB3aGljaCBhcmUgcHJvcGVybHkgZGVhbHQgd2l0aCBieSBMb3JlbnpvJ3MgcGF0Y2hlcy4KPiA+ ID4gPiA+IAo+ID4gPiA+ID4gSSBwbGFuZWQgdG8ganVzdCBhY2NlcHQgY3VycmVudCBzb2x1dGlv biwgYnV0IEkgc3RhcnRlZCB0byB3b3JrIG9uIHBhdGNoCj4gPiA+ID4gPiB0aGF0IHJlbW92ZSBs ZW4sIHNnbGVuIGFyZ3VtZW50cyBmcm9tIG10NzZ1X2J1Zl9hbGxvYygpIGFuZCB1c2UKPiA+ID4g PiA+IHEtPmJ1Zl9zaXplIGFuZCBTS0JfV0lUSF9PVkVSSEVBRChxLT5idWZfc2l6ZSkgZGlyZWN0 bHkgYW5kIHJlYWxpemVkIGhvdwo+ID4gPiA+ID4gcmVsYXRlZCBjb2RlIGlzIG5vdyB0YW5nbGVk Lgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBXb3VsZCBiZSBvayB0byBzZW5kIHRoaXMgcGF0Y2ggd2l0 aCBwcm9wZXIgY2hhbmdlbG9nIGFzIGZpeCBmb3IgUlBJCj4gPiA+ID4gPiBhZ2FpbnN0IHdpcmVs ZXNzLWRyaXZlcnMgYW5kIGNjOnN0YWJsZSAoYXNzdW1pbmcgaXQgd29ya3MgYW5kIHJlYWxseQo+ ID4gPiA+ID4gZml4IHRoaW5ncyBvbiBSUEkpIGFuZCByZXZlcnQgTG9yZW56bydzIHBhdGNoZXMg aW4gLW5leHQgPwo+ID4gPiA+IAo+ID4gPiA+IEhpIFN0YW5pc2xhdywKPiA+ID4gPiAKPiA+ID4g PiB3aGF0IGlzIHRoZSBhZHZhbnRhZ2Ugb2YgZG9pbmcgc28/Cj4gPiA+IFRvIGhhdmUgc21hbGwg Zml4IHByb3BlciBmb3IgLXN0YWJsZSB0byBmaXggdGhlIHByb2JsZW0gaW4gNC4yMCBhbmQgNC4x OSwKPiA+ID4gYW5kIGhhdmUgc2ltcGxlciBjb2RlLgo+ID4gCj4gPiBtZXJnaW5nIHRoZSBzZXJp ZXMgSSBzZW50IHdlIHdpbGwgaGF2ZSBhIHByZXR0eSBzaW1wbGUgYXBwcm9hY2gsIGp1c3QgYQo+ ID4gc2luZ2xlIHJvdXRpbmUgdGhhdCBhbGxvY2F0ZXMgdGhlIHJ4IGJ1ZmZlcnMgaW4gdGhlIGNv bnRyb2wgcGF0aCBhY2NvcmRpbmcgdG8KPiA+IHRoZSBvcGVyYXRpbmcgbW9kZS4KPiAKPiBTbyB3 aWxsIHlvdSBkbyB0aGUgYmFja3BvcnQgb2YgeW91ciBwYXRjaGVzIGFuZCBwb3N0IHRoZW0gdG8g LXN0YWJsZSA/Cj4gRG8geW91IHRoaW5rIGdyZWcta2ggd2lsbCBhY2NlcHQgdGhvc2UgPwoKSSB3 aWxsIHRha2UgY2FyZSBvZiBpdAoKUmVnYXJkcywKTG9yZW56bwoKPiAKPiBTdGFuaXNsYXcK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F527C43381 for ; Wed, 20 Feb 2019 16:36:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3AC7A2147C for ; Wed, 20 Feb 2019 16:36:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726313AbfBTQgQ (ORCPT ); Wed, 20 Feb 2019 11:36:16 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:38348 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726420AbfBTQgP (ORCPT ); Wed, 20 Feb 2019 11:36:15 -0500 Received: by mail-wm1-f65.google.com with SMTP id v26so7053076wmh.3 for ; Wed, 20 Feb 2019 08:36:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5zUrReAbPC5w2ll0Bc1Mc4+Sr9vzmUkeHZRHO89+xB4=; b=Z0BBa4TeVxqPIgK+csJ4etlJGF9Vd5ZL7LevpMdQr0FYd5FOpRMxjfD3ZKLdTYe8+L AQ1oFs8dtpWURHundqEe1+AbmIE5Eemvz2vGzA8RRRsZwypgd2MUILTfY7I8pY9r0ZDz 4YD8mHx+QS0X5/rxa3xmf9xEEA1+/Wu9iyrBIBMUU+CUmHcnl0V8cPOD6U9Or6r3cBjg d3taIfJJA5t12lzqvnaRioWfVHGkZWIoJqUnSvyAp+n641lOp0KmOP+SpUa19oo6rnWs KSjzIy+4Un0WYGlLCtsIq3z+Uve/0qLBOuJpmp6Qgrixq17kSDK+1XHy5/vuHzE2D71v WO8Q== X-Gm-Message-State: AHQUAub6eaRMn09QTYwRf/KUa3yWkuDkbLvnW67wS5lx0hiz1QPyYsHx bk4edLLtSBMDRYSqIOpaOKaO7w== X-Google-Smtp-Source: AHgI3IZg9fwz9EKCBvsUr/r4OeGBiADL2mrqYyy9wOxocbqLU+BGpYPlR959PJWmrs7TFFh6lSm46g== X-Received: by 2002:a1c:7610:: with SMTP id r16mr7186730wmc.139.1550680573004; Wed, 20 Feb 2019 08:36:13 -0800 (PST) Received: from localhost.localdomain (nat-pool-mxp-t.redhat.com. [149.6.153.186]) by smtp.gmail.com with ESMTPSA id z6sm7164568wml.40.2019.02.20.08.36.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Feb 2019 08:36:12 -0800 (PST) Date: Wed, 20 Feb 2019 17:36:10 +0100 From: Lorenzo Bianconi To: Stanislaw Gruszka Cc: Felix Fietkau , Stefan Wahren , Alan Stern , Doug Anderson , Minas Harutyunyan , USB list , linux-wireless Subject: Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+ Message-ID: <20190220163609.GI2626@localhost.localdomain> References: <0e29e99a-6ed4-40fe-1f38-30f1b5530a16@nbd.name> <20190218150303.GD9602@redhat.com> <20190219104208.GA22999@redhat.com> <58097bb1-d726-c48e-2a40-2e12098dfb15@nbd.name> <20190220130009.GA2377@redhat.com> <20190220132206.GF2626@localhost.localdomain> <20190220161415.GA14165@redhat.com> <20190220162217.GH2626@localhost.localdomain> <20190220163229.GB14165@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190220163229.GB14165@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > On Wed, Feb 20, 2019 at 05:22:18PM +0100, Lorenzo Bianconi wrote: > > > On Wed, Feb 20, 2019 at 02:22:08PM +0100, Lorenzo Bianconi wrote: > > > > > On Tue, Feb 19, 2019 at 01:19:26PM +0100, Felix Fietkau wrote: > > > > > > >> >> The way I see it, we have two choices. > > > > > > >> >> 1. Fix dwc2 to do its alignment quirk for the urb->sg != NULL case > > > > > > >> >> 2. Rely on urb->transfer_buffer and keep urb->sg NULL > > > > > > >> > > > > > > > >> > I agree, if this is only needed for dwc2. Though I would investigate > > > > > > >> > if this is not a bug on other platforms as well. > > > > > > >> >From what I can see, using Lorenzo's patches seems to be the better > > > > > > >> solution, since they avoid these corner cases in dwc2 (and maybe other > > > > > > >> drivers as well). I will apply them and then we'll see if we need to do > > > > > > >> any further improvements later on. > > > > > > > > > > > > > > They work on rpi dwc2, but they do not address root of the problem. > > > > > > > There is clearly something wrong how mt76usb handle SG, what is not > > > > > > > fixed. And adding disable_usb_sg module parameter for hcd's supporting > > > > > > > SG should be red flag. > > > > > > I think we're simply dealing with multiple issues here, only some of > > > > > > which are fixed by Lorenzo's patches. > > > > > > I'm pretty sure it's still wrong for mt76 to try to align its buffers, > > > > > > since the Linux USB API supports non-aligned transfer buffers and it > > > > > > should be up to the controller driver to deal with that. > > > > > > > > > > Agree. > > > > > > > > > > > dwc2 tries to do that, but that has limitations which I already pointed > > > > > > out and which are properly dealt with by Lorenzo's patches. > > > > > > > > > > I planed to just accept current solution, but I started to work on patch > > > > > that remove len, sglen arguments from mt76u_buf_alloc() and use > > > > > q->buf_size and SKB_WITH_OVERHEAD(q->buf_size) directly and realized how > > > > > related code is now tangled. > > > > > > > > > > Would be ok to send this patch with proper changelog as fix for RPI > > > > > against wireless-drivers and cc:stable (assuming it works and really > > > > > fix things on RPI) and revert Lorenzo's patches in -next ? > > > > > > > > Hi Stanislaw, > > > > > > > > what is the advantage of doing so? > > > To have small fix proper for -stable to fix the problem in 4.20 and 4.19, > > > and have simpler code. > > > > merging the series I sent we will have a pretty simple approach, just a > > single routine that allocates the rx buffers in the control path according to > > the operating mode. > > So will you do the backport of your patches and post them to -stable ? > Do you think greg-kh will accept those ? I will take care of it Regards, Lorenzo > > Stanislaw