All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, mreitz@redhat.com, eblake@redhat.com,
	pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 10/13] block: Fix AioContext switch for drained node
Date: Wed, 20 Feb 2019 18:48:40 +0100	[thread overview]
Message-ID: <20190220174843.8847-11-kwolf@redhat.com> (raw)
In-Reply-To: <20190220174843.8847-1-kwolf@redhat.com>

When a drained node changes its AioContext, we need to move its
aio_disable_external() to the new context, too.

Without this fix, drain_end will try to reenable the new context, which
has never been disabled, so an assertion failure is triggered.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 block.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/block.c b/block.c
index 17bc1d3dca..aefb5701f5 100644
--- a/block.c
+++ b/block.c
@@ -5227,6 +5227,9 @@ void bdrv_detach_aio_context(BlockDriverState *bs)
         bdrv_detach_aio_context(child->bs);
     }
 
+    if (bs->quiesce_counter) {
+        aio_enable_external(bs->aio_context);
+    }
     bs->aio_context = NULL;
 }
 
@@ -5240,6 +5243,10 @@ void bdrv_attach_aio_context(BlockDriverState *bs,
         return;
     }
 
+    if (bs->quiesce_counter) {
+        aio_disable_external(new_context);
+    }
+
     bs->aio_context = new_context;
 
     QLIST_FOREACH(child, &bs->children, next) {
-- 
2.20.1

  parent reply	other threads:[~2019-02-20 17:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-20 17:48 [Qemu-devel] [PATCH v2 00/13] block: bdrv_set_aio_context() related fixes Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 01/13] block-backend: Make blk_inc/dec_in_flight public Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 02/13] virtio-blk: Increase in_flight for request restart BH Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 03/13] nbd: Restrict connection_co reentrance Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 04/13] io: Make qio_channel_yield() interruptible Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 05/13] io: Remove redundant read/write_coroutine assignments Kevin Wolf
2019-02-20 18:01   ` Paolo Bonzini
2019-02-20 18:07     ` Kevin Wolf
2019-02-20 18:22       ` Paolo Bonzini
2019-02-21  9:03         ` Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 06/13] nbd: Move nbd_read_eof() to nbd/client.c Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 07/13] nbd: Use low-level QIOChannel API in nbd_read_eof() Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 08/13] nbd: Increase bs->in_flight during AioContext switch Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 09/13] block: Don't poll in bdrv_set_aio_context() Kevin Wolf
2019-02-20 17:48 ` Kevin Wolf [this message]
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 11/13] test-bdrv-drain: AioContext switch in drained section Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 12/13] block: Use normal drain for bdrv_set_aio_context() Kevin Wolf
2019-02-20 17:48 ` [Qemu-devel] [PATCH v2 13/13] aio-posix: Assert that aio_poll() is always called in home thread Kevin Wolf
2019-02-25 10:31 ` [Qemu-devel] [PATCH v2 00/13] block: bdrv_set_aio_context() related fixes Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190220174843.8847-11-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=eblake@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.